)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"bcc7be726e5084e036d503a3dc8ede4a17c8dbea","unresolved":false,"context_lines":[{"line_number":4793,"context_line":"        supported_archs \u003d [fields.Architecture.X86_64,"},{"line_number":4794,"context_line":"                           fields.Architecture.AARCH64]"},{"line_number":4795,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":4796,"context_line":"        # TODO(dmllr): Instead of probing UEFI_LOADER_PATHS, we should query"},{"line_number":4797,"context_line":"        # libvirt domCapabilities that should be configured correctly"},{"line_number":4798,"context_line":"        # whether UEFI is available or not"},{"line_number":4799,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfbec78f_6e6f5e92","line":4796,"updated":"2019-05-07 23:35:17.000000000","message":"Hopefully my patch adding support for getDomainCapabilities() should land very soon.","commit_id":"5fe67138457dd47d0f61b723c9c4081d146d9302"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a4d9143efa5107799a62a18814198a7e5f09576c","unresolved":false,"context_lines":[{"line_number":4986,"context_line":"        # features, architecture, supported machine type, NVRAM template"},{"line_number":4987,"context_line":"        # and so forth."},{"line_number":4988,"context_line":""},{"line_number":4989,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":4990,"context_line":"                any((os.path.exists(p)"},{"line_number":4991,"context_line":"                     for p in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch])))"},{"line_number":4992,"context_line":""},{"line_number":4993,"context_line":"    def _get_supported_perf_events(self):"},{"line_number":4994,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_b7df8b64","line":4991,"range":{"start_line":4989,"start_character":0,"end_line":4991,"end_character":77},"updated":"2019-08-01 08:40:56.000000000","message":"nit: I think this can be rewritten like so:\n\n  arch \u003d self._host.get_capabilities().host.cpu.arch\n  return any(os.path.exists(p) for p in DEFAULT_UEFI_LOADER_PATH.get(arch) or [])\n\n(i.e. you don\u0027t need the \u0027supported_arches\u0027 field if you use the \u0027dict.get\u0027 method)","commit_id":"363710b655434a15b6b85d9ca65343210b104e56"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8f0cbd1ca82a26994e25097ddd97b168694d8283","unresolved":false,"context_lines":[{"line_number":4986,"context_line":"        # features, architecture, supported machine type, NVRAM template"},{"line_number":4987,"context_line":"        # and so forth."},{"line_number":4988,"context_line":""},{"line_number":4989,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":4990,"context_line":"                any((os.path.exists(p)"},{"line_number":4991,"context_line":"                     for p in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch])))"},{"line_number":4992,"context_line":""},{"line_number":4993,"context_line":"    def _get_supported_perf_events(self):"},{"line_number":4994,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_3785db07","line":4991,"range":{"start_line":4989,"start_character":0,"end_line":4991,"end_character":77},"in_reply_to":"7faddb67_b7df8b64","updated":"2019-08-01 08:59:15.000000000","message":"Yeah, I like the suggestion, and it\u0027s slightly nicer to read. I\u0027ll wait for any other comments before I respin.\n\nThank you for the quick review.","commit_id":"363710b655434a15b6b85d9ca65343210b104e56"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"926b5fa5aa84ea40d3aa18326cf59dd8dee2d259","unresolved":false,"context_lines":[{"line_number":5047,"context_line":"                                    \"functional testing and therefore \""},{"line_number":5048,"context_line":"                                    \"considered experimental.\")"},{"line_number":5049,"context_line":"                        uefi_logged \u003d True"},{"line_number":5050,"context_line":"                    for lpath in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch]:"},{"line_number":5051,"context_line":"                        if os.path.exists(lpath):"},{"line_number":5052,"context_line":"                            guest.os_loader \u003d lpath"},{"line_number":5053,"context_line":"                    guest.os_loader_type \u003d \"pflash\""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_b550e3d6","line":5050,"updated":"2019-08-01 10:56:42.000000000","message":"Don\u0027t you need `.get` here too?  Otherwise you\u0027ll get a KeyError on other architectures.","commit_id":"363710b655434a15b6b85d9ca65343210b104e56"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"1ed5e1f4577d57cca5d31896b6bd43d1acdc353d","unresolved":false,"context_lines":[{"line_number":5047,"context_line":"                                    \"functional testing and therefore \""},{"line_number":5048,"context_line":"                                    \"considered experimental.\")"},{"line_number":5049,"context_line":"                        uefi_logged \u003d True"},{"line_number":5050,"context_line":"                    for lpath in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch]:"},{"line_number":5051,"context_line":"                        if os.path.exists(lpath):"},{"line_number":5052,"context_line":"                            guest.os_loader \u003d lpath"},{"line_number":5053,"context_line":"                    guest.os_loader_type \u003d \"pflash\""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_f1e2e8d4","line":5050,"in_reply_to":"7faddb67_4b71cea7","updated":"2019-08-01 17:35:56.000000000","message":"No, I mean regardless of whether you follow Stephen\u0027s suggestion.  This is in a different method.  If caps.host.cpu.arch is something like \u0027sparc\u0027 then you\u0027ll get a KeyError.","commit_id":"363710b655434a15b6b85d9ca65343210b104e56"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"32e1fd960152b921e4d5cc0657ad85713d236219","unresolved":false,"context_lines":[{"line_number":5047,"context_line":"                                    \"functional testing and therefore \""},{"line_number":5048,"context_line":"                                    \"considered experimental.\")"},{"line_number":5049,"context_line":"                        uefi_logged \u003d True"},{"line_number":5050,"context_line":"                    for lpath in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch]:"},{"line_number":5051,"context_line":"                        if os.path.exists(lpath):"},{"line_number":5052,"context_line":"                            guest.os_loader \u003d lpath"},{"line_number":5053,"context_line":"                    guest.os_loader_type \u003d \"pflash\""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_7cb48f82","line":5050,"in_reply_to":"7faddb67_7ca7afbd","updated":"2019-08-01 18:45:39.000000000","message":"Ah got it thanks.  OK so this is fine.","commit_id":"363710b655434a15b6b85d9ca65343210b104e56"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"c574dd914485b755308c39a54392f231baab3365","unresolved":false,"context_lines":[{"line_number":5047,"context_line":"                                    \"functional testing and therefore \""},{"line_number":5048,"context_line":"                                    \"considered experimental.\")"},{"line_number":5049,"context_line":"                        uefi_logged \u003d True"},{"line_number":5050,"context_line":"                    for lpath in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch]:"},{"line_number":5051,"context_line":"                        if os.path.exists(lpath):"},{"line_number":5052,"context_line":"                            guest.os_loader \u003d lpath"},{"line_number":5053,"context_line":"                    guest.os_loader_type \u003d \"pflash\""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_4b71cea7","line":5050,"in_reply_to":"7faddb67_b550e3d6","updated":"2019-08-01 13:08:25.000000000","message":"You mean, _if_ I update as Stephen suggests, then something like?: \n\n  for lpath in DEFAULT_UEFI_LOADER_PATH.get(arch) or []","commit_id":"363710b655434a15b6b85d9ca65343210b104e56"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89ebab11328801579fe4382b3315ef8ca7666116","unresolved":false,"context_lines":[{"line_number":5047,"context_line":"                                    \"functional testing and therefore \""},{"line_number":5048,"context_line":"                                    \"considered experimental.\")"},{"line_number":5049,"context_line":"                        uefi_logged \u003d True"},{"line_number":5050,"context_line":"                    for lpath in DEFAULT_UEFI_LOADER_PATH[caps.host.cpu.arch]:"},{"line_number":5051,"context_line":"                        if os.path.exists(lpath):"},{"line_number":5052,"context_line":"                            guest.os_loader \u003d lpath"},{"line_number":5053,"context_line":"                    guest.os_loader_type \u003d \"pflash\""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_7ca7afbd","line":5050,"in_reply_to":"7faddb67_f1e2e8d4","updated":"2019-08-01 18:22:09.000000000","message":"Nah, that can\u0027t happen because the self._has_uefi_support() call on line 5043 would have failed, meaning this block will never trigger","commit_id":"363710b655434a15b6b85d9ca65343210b104e56"}]}