)]}'
{"nova/conf/vnc.py":[{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"35c6a8bd0585b069e2c4343308fb2a50eb406561","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.BoolOpt("},{"line_number":27,"context_line":"        \u0027enabled\u0027,"},{"line_number":28,"context_line":"        default\u003dTrue,"},{"line_number":29,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":30,"context_line":"        deprecated_name\u003d\u0027vnc_enabled\u0027,"},{"line_number":31,"context_line":"        help\u003d\"\"\""},{"line_number":32,"context_line":"Enable VNC related features."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6ea96e7b","line":30,"range":{"start_line":29,"start_character":8,"end_line":30,"end_character":37},"updated":"2016-07-29 01:51:04.000000000","message":"these are there from liberty, i think we can remove them now.","commit_id":"3d4335d6330ca1e984d972109d0778b683ee7e48"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"35c6a8bd0585b069e2c4343308fb2a50eb406561","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt("},{"line_number":39,"context_line":"        \u0027keymap\u0027,"},{"line_number":40,"context_line":"        default\u003d\u0027en-us\u0027,"},{"line_number":41,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":42,"context_line":"        deprecated_name\u003d\u0027vnc_keymap\u0027,"},{"line_number":43,"context_line":"        help\u003d\"\"\""},{"line_number":44,"context_line":"Keymap for VNC."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ceb69adb","line":42,"range":{"start_line":41,"start_character":8,"end_line":42,"end_character":36},"updated":"2016-07-29 01:51:04.000000000","message":"ditto","commit_id":"3d4335d6330ca1e984d972109d0778b683ee7e48"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"9898b0e9a9e8942772d6278ec3d6e685958f7dea","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt("},{"line_number":39,"context_line":"        \u0027keymap\u0027,"},{"line_number":40,"context_line":"        default\u003d\u0027en-us\u0027,"},{"line_number":41,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":42,"context_line":"        deprecated_name\u003d\u0027vnc_keymap\u0027,"},{"line_number":43,"context_line":"        help\u003d\"\"\""},{"line_number":44,"context_line":"Keymap for VNC."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d9c5140b","line":42,"range":{"start_line":41,"start_character":8,"end_line":42,"end_character":36},"in_reply_to":"bacf61ea_427e7a6a","updated":"2016-08-02 15:26:35.000000000","message":"I didn\u0027t mean removing the option here, I am thinking if we can remove the deprecated_group and deprecated_name attributes since they have been from two cycles.","commit_id":"3d4335d6330ca1e984d972109d0778b683ee7e48"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"02f19f5c5283d53e4e6eb05ab19d3c878c931ade","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt("},{"line_number":39,"context_line":"        \u0027keymap\u0027,"},{"line_number":40,"context_line":"        default\u003d\u0027en-us\u0027,"},{"line_number":41,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":42,"context_line":"        deprecated_name\u003d\u0027vnc_keymap\u0027,"},{"line_number":43,"context_line":"        help\u003d\"\"\""},{"line_number":44,"context_line":"Keymap for VNC."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_427e7a6a","line":42,"range":{"start_line":41,"start_character":8,"end_line":42,"end_character":36},"in_reply_to":"bacf61ea_ceb69adb","updated":"2016-08-01 21:49:40.000000000","message":"Seems like this option was renamed and not deprecated. Am I missing anything? Also if deprecated it should have a flag \"deprecated\u003dtrue\"","commit_id":"3d4335d6330ca1e984d972109d0778b683ee7e48"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"35c6a8bd0585b069e2c4343308fb2a50eb406561","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  of supported keyboard layouts at ``/usr/share/qemu/keymaps``."},{"line_number":55,"context_line":"\"\"\"),"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # TODO(sfinucan): This should be an IPOpt"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027vncserver_listen\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6ed7aeed","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":45},"updated":"2016-07-29 01:51:04.000000000","message":"you can do all these TODO\u0027s in this patch under \"check_opt_group_and_type\" as you fixed PortOpt.","commit_id":"3d4335d6330ca1e984d972109d0778b683ee7e48"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3172b9c79449316191ef78e12324cdff79b9b71c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"``nova-xvpvncproxy``, should connect to."},{"line_number":80,"context_line":"\"\"\"),"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    cfg.StrOpt("},{"line_number":83,"context_line":"        \u0027novncproxy_base_url\u0027,"},{"line_number":84,"context_line":"        default\u003d\u0027http://127.0.0.1:6080/vnc_auto.html\u0027,"},{"line_number":85,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_76c87e75","line":82,"updated":"2016-08-08 10:26:05.000000000","message":"Nit: we now have a URIOpt","commit_id":"183363a7536bccfdc3b653fae81fa008412e585b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3172b9c79449316191ef78e12324cdff79b9b71c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"* xvpvncproxy_base_url"},{"line_number":145,"context_line":"\"\"\"),"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    cfg.StrOpt("},{"line_number":148,"context_line":"        \u0027xvpvncproxy_base_url\u0027,"},{"line_number":149,"context_line":"        default\u003d\u0027http://127.0.0.1:6081/console\u0027,"},{"line_number":150,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_f6aaae84","line":147,"updated":"2016-08-08 10:26:05.000000000","message":"As above, we have a URIOpt now.","commit_id":"183363a7536bccfdc3b653fae81fa008412e585b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3172b9c79449316191ef78e12324cdff79b9b71c","unresolved":false,"context_lines":[{"line_number":209,"context_line":"\"\"\"),"},{"line_number":210,"context_line":"]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"ALL_OPTS.extend(CLI_OPTS)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_96089293","line":212,"updated":"2016-08-08 10:26:05.000000000","message":"Not sure this feels totally correct, but this does seem to be doing what what was already in this file, so lets keep that for now.","commit_id":"183363a7536bccfdc3b653fae81fa008412e585b"}]}
