)]}'
{"nova/conf/virt.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407856bee22676500e0813630c2571e6f25846bb","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    cfg.StrOpt("},{"line_number":38,"context_line":"        \u0027compute_driver\u0027,"},{"line_number":39,"context_line":"        help\u003d\"\"\""},{"line_number":40,"context_line":"Defines which driver to use for controlling virtualization."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_21a08290","line":39,"updated":"2016-08-08 11:30:30.000000000","message":"Nit: we should probably do this using \"Choices\"?","commit_id":"1f528e3c54b4d92ea4516f4a8724acd7cca871b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4299d2b52d7cd75a627314e3277be12f8e52f8fd","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    cfg.StrOpt("},{"line_number":38,"context_line":"        \u0027compute_driver\u0027,"},{"line_number":39,"context_line":"        help\u003d\"\"\""},{"line_number":40,"context_line":"Defines which driver to use for controlling virtualization."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_6a10e559","line":39,"in_reply_to":"9ad45d7e_21a08290","updated":"2016-08-17 16:34:24.000000000","message":"I don\u0027t think we can, as it\u0027s possible to implement your own, out-of-tree compute driver, no?","commit_id":"1f528e3c54b4d92ea4516f4a8724acd7cca871b2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407856bee22676500e0813630c2571e6f25846bb","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    cfg.StrOpt("},{"line_number":53,"context_line":"        \u0027default_ephemeral_format\u0027,"},{"line_number":54,"context_line":"        help\u003d\"\"\""},{"line_number":55,"context_line":"The default format an ephemeral_volume will be formatted with on creation."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_105825fa","line":54,"updated":"2016-08-08 11:30:30.000000000","message":"Nit: we should add choices here too.","commit_id":"1f528e3c54b4d92ea4516f4a8724acd7cca871b2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407856bee22676500e0813630c2571e6f25846bb","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  arrive at all."},{"line_number":132,"context_line":"\"\"\"),"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    cfg.StrOpt("},{"line_number":135,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":136,"context_line":"        help\u003d\"\"\""},{"line_number":137,"context_line":"Firewall driver to use with ``nova-network`` service."}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_7017e1ed","line":134,"updated":"2016-08-08 11:30:30.000000000","message":"Nit: we should add a TODO to move this to a stevedore plugin system, and stop allowing any class to be loaded.","commit_id":"1f528e3c54b4d92ea4516f4a8724acd7cca871b2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407856bee22676500e0813630c2571e6f25846bb","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"This option only applies when using the ``nova-network`` service. When using"},{"line_number":140,"context_line":"another networking services, such as Neutron, this should be to set to the"},{"line_number":141,"context_line":"``nova.virt.firewall.NoopFirewallDriver``."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If unset (the default), this will default to the hypervisor-specified"},{"line_number":144,"context_line":"default driver."}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_b03039a0","line":141,"updated":"2016-08-08 11:30:30.000000000","message":"Nit: I am not sure this is accurate, I think this is used by some Neutron drivers.","commit_id":"1f528e3c54b4d92ea4516f4a8724acd7cca871b2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"407856bee22676500e0813630c2571e6f25846bb","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        min\u003d0,"},{"line_number":241,"context_line":"        help\u003d\u0027Amount of time, in seconds, to wait for NBD device start up.\u0027),"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    cfg.IntOpt("},{"line_number":244,"context_line":"        \u0027image_cache_manager_interval\u0027,"},{"line_number":245,"context_line":"        default\u003d2400,"},{"line_number":246,"context_line":"        min\u003d-1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_30a0c990","line":243,"updated":"2016-08-08 11:30:30.000000000","message":"Nit: it might be worth a TODO creating an image_cache opt group.","commit_id":"1f528e3c54b4d92ea4516f4a8724acd7cca871b2"}]}