)]}'
{"nova/api/openstack/compute/views/images.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"db3e2fcee5b6c1fbea38d58e20dd0379c0dde4b6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        glance_url \u003d self._update_glance_link_prefix(glance_url)"},{"line_number":199,"context_line":"        return os.path.join(glance_url,"},{"line_number":200,"context_line":"                            self._collection_name,"},{"line_number":201,"context_line":"                            str(identifier))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FhMQ%3D","line":201,"updated":"2013-06-28 16:58:34.000000000","message":"This will fail on windows, right? I think windows will use a backslash to join the path. Prolly better to do this:\n\n return \u0027/\u0027.join([a, b, c])","commit_id":"477058be6899c51229f5b37698fc1fd81b7d4b09"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"784d60180c7e76b2ef6b549dbb4e8c55a6b6c45f","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        glance_url \u003d self._update_glance_link_prefix(glance_url)"},{"line_number":199,"context_line":"        return os.path.join(glance_url,"},{"line_number":200,"context_line":"                            self._collection_name,"},{"line_number":201,"context_line":"                            str(identifier))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Ffxo%3D","line":201,"in_reply_to":"AAAAPn%2F%2FhMQ%3D","updated":"2013-06-29 08:08:54.000000000","message":"Now that you mention it, that does look very suspicious. A quick grep seems to show that os.path.join is used in quite a few places to create urls (including the base class for this change - there is another _get_alternate_link). So either something else is going on or openstack doesn\u0027t work so well on windows.","commit_id":"477058be6899c51229f5b37698fc1fd81b7d4b09"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"6dd34f4815c8123936d80006674c3ca1b6fd03ab","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\"Create an alternate link for a specific image id.\"\"\""},{"line_number":119,"context_line":"        glance_url \u003d glance.generate_glance_url()"},{"line_number":120,"context_line":"        glance_url \u003d self._update_glance_link_prefix(glance_url)"},{"line_number":121,"context_line":"        return \u0027/\u0027.join([glance_url,"},{"line_number":122,"context_line":"                         request.environ[\"nova.context\"].project_id,"},{"line_number":123,"context_line":"                         self._collection_name,"},{"line_number":124,"context_line":"                         str(identifier)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FwiU%3D","line":121,"updated":"2013-07-23 19:00:59.000000000","message":"technically should be in a separate commit, but not worth -1 this time i think ...","commit_id":"fd398fbb73ae317e15ff39da9316700a523ec154"}]}