)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"84e4f6600151b5f824cfc8b0ca29247aca967f5b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chris \u003ccm876n@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-28 12:10:19 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix opt indentation in hyperv.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed the hyperv opt indentation"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_61a07144","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"updated":"2016-07-28 18:33:39.000000000","message":"Update title to \"Fix config opt indentation and opt registration in hyper.py\"","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"84e4f6600151b5f824cfc8b0ca29247aca967f5b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix opt indentation in hyperv.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed the hyperv opt indentation"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Blueprint centralize-config-options-newton"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_5c21d29e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":32},"updated":"2016-07-28 18:33:39.000000000","message":"Update body to reflect that opt_registration had been done from a previous commit.","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"}],"nova/conf/hyperv.py":[{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"58f768249afd262c58b55d5726cf82dbea1e78c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_opt_group_and_type"},{"line_number":2,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Copyright (c) 2016 TUBITAK BILGEM"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_abdc0ae5","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":40},"updated":"2016-07-28 17:40:25.000000000","message":"The changes you made in this patch comes under this tag.","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"84e4f6600151b5f824cfc8b0ca29247aca967f5b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_opt_group_and_type"},{"line_number":2,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Copyright (c) 2016 TUBITAK BILGEM"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_46458315","line":2,"updated":"2016-07-28 18:33:39.000000000","message":"we can remove this line as well, as opt registration has already been previously done.","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"84e4f6600151b5f824cfc8b0ca29247aca967f5b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"hyperv_opts \u003d ["},{"line_number":23,"context_line":"    cfg.OptGroup(\u0027hyperv\u0027,"},{"line_number":24,"context_line":"        title\u003d\u0027The Hyper-V feature\u0027,"},{"line_number":25,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0bba76c0","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":11},"updated":"2016-07-28 18:33:39.000000000","message":"Change this name back to hyper_opt_group","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"58f768249afd262c58b55d5726cf82dbea1e78c2","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"hyperv_opts \u003d ["},{"line_number":23,"context_line":"    cfg.OptGroup(\u0027hyperv\u0027,"},{"line_number":24,"context_line":"        title\u003d\u0027The Hyper-V feature\u0027,"},{"line_number":25,"context_line":"        help\u003d\"\"\""},{"line_number":26,"context_line":"The hyperv feature allows you to configure the Hyper-V hypervisor"},{"line_number":27,"context_line":"driver to be used within an OpenStack deployment."},{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.FloatOpt(\u0027dynamic_memory_ratio\u0027,"},{"line_number":30,"context_line":"        default\u003d1.0,"},{"line_number":31,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_eb828293","line":28,"range":{"start_line":22,"start_character":0,"end_line":28,"end_character":5},"updated":"2016-07-28 17:40:25.000000000","message":"This is wrong, the group has to be there seperately. Just leave the group as it is and add hyperv_opt_group for all the options.","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"84e4f6600151b5f824cfc8b0ca29247aca967f5b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        help\u003d\"\"\""},{"line_number":26,"context_line":"The hyperv feature allows you to configure the Hyper-V hypervisor"},{"line_number":27,"context_line":"driver to be used within an OpenStack deployment."},{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.FloatOpt(\u0027dynamic_memory_ratio\u0027,"},{"line_number":30,"context_line":"        default\u003d1.0,"},{"line_number":31,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_abf9aa82","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":5},"updated":"2016-07-28 18:33:39.000000000","message":"take out the comma - i.e., from \u0027 \"\"\"),\u0027  to \u0027 \"\"\")\u0027\n\nthen add a new line before #29:\n\nhyperv_opts \u003d\n\nNOTE:  the hyperv_opts will eventually replace the ALL_OPTS from the original code.","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"58f768249afd262c58b55d5726cf82dbea1e78c2","unresolved":false,"context_lines":[{"line_number":312,"context_line":"* The retry loop runs with volume_attach_retry_count and"},{"line_number":313,"context_line":"  volume_attach_retry_interval configuration options."},{"line_number":314,"context_line":"\"\"\"),"},{"line_number":315,"context_line":"    cfg.IntOpt(\u0027volume_attach_retry_interval\u0027,"},{"line_number":316,"context_line":"        default\u003d5,"},{"line_number":317,"context_line":"        help\u003d\"\"\""},{"line_number":318,"context_line":"Volume attach retry interval"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0b3556f6","line":315,"range":{"start_line":315,"start_character":16,"end_line":315,"end_character":45},"updated":"2016-07-28 17:40:25.000000000","message":"this is redundant.","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"58f768249afd262c58b55d5726cf82dbea1e78c2","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"def register_opts(conf):"},{"line_number":371,"context_line":"    conf.register_opts(hyperv_opts, group\u003dhyperv_opt_group)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_863dbbbd","line":371,"range":{"start_line":371,"start_character":36,"end_line":371,"end_character":58},"updated":"2016-07-28 17:40:25.000000000","message":"Register the group first.","commit_id":"7f105aa5466c5775161af52e600817b068bc6776"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2945f90da6252842c9d8e79c8ceedb5a91a73951","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"\"\"\"),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027mounted_disk_query_retry_count\u0027,"},{"line_number":97,"context_line":"        default\u003d10,"},{"line_number":98,"context_line":"        help\u003d\"\"\""},{"line_number":99,"context_line":"Mounted disk query retry count"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_1e2fc0a1","line":97,"updated":"2016-08-01 20:55:05.000000000","message":"I think it\u0027s worth to add \"min\" parameter to all Integer options in this patch. http://docs.openstack.org/developer/oslo.config/opts.html","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"c913a2f8ae7b916640ad50da86560dc52b9e8564","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"\"\"\"),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027mounted_disk_query_retry_count\u0027,"},{"line_number":97,"context_line":"        default\u003d10,"},{"line_number":98,"context_line":"        help\u003d\"\"\""},{"line_number":99,"context_line":"Mounted disk query retry count"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_5f0e53e5","line":97,"in_reply_to":"bacf61ea_1e2fc0a1","updated":"2016-08-01 21:29:30.000000000","message":"Actually this commit is for \"options indentation\"  and \"options registry consistency\" -  I believe the \u0027min\u0027 parameters are part of the \"check opt group and type\", right? Since this was his first commit, the \"check opt group and type\" will be done on a separate commit instead.","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"24394701162429617a5326e4cb1da976c3265b9d","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"\"\"\"),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027mounted_disk_query_retry_count\u0027,"},{"line_number":97,"context_line":"        default\u003d10,"},{"line_number":98,"context_line":"        help\u003d\"\"\""},{"line_number":99,"context_line":"Mounted disk query retry count"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_94a9a127","line":97,"in_reply_to":"bacf61ea_5f0e53e5","updated":"2016-08-02 15:45:35.000000000","message":"Yes, I agree that min doesn\u0027t come under this patch, I think more precisely min comes under fix_opt_description which is already removed.","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2945f90da6252842c9d8e79c8ceedb5a91a73951","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* Time interval between disk mount retries is declared with"},{"line_number":115,"context_line":"  \"mounted_disk_query_retry_interval\" option."},{"line_number":116,"context_line":"\"\"\"),"},{"line_number":117,"context_line":"    cfg.IntOpt(\u0027mounted_disk_query_retry_interval\u0027,"},{"line_number":118,"context_line":"        default\u003d5,"},{"line_number":119,"context_line":"        help\u003d\"\"\""},{"line_number":120,"context_line":"Mounted disk query retry interval"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_3e1e0470","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":14},"updated":"2016-08-01 20:55:05.000000000","message":"ditto","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2945f90da6252842c9d8e79c8ceedb5a91a73951","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  mounted_disk_query_retry_interval configuration options."},{"line_number":134,"context_line":"\"\"\"),"},{"line_number":135,"context_line":"    cfg.IntOpt(\u0027power_state_check_timeframe\u0027,"},{"line_number":136,"context_line":"        default\u003d60,"},{"line_number":137,"context_line":"        help\u003d\"\"\""},{"line_number":138,"context_line":"Power state check timeframe"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_9e11f05f","line":136,"updated":"2016-08-01 20:55:05.000000000","message":"ditto","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2945f90da6252842c9d8e79c8ceedb5a91a73951","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"\"\"\"),"},{"line_number":149,"context_line":"    cfg.IntOpt(\u0027power_state_event_polling_interval\u0027,"},{"line_number":150,"context_line":"        default\u003d2,"},{"line_number":151,"context_line":"        help\u003d\"\"\""},{"line_number":152,"context_line":"Power state event polling interval"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_7e14fc4b","line":150,"updated":"2016-08-01 20:55:05.000000000","message":"ditto","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2945f90da6252842c9d8e79c8ceedb5a91a73951","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"\"\"\"),"},{"line_number":214,"context_line":"    cfg.IntOpt(\u0027wait_soft_reboot_seconds\u0027,"},{"line_number":215,"context_line":"        default\u003d60,"},{"line_number":216,"context_line":"        help\u003d\"\"\""},{"line_number":217,"context_line":"Wait soft reboot seconds"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_fc047515","line":215,"updated":"2016-08-01 20:55:05.000000000","message":"ditto","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2945f90da6252842c9d8e79c8ceedb5a91a73951","unresolved":false,"context_lines":[{"line_number":273,"context_line":"* Currently, the only accepted config_drive_format is \u0027iso9660\u0027."},{"line_number":274,"context_line":"\"\"\"),"},{"line_number":275,"context_line":"    cfg.IntOpt(\u0027volume_attach_retry_count\u0027,"},{"line_number":276,"context_line":"        default\u003d10,"},{"line_number":277,"context_line":"        help\u003d\"\"\""},{"line_number":278,"context_line":"Volume attach retry count"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_5c082128","line":276,"updated":"2016-08-01 20:55:05.000000000","message":"ditto","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2945f90da6252842c9d8e79c8ceedb5a91a73951","unresolved":false,"context_lines":[{"line_number":294,"context_line":"  volume_attach_retry_interval option."},{"line_number":295,"context_line":"\"\"\"),"},{"line_number":296,"context_line":"    cfg.IntOpt(\u0027volume_attach_retry_interval\u0027,"},{"line_number":297,"context_line":"        default\u003d5,"},{"line_number":298,"context_line":"        help\u003d\"\"\""},{"line_number":299,"context_line":"Volume attach retry interval"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_9c16194a","line":297,"updated":"2016-08-01 20:55:05.000000000","message":"ditto","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"216865b53f3612fc865438d5eb23903ccccacea2","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"def list_opts():"},{"line_number":357,"context_line":"    return {\u0027hyperv_opt_group\u0027: hyperv_opts}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_bc715d0e","line":357,"range":{"start_line":357,"start_character":12,"end_line":357,"end_character":30},"updated":"2016-08-01 21:10:57.000000000","message":"This is not a string, change this to match with register_opts.","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"24394701162429617a5326e4cb1da976c3265b9d","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"def list_opts():"},{"line_number":357,"context_line":"    return {\u0027hyperv_opt_group\u0027: hyperv_opts}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_3af25f07","line":357,"range":{"start_line":357,"start_character":12,"end_line":357,"end_character":30},"in_reply_to":"bacf61ea_bc715d0e","updated":"2016-08-02 15:45:35.000000000","message":"This comes under fix_opt_registration_consistency only, so this should be changed in this patch.","commit_id":"bc6b71d46f86a2ae11cdd4e0a3869919d256fd68"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5e3cbcfee88c3aa2be995d185af4223322876e9","unresolved":false,"context_lines":[{"line_number":241,"context_line":"Possible values:"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"* True: Attach the configuration drive image as a CD drive."},{"line_number":244,"context_line":"* False: Attach the configuration drive image as a disk drive (Default)."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Related options:"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_d51d30bf","line":244,"updated":"2016-08-05 10:44:59.000000000","message":"This is useful.","commit_id":"d9020ceccfae39b5a1121429a56d0b27bc94627b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5e3cbcfee88c3aa2be995d185af4223322876e9","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Enables setting the admin password in the configuration drive image."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Possible values:"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"* True: Enables the feature."},{"line_number":270,"context_line":"* False: Disables the feature (Default)."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"Related options:"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_35376c4e","line":270,"range":{"start_line":267,"start_character":0,"end_line":270,"end_character":40},"updated":"2016-08-05 10:44:59.000000000","message":"This should be dropped.","commit_id":"d9020ceccfae39b5a1121429a56d0b27bc94627b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d5e3cbcfee88c3aa2be995d185af4223322876e9","unresolved":false,"context_lines":[{"line_number":325,"context_line":"Windows / Hyper-V Server 2012 R2 or newer and RDS-Virtualization"},{"line_number":326,"context_line":"feature has to be enabled."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Possible values:"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"* False: Disables the feature (Default)."},{"line_number":331,"context_line":"* True: Enables the feature."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"Instances with RemoteFX can be requested with the following flavor"},{"line_number":334,"context_line":"extra specs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_75f60490","line":331,"range":{"start_line":328,"start_character":0,"end_line":331,"end_character":28},"updated":"2016-08-05 10:44:59.000000000","message":"This should be dropped","commit_id":"d9020ceccfae39b5a1121429a56d0b27bc94627b"}]}