)]}'
{"nova/conf/ephemeral_storage.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3818077af69982b21c87bb15513c41dc85bed2f2","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The bit length of the encryption key to be used to"},{"line_number":51,"context_line":"encrypt ephemeral storage (in XTS mode only half of"},{"line_number":52,"context_line":"the bits are used for encryption key)."},{"line_number":53,"context_line":"\"\"\"),"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_5af04ffd","line":52,"updated":"2016-08-05 10:17:27.000000000","message":"Nit: not sure all these options wrap at the correct line length, but its OK.","commit_id":"7c4dbfc3a6aaa555bf88c1cfe6bc4d9761586fc1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3818077af69982b21c87bb15513c41dc85bed2f2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def list_opts():"},{"line_number":65,"context_line":"    return {ephemeral_storage_encryption_group:"},{"line_number":66,"context_line":"                           ephemeral_storage_encryption_opts}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_7aad53e8","line":66,"updated":"2016-08-05 10:17:27.000000000","message":"Nit: not a massive fan of this indentation, but I don\u0027t want to block on that.","commit_id":"7c4dbfc3a6aaa555bf88c1cfe6bc4d9761586fc1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fdb3e76f73378b54a63284b28d29fa333f283c5d","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ephemeral_storage_encryption_opts \u003d ["},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":25,"context_line":"                default\u003dFalse,"},{"line_number":26,"context_line":"                help\u003d\"\"\""},{"line_number":27,"context_line":"Enables/disables LVM ephemeral storage encryption."},{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027cipher\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_c8c8cc77","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":24},"updated":"2016-09-22 14:00:25.000000000","message":"Can you reindent this with 8 spaces? Same for other options in the file","commit_id":"233bd44867d544fc20613ef5c7bbec26fbe18301"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40fac5b3a8a9af9bf9c2358a373d79bfa6e0b454","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ephemeral_storage_encryption_opts \u003d ["},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":25,"context_line":"                default\u003dFalse,"},{"line_number":26,"context_line":"                help\u003d\"\"\""},{"line_number":27,"context_line":"Enables/disables LVM ephemeral storage encryption."},{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027cipher\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_b55b62f5","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":24},"in_reply_to":"5a8bc5a2_3b0685ce","updated":"2016-09-26 08:11:44.000000000","message":"\u003e Question:Do we have any specific guidelines to have 8 spaces here. I saw all the config options and there is no consistency among them.\n\nYeah, this is a nice to have but it probably ties in best to PEP8:\n\n    https://www.python.org/dev/peps/pep-0008/#indentation\n\nIn this case, it leaves us more room for longer arguments and ensures indentation is consistent (which doesn\u0027t happen the way this is at present because of different Opt lengths (BoolOpt (7) vs. StrOpt (6)).\n\nThere is also an indentation guidelines in the consistency wiki, but I think that\u0027s more to do with the indentation of the help text itself?\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_description_indentation","commit_id":"233bd44867d544fc20613ef5c7bbec26fbe18301"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"fe7fbde4904cde05e92fdb5207f9210b26e70050","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ephemeral_storage_encryption_opts \u003d ["},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":25,"context_line":"                default\u003dFalse,"},{"line_number":26,"context_line":"                help\u003d\"\"\""},{"line_number":27,"context_line":"Enables/disables LVM ephemeral storage encryption."},{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027cipher\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_3b0685ce","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":24},"in_reply_to":"5a8bc5a2_c8c8cc77","updated":"2016-09-23 21:45:10.000000000","message":"done.\nQuestion:Do we have any specific guidelines to have 8 spaces here. I saw all the config options and there is no consistency among them.","commit_id":"233bd44867d544fc20613ef5c7bbec26fbe18301"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fdb3e76f73378b54a63284b28d29fa333f283c5d","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Possible values:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* aes-xts-plain64, see /proc/crypto for available options."},{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"},{"line_number":42,"context_line":"               default\u003d512,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_88e7a411","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":58},"updated":"2016-09-22 14:00:25.000000000","message":"Maybe\n\n* Any crypto option listed in ``/proc/crypto``","commit_id":"233bd44867d544fc20613ef5c7bbec26fbe18301"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"fe7fbde4904cde05e92fdb5207f9210b26e70050","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Possible values:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* aes-xts-plain64, see /proc/crypto for available options."},{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"},{"line_number":42,"context_line":"               default\u003d512,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_5b0991dc","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":58},"in_reply_to":"5a8bc5a2_88e7a411","updated":"2016-09-23 21:45:10.000000000","message":"Done","commit_id":"233bd44867d544fc20613ef5c7bbec26fbe18301"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0cdecf379d7f0ea595788b5d8051aec59880644e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ephemeral_storage_encryption_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    name\u003d\u0027ephemeral_storage_encryption\u0027,"},{"line_number":21,"context_line":"    title\u003d\u0027Ephemeral storage encryption options\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ephemeral_storage_encryption_opts \u003d ["},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_e4f0c3ff","line":21,"updated":"2016-09-26 14:21:11.000000000","message":"Sometimes it worth noting the required options here, but that seems like overkill here.","commit_id":"87426ef4bef154dfe58d13fbe58a788a62f981d0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0cdecf379d7f0ea595788b5d8051aec59880644e","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The bit length of the encryption key to be used to encrypt ephemeral storage."},{"line_number":48,"context_line":"In XTS mode only half of the bits are used for encryption key."},{"line_number":49,"context_line":"\"\"\"),"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_a4007b02","line":49,"updated":"2016-09-26 14:21:11.000000000","message":"Technically key_size and cipher are related to enabled, as they are ignored when things are not enabled, but that seems clear really.","commit_id":"87426ef4bef154dfe58d13fbe58a788a62f981d0"}]}