)]}'
{"nova/conf/novnc.py":[{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"aa40dbd1f8f79dbb2dd8d526135aaf5fc36d7219","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\"\"\"),"},{"line_number":31,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":32,"context_line":"        default\u003dFalse,"},{"line_number":33,"context_line":"        help\u003d\"Run as a background process.\"),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":35,"context_line":"        default\u003dFalse,"},{"line_number":36,"context_line":"        help\u003d\"Disallow non-encrypted connections.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2e058813","line":33,"range":{"start_line":33,"start_character":13,"end_line":33,"end_character":44},"updated":"2016-07-29 20:42:56.000000000","message":"check https://github.com/openstack/nova/blob/master/nova/conf/serial_console.py for sample on how to reformat the \"help\u003d\" line(s) correctly.\n\nchange the help line (line #33)  to mimic the format as seen in lines 47-49.","commit_id":"5e0edc847a302251caa50f046eee519d93d7d878"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"aa40dbd1f8f79dbb2dd8d526135aaf5fc36d7219","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        help\u003d\"Run as a background process.\"),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":35,"context_line":"        default\u003dFalse,"},{"line_number":36,"context_line":"        help\u003d\"Disallow non-encrypted connections.\"),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"},{"line_number":38,"context_line":"        default\u003dFalse,"},{"line_number":39,"context_line":"        help\u003d\"Set to True if source host is addressed with IPv6.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_09307ee7","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":52},"updated":"2016-07-29 20:42:56.000000000","message":"ditto","commit_id":"5e0edc847a302251caa50f046eee519d93d7d878"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"aa40dbd1f8f79dbb2dd8d526135aaf5fc36d7219","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        help\u003d\"Disallow non-encrypted connections.\"),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"},{"line_number":38,"context_line":"        default\u003dFalse,"},{"line_number":39,"context_line":"        help\u003d\"Set to True if source host is addressed with IPv6.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027cert\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027self.pem\u0027,"},{"line_number":42,"context_line":"        help\u003d\"Path to SSL certificate file.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a95692cb","line":39,"range":{"start_line":39,"start_character":13,"end_line":39,"end_character":67},"updated":"2016-07-29 20:42:56.000000000","message":"ditto","commit_id":"5e0edc847a302251caa50f046eee519d93d7d878"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"aa40dbd1f8f79dbb2dd8d526135aaf5fc36d7219","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        help\u003d\"Set to True if source host is addressed with IPv6.\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027cert\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027self.pem\u0027,"},{"line_number":42,"context_line":"        help\u003d\"Path to SSL certificate file.\"),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027key\u0027,"},{"line_number":44,"context_line":"        help\u003d\"SSL key file (if separate from cert).\"),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027web\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_895bcef5","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":46},"updated":"2016-07-29 20:42:56.000000000","message":"ditto","commit_id":"5e0edc847a302251caa50f046eee519d93d7d878"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"aa40dbd1f8f79dbb2dd8d526135aaf5fc36d7219","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        default\u003d\u0027self.pem\u0027,"},{"line_number":42,"context_line":"        help\u003d\"Path to SSL certificate file.\"),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027key\u0027,"},{"line_number":44,"context_line":"        help\u003d\"SSL key file (if separate from cert).\"),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":46,"context_line":"        default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":47,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e9740a69","line":44,"range":{"start_line":44,"start_character":14,"end_line":44,"end_character":54},"updated":"2016-07-29 20:42:56.000000000","message":"ditto","commit_id":"5e0edc847a302251caa50f046eee519d93d7d878"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"aa40dbd1f8f79dbb2dd8d526135aaf5fc36d7219","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        help\u003d\"SSL key file (if separate from cert).\"),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":46,"context_line":"        default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":47,"context_line":"        help\u003d\"\"\""},{"line_number":48,"context_line":"Path to directory with content which will be served by a web server."},{"line_number":49,"context_line":"\"\"\"),"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a98052f8","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":5},"updated":"2016-07-29 20:42:56.000000000","message":"this is the correct format.","commit_id":"5e0edc847a302251caa50f046eee519d93d7d878"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"45040a6c56829cf3c7841ddb40dc5cd0487beeea","unresolved":false,"context_lines":[{"line_number":30,"context_line":"If this is not set, no recording will be done."},{"line_number":31,"context_line":"\"\"\"),"},{"line_number":32,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":33,"context_line":"                default\u003dFalse,"},{"line_number":34,"context_line":"                help\u003d\"Run as a background process.\"),"},{"line_number":35,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":36,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_68072682","side":"PARENT","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":16},"updated":"2016-08-01 19:56:23.000000000","message":"This indentation was PEP8 valid.","commit_id":"d13e82b0786c89c7539db313f38f7010fc78b7fb"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"c964570a08367a32062ee2d266e9fc2136696064","unresolved":false,"context_lines":[{"line_number":30,"context_line":"If this is not set, no recording will be done."},{"line_number":31,"context_line":"\"\"\"),"},{"line_number":32,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":33,"context_line":"                default\u003dFalse,"},{"line_number":34,"context_line":"                help\u003d\"Run as a background process.\"),"},{"line_number":35,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":36,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9c6bb9b6","side":"PARENT","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":16},"in_reply_to":"bacf61ea_68072682","updated":"2016-08-01 21:21:59.000000000","message":"Hi Maciej - I agree it is pep8 valid, but I was following the indentation sample provided in https://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_description_indentation.   But now looking back, it seems like its open to interpretation.","commit_id":"d13e82b0786c89c7539db313f38f7010fc78b7fb"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"45040a6c56829cf3c7841ddb40dc5cd0487beeea","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":32,"context_line":"        default\u003dFalse,"},{"line_number":33,"context_line":"        help\u003d\"\"\""},{"line_number":34,"context_line":"Run as a background process."},{"line_number":35,"context_line":"\"\"\"),"},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":37,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_2876ce3d","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":28},"updated":"2016-08-01 19:56:23.000000000","message":"Indentation and \"\"\" not needed. This description fits in one line.","commit_id":"d2bd66f16b662b5074e827a3f1c6760230156868"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"c964570a08367a32062ee2d266e9fc2136696064","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":32,"context_line":"        default\u003dFalse,"},{"line_number":33,"context_line":"        help\u003d\"\"\""},{"line_number":34,"context_line":"Run as a background process."},{"line_number":35,"context_line":"\"\"\"),"},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":37,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9c573957","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":28},"in_reply_to":"bacf61ea_2876ce3d","updated":"2016-08-01 21:21:59.000000000","message":"I have no problem changing them back.  Though I\u0027d like to share that this \"help text indentation\" format was followed based on the merged changes related to config indentation so far.  It may help if the https://wiki.openstack.org/wiki/ConfigOptionsConsistency document is updated with some actual samples so we all agree on the different formatting, cause otherwise its open to different interpretations.","commit_id":"d2bd66f16b662b5074e827a3f1c6760230156868"}]}