)]}'
{"nova/tests/virt/xenapi/test_vm_utils.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f57f3ef383a1851c777af014430bcd6faf7c4522","unresolved":false,"context_lines":[{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"class ShutdownTestCase(test.TestCase):"},{"line_number":643,"context_line":"    def test_hardshutdown_should_return_true_when_vm_is_shutdown(self):"},{"line_number":644,"context_line":"        def fake_is_vm_shutdown(*args):"},{"line_number":645,"context_line":"            return True"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fh9s%3D","line":643,"updated":"2013-06-28 13:14:28.000000000","message":"These tests would be cleaner if you used the self.mox.StubOutWithMock() style rather than these stubs.  Then you wouldn\u0027t need to define the fake methods.","commit_id":"f43745a679a17a3ea06be053f0a196d25cf8ce2f"},{"author":{"_account_id":7531,"name":"Sridevi Koushik","email":"sridevi.koushik@rackspace.com","username":"sridevik"},"change_message_id":"9a85c17c6a8b43ec76f743fe3339e27e6cd58fb5","unresolved":false,"context_lines":[{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"class ShutdownTestCase(test.TestCase):"},{"line_number":643,"context_line":"    def test_hardshutdown_should_return_true_when_vm_is_shutdown(self):"},{"line_number":644,"context_line":"        def fake_is_vm_shutdown(*args):"},{"line_number":645,"context_line":"            return True"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fh6k%3D","line":643,"in_reply_to":"AAAAPn%2F%2Fh9s%3D","updated":"2013-06-28 13:26:37.000000000","message":"Done","commit_id":"f43745a679a17a3ea06be053f0a196d25cf8ce2f"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f57f3ef383a1851c777af014430bcd6faf7c4522","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        self.stubs.Set(vm_utils, \u0027is_vm_shutdown\u0027, fake_is_vm_shutdown)"},{"line_number":651,"context_line":"        self.stubs.Set(vm_utils.LOG, \"warn\", fake_warn)"},{"line_number":652,"context_line":"        instance \u003d vm_ref \u003d \"vm-ref\""},{"line_number":653,"context_line":"        self.session \u003d FakeSession()"},{"line_number":654,"context_line":"        self.assertTrue(vm_utils.hard_shutdown_vm("},{"line_number":655,"context_line":"            self.session, instance, vm_ref))"},{"line_number":656,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fh9g%3D","line":653,"updated":"2013-06-28 13:14:28.000000000","message":"This doesn\u0027t need to be set on the class object, i.e. you could use session rather than self.session.","commit_id":"f43745a679a17a3ea06be053f0a196d25cf8ce2f"},{"author":{"_account_id":7531,"name":"Sridevi Koushik","email":"sridevi.koushik@rackspace.com","username":"sridevik"},"change_message_id":"9a85c17c6a8b43ec76f743fe3339e27e6cd58fb5","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        self.stubs.Set(vm_utils, \u0027is_vm_shutdown\u0027, fake_is_vm_shutdown)"},{"line_number":651,"context_line":"        self.stubs.Set(vm_utils.LOG, \"warn\", fake_warn)"},{"line_number":652,"context_line":"        instance \u003d vm_ref \u003d \"vm-ref\""},{"line_number":653,"context_line":"        self.session \u003d FakeSession()"},{"line_number":654,"context_line":"        self.assertTrue(vm_utils.hard_shutdown_vm("},{"line_number":655,"context_line":"            self.session, instance, vm_ref))"},{"line_number":656,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fh6o%3D","line":653,"in_reply_to":"AAAAPn%2F%2Fh9g%3D","updated":"2013-06-28 13:26:37.000000000","message":"Done","commit_id":"f43745a679a17a3ea06be053f0a196d25cf8ce2f"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"9a9fde2361be81dc0eb3ce0068659110a97e28df","unresolved":false,"context_lines":[{"line_number":644,"context_line":"    def test_hardshutdown_should_return_true_when_vm_is_shutdown(self):"},{"line_number":645,"context_line":"        self.mock \u003d mox.Mox()"},{"line_number":646,"context_line":"        session \u003d FakeSession()"},{"line_number":647,"context_line":"        instance \u003d vm_ref \u003d \"vm-ref\""},{"line_number":648,"context_line":"        self.mock.StubOutWithMock(vm_utils, \u0027is_vm_shutdown\u0027)"},{"line_number":649,"context_line":"        vm_utils.is_vm_shutdown(session, vm_ref).AndReturn(True)"},{"line_number":650,"context_line":"        self.mock.StubOutWithMock(vm_utils, \u0027LOG\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FdfM%3D","line":647,"updated":"2013-07-01 14:04:37.000000000","message":"I\u0027m not a big fan of this.  Not that multiple assignment is necessarily bad, but instance and vm_ref are different and should have different data.","commit_id":"4b926e433a5de9ccafa968a1824da7c0398804cf"},{"author":{"_account_id":7531,"name":"Sridevi Koushik","email":"sridevi.koushik@rackspace.com","username":"sridevik"},"change_message_id":"ca59fe58f6d35398e577b5790a22cf7cb388578d","unresolved":false,"context_lines":[{"line_number":644,"context_line":"    def test_hardshutdown_should_return_true_when_vm_is_shutdown(self):"},{"line_number":645,"context_line":"        self.mock \u003d mox.Mox()"},{"line_number":646,"context_line":"        session \u003d FakeSession()"},{"line_number":647,"context_line":"        instance \u003d vm_ref \u003d \"vm-ref\""},{"line_number":648,"context_line":"        self.mock.StubOutWithMock(vm_utils, \u0027is_vm_shutdown\u0027)"},{"line_number":649,"context_line":"        vm_utils.is_vm_shutdown(session, vm_ref).AndReturn(True)"},{"line_number":650,"context_line":"        self.mock.StubOutWithMock(vm_utils, \u0027LOG\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fb8A%3D","line":647,"in_reply_to":"AAAAPn%2F%2FdfM%3D","updated":"2013-07-01 23:28:39.000000000","message":"Done","commit_id":"4b926e433a5de9ccafa968a1824da7c0398804cf"}]}