)]}'
{"nova/conf/notifications.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"06290bb6c9934052fc15c9ea2104b82a9b87ec4e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.BoolOpt("},{"line_number":39,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":40,"context_line":"        default\u003dFalse,"},{"line_number":41,"context_line":"        help\u003d\"If set, send api.fault notifications on caught exceptions in \""},{"line_number":42,"context_line":"             \"the API service.\"),"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_450b2424","line":41,"updated":"2016-08-01 22:14:37.000000000","message":"I think this format is not consistent. If multiple lines wrap it in triple quotes","commit_id":"d82bc73bd62aad1781adb81e9bd376b55b8a7d15"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b083c8e1e54f3c81e530189cd637ee946b38e272","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.BoolOpt("},{"line_number":39,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":40,"context_line":"        default\u003dFalse,"},{"line_number":41,"context_line":"        help\u003d\"If set, send api.fault notifications on caught exceptions in \""},{"line_number":42,"context_line":"             \"the API service.\"),"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_cc21a6b6","line":41,"in_reply_to":"bacf61ea_290e9be5","updated":"2016-08-03 11:35:57.000000000","message":"Dropping the tag above is claiming this work has been done.\n\nI am +1 raj\u0027s comment here, it should be indented to match the others. Honestly, we should probably do it for the one liners too.","commit_id":"d82bc73bd62aad1781adb81e9bd376b55b8a7d15"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"ab4d1741012a7dc59b5a50b3d8487e3add647b99","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.BoolOpt("},{"line_number":39,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":40,"context_line":"        default\u003dFalse,"},{"line_number":41,"context_line":"        help\u003d\"If set, send api.fault notifications on caught exceptions in \""},{"line_number":42,"context_line":"             \"the API service.\"),"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_290e9be5","line":41,"in_reply_to":"bacf61ea_450b2424","updated":"2016-08-02 17:05:09.000000000","message":"It is not absolute. This any correct solution.\n\nFurthermore: In this patch, no this change the committer. \nThe your objection can fix any other patchset.","commit_id":"d82bc73bd62aad1781adb81e9bd376b55b8a7d15"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"b2ec6d5a8606f48802b7e991ccdc11fd069b6aa9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.BoolOpt("},{"line_number":39,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":40,"context_line":"        default\u003dFalse,"},{"line_number":41,"context_line":"        help\u003d\"If set, send api.fault notifications on caught exceptions in \""},{"line_number":42,"context_line":"             \"the API service.\"),"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_65499ab7","line":41,"in_reply_to":"bacf61ea_cc21a6b6","updated":"2016-08-03 16:53:19.000000000","message":"We have mixed opinions for the one liners, I used to wrap one liners in triple quotes, and i have seen review comments to wrap one liners to single or double quotes. Which one to follow?","commit_id":"d82bc73bd62aad1781adb81e9bd376b55b8a7d15"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b883653e1a339509f57875a90e44f62a0376d3bc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        default\u003dFalse,"},{"line_number":41,"context_line":"        help\u003d\"\"\""},{"line_number":42,"context_line":"If set, send api.fault notifications on caught exceptions"},{"line_number":43,"context_line":"in the API service."},{"line_number":44,"context_line":"\"\"\"),"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e1e233d4","line":43,"updated":"2016-08-05 13:00:02.000000000","message":"Nit: It warps the line a little early, but not going to block on that.","commit_id":"6e0af0c57dfba04694f6e0d8605e5a4a56f1b331"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b883653e1a339509f57875a90e44f62a0376d3bc","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Possible values:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* String with valid IP address. Default is IPv4 address of this host."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Related options:"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c1460fbf","line":62,"range":{"start_line":62,"start_character":2,"end_line":62,"end_character":30},"updated":"2016-08-05 13:00:02.000000000","message":"I don\u0027t think it actually has to be an IP address.","commit_id":"6e0af0c57dfba04694f6e0d8605e5a4a56f1b331"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b883653e1a339509f57875a90e44f62a0376d3bc","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def list_opts():"},{"line_number":76,"context_line":"    return {\u0027DEFAULT\u0027: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e1099396","line":76,"updated":"2016-08-05 13:00:02.000000000","message":"Nit: possible add a TODO about moving this to a notification group.","commit_id":"6e0af0c57dfba04694f6e0d8605e5a4a56f1b331"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06edc13224f1134ce46acc56523bd2d6bbe1a403","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":40,"context_line":"        default\u003dFalse,"},{"line_number":41,"context_line":"        help\u003d\"\"\""},{"line_number":42,"context_line":"If set, send api.fault notifications on caught exceptions in the"},{"line_number":43,"context_line":"API service."},{"line_number":44,"context_line":"\"\"\"),"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_6db2bf07","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":8},"updated":"2016-08-17 16:39:13.000000000","message":"s/If set, /Enable/","commit_id":"e1ce92db41c7fa0fb42ed268aa9d3e795a333f7e"}]}
