)]}'
{"nova/conf/serial_console.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a0e71490fcadfeefbd21ee203f093f804bb34cf1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Possible values:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Each string which passes the regex ``\\d+:\\d+`` For example ``10000:20000``."},{"line_number":50,"context_line":"  Be sure that the first port number is lower than the second port number."},{"line_number":51,"context_line":"\"\"\"),"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027base_url\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_3ac2a953","line":50,"updated":"2016-08-05 15:31:26.000000000","message":"Nit: probably also should ensure they are valid port numbers, i.e. between 0 and 65535, but only worth adding if we need a respin.","commit_id":"09d3acdfbc5ab246c218be8485cd4a2d8fc85a2b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2bb18098eb19920123db61ff3c463acef5e54e03","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Possible values:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Each string which passes the regex ``\\d+:\\d+`` For example ``10000:20000``."},{"line_number":50,"context_line":"  Be sure that the first port number is lower than the second port number."},{"line_number":51,"context_line":"\"\"\"),"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027base_url\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4ca4044a","line":50,"in_reply_to":"bacf61ea_3ac2a953","updated":"2016-08-05 18:37:08.000000000","message":"Done","commit_id":"09d3acdfbc5ab246c218be8485cd4a2d8fc85a2b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a0e71490fcadfeefbd21ee203f093f804bb34cf1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  Be sure that the first port number is lower than the second port number."},{"line_number":51,"context_line":"\"\"\"),"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027base_url\u0027,"},{"line_number":54,"context_line":"        default\u003d\u0027ws://127.0.0.1:6083/\u0027,"},{"line_number":55,"context_line":"        help\u003d\"\"\""},{"line_number":56,"context_line":"The URL an end user would use to connect to the ``nova-serialproxy`` service."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_3abe29ae","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":14},"updated":"2016-08-05 15:31:26.000000000","message":"Turns out we now have URIOpt\nhttp://docs.openstack.org/developer/oslo.config/opts.html#oslo_config.cfg.URIOpt","commit_id":"09d3acdfbc5ab246c218be8485cd4a2d8fc85a2b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2bb18098eb19920123db61ff3c463acef5e54e03","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  Be sure that the first port number is lower than the second port number."},{"line_number":51,"context_line":"\"\"\"),"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027base_url\u0027,"},{"line_number":54,"context_line":"        default\u003d\u0027ws://127.0.0.1:6083/\u0027,"},{"line_number":55,"context_line":"        help\u003d\"\"\""},{"line_number":56,"context_line":"The URL an end user would use to connect to the ``nova-serialproxy`` service."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_8c68bcf6","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":14},"in_reply_to":"bacf61ea_3abe29ae","updated":"2016-08-05 18:37:08.000000000","message":"Done","commit_id":"09d3acdfbc5ab246c218be8485cd4a2d8fc85a2b"},{"author":{"_account_id":20581,"name":"Jin Li","email":"jl7351@att.com","username":"JinLi"},"change_message_id":"fda152141afab1b062dc02d4ab4a137fa71e7a86","unresolved":false,"context_lines":[{"line_number":58,"context_line":"The ``nova-serialproxy`` service is called with this token enriched URL"},{"line_number":59,"context_line":"and establishes the connection to the proper instance."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Possible values:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* \u003cscheme\u003e\u003cIP-address\u003e\u003cport-number\u003e"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_cde6dd15","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":8},"updated":"2016-08-02 23:03:17.000000000","message":"is this \"possible values\" still needed? you have remove the ones below.","commit_id":"09d3acdfbc5ab246c218be8485cd4a2d8fc85a2b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2bb18098eb19920123db61ff3c463acef5e54e03","unresolved":false,"context_lines":[{"line_number":58,"context_line":"The ``nova-serialproxy`` service is called with this token enriched URL"},{"line_number":59,"context_line":"and establishes the connection to the proper instance."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Possible values:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* \u003cscheme\u003e\u003cIP-address\u003e\u003cport-number\u003e"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2c7a70bd","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":8},"in_reply_to":"bacf61ea_3a99097a","updated":"2016-08-05 18:37:08.000000000","message":"Done","commit_id":"09d3acdfbc5ab246c218be8485cd4a2d8fc85a2b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a0e71490fcadfeefbd21ee203f093f804bb34cf1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"The ``nova-serialproxy`` service is called with this token enriched URL"},{"line_number":59,"context_line":"and establishes the connection to the proper instance."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Possible values:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* \u003cscheme\u003e\u003cIP-address\u003e\u003cport-number\u003e"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_3a99097a","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":8},"in_reply_to":"bacf61ea_cde6dd15","updated":"2016-08-05 15:31:26.000000000","message":"Its sort of useful here, it tells you the format you need of the string, but I think it should be deleted, and we should use URIOpt.","commit_id":"09d3acdfbc5ab246c218be8485cd4a2d8fc85a2b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a0e71490fcadfeefbd21ee203f093f804bb34cf1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  and ``key`` in the ``[DEFAULT]`` section have to be set for that."},{"line_number":75,"context_line":"\"\"\"),"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":78,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":79,"context_line":"        help\u003d\"\"\""},{"line_number":80,"context_line":"The IP address to which proxy clients (like ``nova-serialproxy``) should"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5af15d94","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":14},"updated":"2016-08-05 15:31:26.000000000","message":"IPOpt would be better here","commit_id":"09d3acdfbc5ab246c218be8485cd4a2d8fc85a2b"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5f2e704e1d92f0bd4c7ac9d9663c98902754e882","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  and ``key`` in the ``[DEFAULT]`` section have to be set for that."},{"line_number":72,"context_line":"\"\"\"),"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    cfg.IPOpt(\u0027proxyclient_address\u0027,"},{"line_number":75,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":76,"context_line":"        help\u003d\"\"\""},{"line_number":77,"context_line":"The IP address to which proxy clients (like ``nova-serialproxy``) should"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_07ae9297","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":13},"updated":"2016-08-10 20:57:46.000000000","message":"Can this be a hostname?","commit_id":"7330d51aefb217c9b24fc83fda8e07ff4db59af2"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"07c466530ff7c08920fd0629ce0a3f3f0c772784","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  and ``key`` in the ``[DEFAULT]`` section have to be set for that."},{"line_number":72,"context_line":"\"\"\"),"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    cfg.IPOpt(\u0027proxyclient_address\u0027,"},{"line_number":75,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":76,"context_line":"        help\u003d\"\"\""},{"line_number":77,"context_line":"The IP address to which proxy clients (like ``nova-serialproxy``) should"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_edbf345e","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":13},"in_reply_to":"9ad45d7e_07283b85","updated":"2016-08-21 19:12:53.000000000","message":"Right we got bitten by that before","commit_id":"7330d51aefb217c9b24fc83fda8e07ff4db59af2"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3fa4de0b30e41050c7062f78fed740aae1dc3593","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  and ``key`` in the ``[DEFAULT]`` section have to be set for that."},{"line_number":72,"context_line":"\"\"\"),"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    cfg.IPOpt(\u0027proxyclient_address\u0027,"},{"line_number":75,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":76,"context_line":"        help\u003d\"\"\""},{"line_number":77,"context_line":"The IP address to which proxy clients (like ``nova-serialproxy``) should"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_07283b85","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":13},"in_reply_to":"9ad45d7e_07ae9297","updated":"2016-08-11 08:46:01.000000000","message":"After reading [1] this is a valid question. The docs of libvirt [2] don\u0027t say that this has to be an IP address and a very few examples show \"host\u003d\u0027localhost\u0027\" which make me believe that a hostname is valid. The libvirt driver expects it to be a string though, otherwise the usage for the domain XML file doesn\u0027t work at [3] and [4] I think.\nLong story short, I think this should keep being a StrOpt.\n\n\n[1] https://bugs.launchpad.net/nova/+bug/1611940\n[2] https://libvirt.org/formatdomain.html\n[3] https://github.com/openstack/nova/blob/a059c8453ea3739e45ea1cc56eacc82603a25b0f/nova/virt/libvirt/driver.py#L4115-L4116\n[4] https://github.com/openstack/nova/blob/a221eb4cc6ea6bd3459495be9d2a443e9808fb1a/nova/virt/libvirt/config.py#L1624-L1624","commit_id":"7330d51aefb217c9b24fc83fda8e07ff4db59af2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"24e3d05e213c8b0bce7316ad02cbfe680d64f834","unresolved":false,"context_lines":[{"line_number":96,"context_line":"* Ensure that this is the same IP address which is defined in the option"},{"line_number":97,"context_line":"  ``base_url`` of this section or use ``0.0.0.0`` to listen on all addresses."},{"line_number":98,"context_line":"\"\"\"),"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    cfg.PortOpt(\u0027serialproxy_port\u0027,"},{"line_number":101,"context_line":"        default\u003d6083,"},{"line_number":102,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da7fb54a_353fe826","line":99,"updated":"2016-09-02 16:24:55.000000000","message":"Can you remove these newlines, please?","commit_id":"c14eee9653be3ef864e000538cb27c5055c4a320"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b8390527ce1cd036c78105f596fced931cecab3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  and that both are in range from 0 to 65535."},{"line_number":51,"context_line":"\"\"\"),"},{"line_number":52,"context_line":"    cfg.URIOpt(\u0027base_url\u0027,"},{"line_number":53,"context_line":"        default\u003d\u0027ws://127.0.0.1:6083/\u0027,"},{"line_number":54,"context_line":"        help\u003d\"\"\""},{"line_number":55,"context_line":"The URL an end user would use to connect to the ``nova-serialproxy`` service."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_d07ce274","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":20},"updated":"2016-09-14 12:36:43.000000000","message":"Will this always have this protocol? If so, maybe add a todo to check for that in the future? I\u0027m working on a fix in oslo.config for this:\n\n    https://review.openstack.org/#/c/369471/","commit_id":"85ec58c371198decc11d5fdfeec9c8813233d059"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5a0a9cd12ec01728f7c0d6185302ca9225cfac13","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  Be sure that the first port number is lower than the second port number"},{"line_number":50,"context_line":"  and that both are in range from 0 to 65535."},{"line_number":51,"context_line":"\"\"\"),"},{"line_number":52,"context_line":"    # TODO(macsz) check if WS protocol is still being used"},{"line_number":53,"context_line":"    cfg.URIOpt(\u0027base_url\u0027,"},{"line_number":54,"context_line":"        default\u003d\u0027ws://127.0.0.1:6083/\u0027,"},{"line_number":55,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a74a57a_f34c23ca","line":52,"updated":"2016-11-25 18:30:15.000000000","message":"its the websocket thing I think.","commit_id":"bd0dc61e2e0902d14298a9039cb6704b1061f1c3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f42f0e9036a5bcc11388a8d49553a8ca2453eb43","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  and that both are in range from 0 to 65535."},{"line_number":51,"context_line":"\"\"\"),"},{"line_number":52,"context_line":"    # TODO(macsz) check if WS protocol is still being used"},{"line_number":53,"context_line":"    cfg.URIOpt(\u0027base_url\u0027,"},{"line_number":54,"context_line":"        default\u003d\u0027ws://127.0.0.1:6083/\u0027,"},{"line_number":55,"context_line":"        help\u003d\"\"\""},{"line_number":56,"context_line":"The URL an end user would use to connect to the ``nova-serialproxy`` service."}],"source_content_type":"text/x-python","patch_set":11,"id":"5a74a57a_867b9d8b","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":14},"updated":"2016-11-27 10:41:34.000000000","message":"Nice to define as URIOpt.","commit_id":"bd0dc61e2e0902d14298a9039cb6704b1061f1c3"}]}