)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b87def3659dbe4a44c53c788d20ca4540eed6b61","unresolved":false,"context_lines":[{"line_number":3555,"context_line":"            migration_p \u003d obj_base.obj_to_primitive(migration)"},{"line_number":3556,"context_line":"            self.network_api.migrate_instance_finish(context,"},{"line_number":3557,"context_line":"                                                     instance,"},{"line_number":3558,"context_line":"                                                     migration_p)"},{"line_number":3559,"context_line":"            network_info \u003d self.network_api.get_instance_nw_info(context,"},{"line_number":3560,"context_line":"                                                                 instance)"},{"line_number":3561,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_ea1a4a16","line":3558,"updated":"2016-08-04 12:35:44.000000000","message":"This now happens before plug_vifs. I think thats correct.","commit_id":"11f7ec0c6535f7645abb24512398a1c7e993072a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b87def3659dbe4a44c53c788d20ca4540eed6b61","unresolved":false,"context_lines":[{"line_number":3557,"context_line":"                                                     instance,"},{"line_number":3558,"context_line":"                                                     migration_p)"},{"line_number":3559,"context_line":"            network_info \u003d self.network_api.get_instance_nw_info(context,"},{"line_number":3560,"context_line":"                                                                 instance)"},{"line_number":3561,"context_line":""},{"line_number":3562,"context_line":"            block_device_info \u003d self._get_instance_block_device_info("},{"line_number":3563,"context_line":"                    context, instance, refresh_conn_info\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_ca9ae66d","line":3560,"updated":"2016-08-04 12:35:44.000000000","message":"Nit: its almost worth a comment to say why this needs to be called in this order.","commit_id":"11f7ec0c6535f7645abb24512398a1c7e993072a"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5e2ef863d324951f794b00cebd34423ac0c98613","unresolved":false,"context_lines":[{"line_number":4678,"context_line":"                                              instance\u003dself.instance,"},{"line_number":4679,"context_line":"                                              reservations\u003dNone)"},{"line_number":4680,"context_line":"            finish_revert_migration.assert_called_with(self.context,"},{"line_number":4681,"context_line":"                self.instance, self.nw_info, mock.ANY, mock.ANY)"},{"line_number":4682,"context_line":""},{"line_number":4683,"context_line":"        do_test()"},{"line_number":4684,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2c8f7fcd","line":4681,"range":{"start_line":4681,"start_character":31,"end_line":4681,"end_character":43},"updated":"2016-08-03 23:30:59.000000000","message":"Shouldn\u0027t this be \"nw_info\" instead since you want to test that migrate_instance_finish was called before finish_revert_migration?","commit_id":"cd4c1084378274cd1e55e1d3011b6afdb09caa00"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"0f6a36e34a424e850772bfdc199b7de2866cdc5a","unresolved":false,"context_lines":[{"line_number":4678,"context_line":"                                              instance\u003dself.instance,"},{"line_number":4679,"context_line":"                                              reservations\u003dNone)"},{"line_number":4680,"context_line":"            finish_revert_migration.assert_called_with(self.context,"},{"line_number":4681,"context_line":"                self.instance, self.nw_info, mock.ANY, mock.ANY)"},{"line_number":4682,"context_line":""},{"line_number":4683,"context_line":"        do_test()"},{"line_number":4684,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_b5ebae77","line":4681,"range":{"start_line":4681,"start_character":31,"end_line":4681,"end_character":43},"in_reply_to":"bacf61ea_2c8f7fcd","updated":"2016-08-04 01:11:33.000000000","message":"Good catch.  Thanks Melanie.","commit_id":"cd4c1084378274cd1e55e1d3011b6afdb09caa00"}]}