)]}'
{"nova/tests/unit/test_metadata.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6159da1ed74ab2cc8478754a8ca53f36be6e73a2","unresolved":false,"context_lines":[{"line_number":926,"context_line":""},{"line_number":927,"context_line":"            # and exception should result in nothing being added, but no error"},{"line_number":928,"context_line":"            self.assertEqual({}, vd[\u0027web\u0027])"},{"line_number":929,"context_line":"            self.assertTrue(log_mock.assert_called)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"    @mock.patch.object(vendordata_dynamic.LOG, \u0027warning\u0027)"},{"line_number":932,"context_line":"    @mock.patch.object(requests, \u0027request\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_0bbdb3b6","line":929,"range":{"start_line":929,"start_character":37,"end_line":929,"end_character":50},"updated":"2016-08-30 01:08:11.000000000","message":"assert_called is not a thing, you\u0027d have to use assert_called_once_with or assert_called_with or assert_has_calls or something like that.","commit_id":"1a6dd33993d2db72e4309dfd819c015aff75cf8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"049863b59ef58ccb0ad7d009971504935ba33fec","unresolved":false,"context_lines":[{"line_number":926,"context_line":""},{"line_number":927,"context_line":"            # and exception should result in nothing being added, but no error"},{"line_number":928,"context_line":"            self.assertEqual({}, vd[\u0027web\u0027])"},{"line_number":929,"context_line":"            self.assertTrue(log_mock.assert_called)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"    @mock.patch.object(vendordata_dynamic.LOG, \u0027warning\u0027)"},{"line_number":932,"context_line":"    @mock.patch.object(requests, \u0027request\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_8bc9c35b","line":929,"range":{"start_line":929,"start_character":37,"end_line":929,"end_character":50},"in_reply_to":"fa7ab95a_0bbdb3b6","updated":"2016-08-30 01:09:27.000000000","message":"Given you\u0027re using assertTrue, you probably just meant to use assertTrue(log_mock.called).\n\nassert_called equates to True since it returns a DEFAULT stub which is truthy.","commit_id":"1a6dd33993d2db72e4309dfd819c015aff75cf8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8de402ec8bb8ac919cf3333131ad77933996408","unresolved":false,"context_lines":[{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    def _test_vendordata2_response_inner_exceptional("},{"line_number":903,"context_line":"            self, request_mock, log_mock, exc):"},{"line_number":904,"context_line":"        request_mock.return_value.side_effect \u003d exc(\u0027Ta da!\u0027)"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        with utils.tempdir() as tmpdir:"},{"line_number":907,"context_line":"            jsonfile \u003d os.path.join(tmpdir, \u0027test.json\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_7748a8cc","line":904,"range":{"start_line":904,"start_character":8,"end_line":904,"end_character":45},"updated":"2016-08-30 18:08:42.000000000","message":"This is the problem, you don\u0027t need the return_value.","commit_id":"14b5f4486b39e64cbd30ea612120f7d458237448"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"14826ac9c7a17c98a529713b9fa93237faf3e105","unresolved":false,"context_lines":[{"line_number":926,"context_line":""},{"line_number":927,"context_line":"            # and exception should result in nothing being added, but no error"},{"line_number":928,"context_line":"            self.assertEqual({}, vd[\u0027web\u0027])"},{"line_number":929,"context_line":"            self.assertTrue(log_mock.called)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"    @mock.patch.object(vendordata_dynamic.LOG, \u0027warning\u0027)"},{"line_number":932,"context_line":"    @mock.patch.object(requests, \u0027request\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_c1c29552","line":929,"updated":"2016-08-30 16:50:56.000000000","message":"Hmm, this is failing now:\n\nhttp://logs.openstack.org/98/349298/3/check/gate-nova-python27-db-ubuntu-xenial/22171e1/console.html#_2016-08-30_01_24_55_853620","commit_id":"14b5f4486b39e64cbd30ea612120f7d458237448"}]}