)]}'
{"nova/objects/service.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a5e12e59e3d89c6e0e6ed4d12e7039e160a9226d","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    @base.remotable_classmethod"},{"line_number":451,"context_line":"    def get_all_computes_by_hv_type(cls, context, hv_type):"},{"line_number":452,"context_line":"        db_services \u003d db.service_get_all_computes_by_hv_type("},{"line_number":453,"context_line":"            context, hv_type, include_disabled\u003dFalse)"},{"line_number":454,"context_line":"        return base.obj_make_list(context, cls(context), objects.Service,"},{"line_number":455,"context_line":"                                  db_services)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_43a48e07","line":453,"range":{"start_line":453,"start_character":28,"end_line":453,"end_character":52},"updated":"2016-08-02 16:29:06.000000000","message":"I don\u0027t think this is necessary","commit_id":"45317d6273d75fcca349ebc195538ec69fd9d024"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f09d08ea9172674b4d25c49a050cff7b0208b390","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    @base.remotable_classmethod"},{"line_number":451,"context_line":"    def get_all_computes_by_hv_type(cls, context, hv_type):"},{"line_number":452,"context_line":"        db_services \u003d db.service_get_all_computes_by_hv_type("},{"line_number":453,"context_line":"            context, hv_type, include_disabled\u003dFalse)"},{"line_number":454,"context_line":"        return base.obj_make_list(context, cls(context), objects.Service,"},{"line_number":455,"context_line":"                                  db_services)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_63227203","line":453,"range":{"start_line":453,"start_character":28,"end_line":453,"end_character":52},"in_reply_to":"bacf61ea_43a48e07","updated":"2016-08-02 16:33:47.000000000","message":"It\u0027s not, but it\u0027s a good practice. If we ever changed that default and didn\u0027t specify it here, we would implicitly change the behavior of an RPC interface without any detection of it. So being super explicit here helps prevent that breakage later when someone decides that the low level function should behave differently.","commit_id":"45317d6273d75fcca349ebc195538ec69fd9d024"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e2ed3c9865a2a9e549ea8db3fd586e963c356641","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    @base.remotable_classmethod"},{"line_number":451,"context_line":"    def get_all_computes_by_hv_type(cls, context, hv_type):"},{"line_number":452,"context_line":"        db_services \u003d db.service_get_all_computes_by_hv_type("},{"line_number":453,"context_line":"            context, hv_type, include_disabled\u003dFalse)"},{"line_number":454,"context_line":"        return base.obj_make_list(context, cls(context), objects.Service,"},{"line_number":455,"context_line":"                                  db_services)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_03629616","line":453,"range":{"start_line":453,"start_character":28,"end_line":453,"end_character":52},"in_reply_to":"bacf61ea_63227203","updated":"2016-08-02 16:38:01.000000000","message":"That\u0027s a good point -- thanks","commit_id":"45317d6273d75fcca349ebc195538ec69fd9d024"}]}