)]}'
{"nova/conf/neutron.py":[{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":29,"context_line":"neutron_options \u003d None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"neutron_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027url\u0027,"},{"line_number":34,"context_line":"        default\u003d\u0027http://127.0.0.1:9696\u0027,"},{"line_number":35,"context_line":"        help\u003d\"\"\""},{"line_number":36,"context_line":"This option specifies the URL for connecting to Neutron."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f9cdae66","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":14},"updated":"2016-08-01 20:34:24.000000000","message":"put them in same line","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    matches the URL returned for the \u0027network\u0027 service type from the"},{"line_number":43,"context_line":"    Keystone service catalog."},{"line_number":44,"context_line":"\"\"\"),"},{"line_number":45,"context_line":"    cfg.StrOpt("},{"line_number":46,"context_line":"        \u0027region_name\u0027,"},{"line_number":47,"context_line":"        default\u003d\u0027RegionOne\u0027,"},{"line_number":48,"context_line":"        help\u003d\"\"\""},{"line_number":49,"context_line":"Region name for connecting to Neutron in admin context."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4707b681","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":21},"updated":"2016-08-01 20:34:24.000000000","message":"put in same line","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  * Any string representing a region name."},{"line_number":61,"context_line":"\"\"\"),"},{"line_number":62,"context_line":"    cfg.StrOpt("},{"line_number":63,"context_line":"        \u0027ovs_bridge\u0027,"},{"line_number":64,"context_line":"         default\u003d\u0027br-int\u0027,"},{"line_number":65,"context_line":"         help\u003d\"\"\""},{"line_number":66,"context_line":"Specifies the name of an integration bridge interface used by OpenvSwitch."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_87fd2e70","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":21},"updated":"2016-08-01 20:34:24.000000000","message":"put in same line","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Possible values:"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  * Any string representing OVS bridge name."},{"line_number":72,"context_line":"  * default value is \u0027br-int\u0027"},{"line_number":73,"context_line":"\"\"\"),"},{"line_number":74,"context_line":"    cfg.IntOpt("},{"line_number":75,"context_line":"        \u0027extension_sync_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_b9569603","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":29},"updated":"2016-08-01 20:34:24.000000000","message":"per https://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_description:\n\nOmit this line since it is only duplicating the machine readable info in the option definition","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  * Any string representing OVS bridge name."},{"line_number":72,"context_line":"  * default value is \u0027br-int\u0027"},{"line_number":73,"context_line":"\"\"\"),"},{"line_number":74,"context_line":"    cfg.IntOpt("},{"line_number":75,"context_line":"        \u0027extension_sync_interval\u0027,"},{"line_number":76,"context_line":"         default\u003d600,"},{"line_number":77,"context_line":"         help\u003d\"\"\""},{"line_number":78,"context_line":"Number of seconds to wait before querying Neutron for extensions."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_c7fba677","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":34},"updated":"2016-08-01 20:34:24.000000000","message":"put in same line","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Possible values:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  * Any positive Integer value"},{"line_number":85,"context_line":"  * default value is 600"},{"line_number":86,"context_line":"\"\"\"),"},{"line_number":87,"context_line":"]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_39e74641","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":24},"updated":"2016-08-01 20:34:24.000000000","message":"per https://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_description:\n\nOmit this line since it is only duplicating the machine readable info in the option definition","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":87,"context_line":"]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"metadata_proxy_opts \u003d ["},{"line_number":90,"context_line":"    cfg.BoolOpt("},{"line_number":91,"context_line":"        \"service_metadata_proxy\","},{"line_number":92,"context_line":"        default\u003dFalse,"},{"line_number":93,"context_line":"        help\u003d\"\"\""},{"line_number":94,"context_line":"When set to True, this option indicates that Neutron will be used to proxy"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2731e25a","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":33},"updated":"2016-08-01 20:34:24.000000000","message":"put in same line","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":95,"context_line":"metadata requests and resolve instance ids. Otherwise, the instance ID must be"},{"line_number":96,"context_line":"passed to the metadata request in the \u0027X-Instance-ID\u0027 header."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Possible values:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    True, False (default)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* Related options:"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e7298a9c","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":25},"updated":"2016-08-01 20:34:24.000000000","message":"per https://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_description:\n\nOmit this section if it is only duplicating the machine readable info in the option definition, such as for all boolean settings, unless the true/false values need describing for some reason.","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"26a5ba259f0d44a5842635666a212de56294ae54","unresolved":false,"context_lines":[{"line_number":95,"context_line":"metadata requests and resolve instance ids. Otherwise, the instance ID must be"},{"line_number":96,"context_line":"passed to the metadata request in the \u0027X-Instance-ID\u0027 header."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Possible values:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    True, False (default)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* Related options:"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5f081328","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":25},"in_reply_to":"bacf61ea_e7298a9c","updated":"2016-08-01 21:16:05.000000000","message":"+1","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6ab77453cad42f3c00c10fff495bcae4906a22ee","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    metadata_proxy_shared_secret"},{"line_number":105,"context_line":"\"\"\"),"},{"line_number":106,"context_line":"     cfg.StrOpt("},{"line_number":107,"context_line":"        \"metadata_proxy_shared_secret\","},{"line_number":108,"context_line":"        default\u003d\"\","},{"line_number":109,"context_line":"        secret\u003dTrue,"},{"line_number":110,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_87340e4a","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":39},"updated":"2016-08-01 20:34:24.000000000","message":"put in same line","commit_id":"cd3e5d331f6983516bbe441551aafdb8de29d056"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5ea7005b8309ac7edbb5eb7b76489a2aece677ea","unresolved":false,"context_lines":[{"line_number":74,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":75,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  * Any positive Integer value"},{"line_number":80,"context_line":"\"\"\"),"},{"line_number":81,"context_line":"]"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bf482fb4","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":30},"updated":"2016-08-01 21:37:25.000000000","message":"Drop this section as it is clear from type that this is integer. Add \"min\u003d0\" to enforce value is positive. refer http://docs.openstack.org/developer/oslo.config/opts.html","commit_id":"af83ae2c256ba8fdd21adffbd0ce5a3a7fe5cfa1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"f6090cd1cd24de860b41226e1c6eec745ed8c34c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NEUTRON_GROUP \u003d \u0027neutron\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"neutron_group \u003d cfg.OptGroup(NEUTRON_GROUP, title\u003d\u0027Neutron Options\u0027)"},{"line_number":28,"context_line":"neutron_options \u003d None"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"neutron_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b4a93e27","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":68},"updated":"2016-08-02 17:32:36.000000000","message":"Can you please fix formatting of this to be consistent with other groups?\nrefer to https://github.com/openstack/nova/blob/master/nova/conf/conductor.py#L25 , you can also add help in group to explain a little about this group.","commit_id":"27ddb74f7327f56b435d062f4aee891c955e0369"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"7f1f01f6688a28d7b5a314402b0b77a73359cd16","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NEUTRON_GROUP \u003d \u0027neutron\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"neutron_group \u003d cfg.OptGroup(NEUTRON_GROUP, title\u003d\u0027Neutron Options\u0027)"},{"line_number":28,"context_line":"neutron_options \u003d None"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"neutron_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_373f0dd8","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":68},"in_reply_to":"bacf61ea_b4a93e27","updated":"2016-08-02 20:19:43.000000000","message":"Done","commit_id":"27ddb74f7327f56b435d062f4aee891c955e0369"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"d069715c8c84988b0afd981b9cd7515cd43905fc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"to Keystone, the Keystone service uses the region_name to determine the"},{"line_number":53,"context_line":"region the request is coming from."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  * Any string representing a region name."},{"line_number":58,"context_line":"\"\"\"),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027ovs_bridge\u0027,"},{"line_number":60,"context_line":"         default\u003d\u0027br-int\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b402deb2","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":42},"updated":"2016-08-02 17:32:39.000000000","message":"you can remove this line, add this for only interesting cases.","commit_id":"27ddb74f7327f56b435d062f4aee891c955e0369"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"d069715c8c84988b0afd981b9cd7515cd43905fc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Neutron metadata requests. In order to be used, the"},{"line_number":97,"context_line":"\u0027X-Metadata-Provider-Signature\u0027 header must be supplied in the request."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Possible values:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    Any string"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* Related options:"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_142aca2c","line":101,"range":{"start_line":99,"start_character":1,"end_line":101,"end_character":14},"updated":"2016-08-02 17:32:39.000000000","message":"ditto","commit_id":"27ddb74f7327f56b435d062f4aee891c955e0369"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"47b8e3be798db938108a51ab11e4da96dc2b7a17","unresolved":false,"context_lines":[{"line_number":25,"context_line":"NEUTRON_GROUP \u003d \u0027neutron\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"neutron_group \u003d cfg.OptGroup("},{"line_number":28,"context_line":"    NEUTRON_GROUP,"},{"line_number":29,"context_line":"    title\u003d\u0027Neutron Options\u0027)"},{"line_number":30,"context_line":"neutron_options \u003d None"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_e77dc0b2","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":17},"updated":"2016-08-02 22:11:50.000000000","message":"You can directly use string name \u0027neutron\u0027 here and delete the variable \"NEUTRON_GROUP\" above.","commit_id":"2f769d73bbde4ada54b806102be3e4a9e5c82a28"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"e271b8c65d26e960922e5829946196ead846c7f1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"NEUTRON_GROUP \u003d \u0027neutron\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"neutron_group \u003d cfg.OptGroup("},{"line_number":28,"context_line":"    NEUTRON_GROUP,"},{"line_number":29,"context_line":"    title\u003d\u0027Neutron Options\u0027)"},{"line_number":30,"context_line":"neutron_options \u003d None"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_f15708c8","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":17},"in_reply_to":"bacf61ea_388c1535","updated":"2016-08-03 18:08:04.000000000","message":"Ok leave that then. Just add a help variable in group and that will do.","commit_id":"2f769d73bbde4ada54b806102be3e4a9e5c82a28"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"4ecbeb742212eb173bcf3d08afc1cb2979f6dc49","unresolved":false,"context_lines":[{"line_number":25,"context_line":"NEUTRON_GROUP \u003d \u0027neutron\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"neutron_group \u003d cfg.OptGroup("},{"line_number":28,"context_line":"    NEUTRON_GROUP,"},{"line_number":29,"context_line":"    title\u003d\u0027Neutron Options\u0027)"},{"line_number":30,"context_line":"neutron_options \u003d None"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_388c1535","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":17},"in_reply_to":"bacf61ea_e77dc0b2","updated":"2016-08-03 17:58:16.000000000","message":"Removing NEUTRON_NAME gives a pep8 error \u0027undefined name\u0027 since it\u0027s used in /network/neutron2/api.py","commit_id":"2f769d73bbde4ada54b806102be3e4a9e5c82a28"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dbf3de436da8e4f2903ae018ccf4fc641b3f8b78","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    NEUTRON_GROUP,"},{"line_number":29,"context_line":"    title\u003d\u0027Neutron Options\u0027,"},{"line_number":30,"context_line":"    help\u003d\"\"\""},{"line_number":31,"context_line":"    Configuration options for Neutron (network connectivity as a service)."},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":"neutron_options \u003d None"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_8678adc5","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":4},"updated":"2016-08-05 12:39:32.000000000","message":"we should not indent here, this shows up in the sample file","commit_id":"02460cca421c294bef26f3e4819d4efb49f2c190"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dbf3de436da8e4f2903ae018ccf4fc641b3f8b78","unresolved":false,"context_lines":[{"line_number":73,"context_line":"         help\u003d\"\"\""},{"line_number":74,"context_line":"Number of seconds to wait before querying Neutron for extensions."},{"line_number":75,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":76,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":77,"context_line":"\"\"\"),"},{"line_number":78,"context_line":"]"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_860d4d40","line":76,"updated":"2016-08-05 12:39:32.000000000","message":"what does 0 mean here? Looking at the code it means no sync should happen.","commit_id":"02460cca421c294bef26f3e4819d4efb49f2c190"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"df70dd89792292e9e17848f15e21033df615ac5a","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"ALL_OPTS \u003d (neutron_opts + metadata_proxy_opts)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"deprecations \u003d {\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_certificates_file\u0027,"},{"line_number":109,"context_line":"                                             group\u003dNEUTRON_GROUP)],"},{"line_number":110,"context_line":"                \u0027insecure\u0027: [cfg.DeprecatedOpt(\u0027api_insecure\u0027,"},{"line_number":111,"context_line":"                                               group\u003dNEUTRON_GROUP)],"},{"line_number":112,"context_line":"                \u0027timeout\u0027: [cfg.DeprecatedOpt(\u0027url_timeout\u0027,"},{"line_number":113,"context_line":"                                              group\u003dNEUTRON_GROUP)]}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def _gen_opts_from_plugins():"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_6aa769bd","line":113,"range":{"start_line":108,"start_character":0,"end_line":113,"end_character":68},"updated":"2016-08-04 17:10:09.000000000","message":"I am hung on this section, Seems like this code is deprecating group names. But I see the same code for Mitake https://github.com/openstack/nova/blob/stable/mitaka/nova/network/neutronv2/api.py#L64. So I need to check with someone as should this be removed from now.","commit_id":"02460cca421c294bef26f3e4819d4efb49f2c190"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dbf3de436da8e4f2903ae018ccf4fc641b3f8b78","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"ALL_OPTS \u003d (neutron_opts + metadata_proxy_opts)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"deprecations \u003d {\u0027cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_certificates_file\u0027,"},{"line_number":109,"context_line":"                                             group\u003dNEUTRON_GROUP)],"},{"line_number":110,"context_line":"                \u0027insecure\u0027: [cfg.DeprecatedOpt(\u0027api_insecure\u0027,"},{"line_number":111,"context_line":"                                               group\u003dNEUTRON_GROUP)],"},{"line_number":112,"context_line":"                \u0027timeout\u0027: [cfg.DeprecatedOpt(\u0027url_timeout\u0027,"},{"line_number":113,"context_line":"                                              group\u003dNEUTRON_GROUP)]}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def _gen_opts_from_plugins():"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_4154dffc","line":113,"range":{"start_line":108,"start_character":0,"end_line":113,"end_character":68},"in_reply_to":"bacf61ea_6aa769bd","updated":"2016-08-05 12:39:32.000000000","message":"Its cheap to keep this one more cycle while we get more tooling to help admins.","commit_id":"02460cca421c294bef26f3e4819d4efb49f2c190"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"913872760f2a0a0dda4e842be85ba5b5108f29bb","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* The default is \u0027http://127.0.0.1:9696\u0027 however any valid URL that"},{"line_number":44,"context_line":"  points to the Neutron API service is appropriate here. This typically"},{"line_number":45,"context_line":"  matches the URL returned for the \u0027network\u0027 service type from the"},{"line_number":46,"context_line":"  Keystone service catalog."}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_ed2baae9","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":50},"updated":"2016-08-09 16:25:58.000000000","message":"You shouldn\u0027t reference the default, as it\u0027s already defined on line 37 and this creates an unnecessary binding","commit_id":"9aa8fb31ed8bd909e05b5e00f0ee6b4f7c9c5a42"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"91a6215ce57dbdff48c02b3d2f698feec18b1795","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  * Any valid URL that points to the Neutron API service is appropriate here."},{"line_number":44,"context_line":"    This typically matches the URL returned for the \u0027network\u0027 service type"},{"line_number":45,"context_line":"    from the Keystone service catalog."},{"line_number":46,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_c1eaafab","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":2},"updated":"2016-08-10 18:08:58.000000000","message":"Remove this space wen you respin","commit_id":"a2f7851966e28ea504d4ae0c2cbd98f1343a8b29"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"91a6215ce57dbdff48c02b3d2f698feec18b1795","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Possible values:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  * Any string representing OVS bridge name."},{"line_number":68,"context_line":"\"\"\"),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027extension_sync_interval\u0027,"},{"line_number":70,"context_line":"         default\u003d600,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_21d46bea","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":2},"updated":"2016-08-10 18:08:58.000000000","message":"same","commit_id":"a2f7851966e28ea504d4ae0c2cbd98f1343a8b29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e68595e7f8fd42bdceb0e3a0d7a1519447da5d95","unresolved":false,"context_lines":[{"line_number":72,"context_line":"         help\u003d\"\"\""},{"line_number":73,"context_line":"Number of seconds to wait before querying Neutron for extensions."},{"line_number":74,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":75,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":76,"context_line":"\"\"\"),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_6bd499bc","line":75,"updated":"2016-08-10 11:07:26.000000000","message":"You seem to have regressed here and removed the \u0027Possible values:\u0027 section","commit_id":"a2f7851966e28ea504d4ae0c2cbd98f1343a8b29"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"3e8dc5d8ed74595f3ec3c401a0442facc99ea151","unresolved":false,"context_lines":[{"line_number":72,"context_line":"         help\u003d\"\"\""},{"line_number":73,"context_line":"Number of seconds to wait before querying Neutron for extensions."},{"line_number":74,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":75,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":76,"context_line":"\"\"\"),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_be1ebb5c","line":75,"in_reply_to":"9ad45d7e_6bd499bc","updated":"2016-08-10 17:35:36.000000000","message":"Thanks.  Yes, my mistake here.","commit_id":"a2f7851966e28ea504d4ae0c2cbd98f1343a8b29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e68595e7f8fd42bdceb0e3a0d7a1519447da5d95","unresolved":false,"context_lines":[{"line_number":84,"context_line":"metadata requests and resolve instance ids. Otherwise, the instance ID must be"},{"line_number":85,"context_line":"passed to the metadata request in the \u0027X-Instance-ID\u0027 header."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* Related options:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    metadata_proxy_shared_secret"},{"line_number":90,"context_line":"\"\"\"),"},{"line_number":91,"context_line":"     cfg.StrOpt(\"metadata_proxy_shared_secret\","},{"line_number":92,"context_line":"        default\u003d\"\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_2bf58156","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":32},"updated":"2016-08-10 11:07:26.000000000","message":"You seem to have regressed here. This should read (afaik):\n\n    Related options:\n\n    * metadata_proxy_shared_secret","commit_id":"a2f7851966e28ea504d4ae0c2cbd98f1343a8b29"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"3e8dc5d8ed74595f3ec3c401a0442facc99ea151","unresolved":false,"context_lines":[{"line_number":84,"context_line":"metadata requests and resolve instance ids. Otherwise, the instance ID must be"},{"line_number":85,"context_line":"passed to the metadata request in the \u0027X-Instance-ID\u0027 header."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* Related options:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    metadata_proxy_shared_secret"},{"line_number":90,"context_line":"\"\"\"),"},{"line_number":91,"context_line":"     cfg.StrOpt(\"metadata_proxy_shared_secret\","},{"line_number":92,"context_line":"        default\u003d\"\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_66bdd901","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":32},"in_reply_to":"9ad45d7e_2bf58156","updated":"2016-08-10 17:35:36.000000000","message":"I\u0027m not understanding your point on this one?\nI didn\u0027t change anything here, and only difference I see if you moved the asterisk down to the next line which is inconsistent with other formatting.","commit_id":"a2f7851966e28ea504d4ae0c2cbd98f1343a8b29"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"e07473594f6ef32e3c7e4d8ea8a86088f2307fe8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"metadata requests and resolve instance ids. Otherwise, the instance ID must be"},{"line_number":85,"context_line":"passed to the metadata request in the \u0027X-Instance-ID\u0027 header."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* Related options:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    metadata_proxy_shared_secret"},{"line_number":90,"context_line":"\"\"\"),"},{"line_number":91,"context_line":"     cfg.StrOpt(\"metadata_proxy_shared_secret\","},{"line_number":92,"context_line":"        default\u003d\"\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_21a62bae","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":32},"in_reply_to":"9ad45d7e_66bdd901","updated":"2016-08-10 18:06:23.000000000","message":"+1 with Stephen. You need asterisk in front of options to render those properly in doc and not the heading.  You should check how your options are rendered in the doc http://docs-draft.openstack.org/05/349605/8/check/gate-nova-docs-ubuntu-xenial/cb507bf//doc/build/html/sample_config.html","commit_id":"a2f7851966e28ea504d4ae0c2cbd98f1343a8b29"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"91a6215ce57dbdff48c02b3d2f698feec18b1795","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Neutron metadata requests. In order to be used, the"},{"line_number":97,"context_line":"\u0027X-Metadata-Provider-Signature\u0027 header must be supplied in the request."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"* Related options:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    service_metadata_proxy"},{"line_number":102,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_c10f4f86","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":2},"updated":"2016-08-10 18:08:58.000000000","message":"Move this in front of an option","commit_id":"a2f7851966e28ea504d4ae0c2cbd98f1343a8b29"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"598d01829460a07024e6388ae985f850ba364baa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    NEUTRON_GROUP,"},{"line_number":29,"context_line":"    title\u003d\u0027Neutron Options\u0027,"},{"line_number":30,"context_line":"    help\u003d\"\"\""},{"line_number":31,"context_line":"    Configuration options for Neutron (network connectivity as a service)."},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":"neutron_options \u003d None"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_dc19ed89","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":4},"updated":"2016-08-10 20:49:35.000000000","message":"Indentation is still wrong on this","commit_id":"50c8404db3e4e6edac271590f551f1ec52130d9a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"c4b7e509104becff0cb73ae1c2b5d6af27238b35","unresolved":false,"context_lines":[{"line_number":74,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":75,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Any positive Integer value"},{"line_number":80,"context_line":"\"\"\"),"},{"line_number":81,"context_line":"]"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_e7dede0f","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":28},"updated":"2016-08-10 21:00:22.000000000","message":"Drop this","commit_id":"3e766050a75bcbede25a902774624bd325f5d052"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"49338b16149af8b2f3398c8092bf747ed1d31a57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Copyright 2016 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_459346fa","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":40},"updated":"2016-08-11 11:07:16.000000000","message":"I think this can probably be removed now also: all the criteria defined on the wiki seem to be satisfied (as best they can, given the magic going on with some opts)\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_registration_consistency","commit_id":"949e12d2caa7060051d2da2d96bc402afee4064d"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"ee305d78f8bdca19db29d9b53fec939a92f86523","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Copyright 2016 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_ba1e8b09","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":40},"in_reply_to":"9ad45d7e_459346fa","updated":"2016-08-11 16:07:01.000000000","message":"Ok","commit_id":"949e12d2caa7060051d2da2d96bc402afee4064d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"49338b16149af8b2f3398c8092bf747ed1d31a57","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    NEUTRON_GROUP,"},{"line_number":29,"context_line":"    title\u003d\u0027Neutron Options\u0027,"},{"line_number":30,"context_line":"    help\u003d\"\"\""},{"line_number":31,"context_line":"Configuration options for Neutron (network connectivity as a service)."},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":"neutron_options \u003d None"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_25a57246","line":31,"range":{"start_line":31,"start_character":26,"end_line":31,"end_character":27},"updated":"2016-08-11 11:07:16.000000000","message":"nit: neutron (all services are lower case, per documentation guidelines)","commit_id":"949e12d2caa7060051d2da2d96bc402afee4064d"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"ee305d78f8bdca19db29d9b53fec939a92f86523","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    NEUTRON_GROUP,"},{"line_number":29,"context_line":"    title\u003d\u0027Neutron Options\u0027,"},{"line_number":30,"context_line":"    help\u003d\"\"\""},{"line_number":31,"context_line":"Configuration options for Neutron (network connectivity as a service)."},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":"neutron_options \u003d None"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_3ac0db4f","line":31,"range":{"start_line":31,"start_character":26,"end_line":31,"end_character":27},"in_reply_to":"9ad45d7e_25a57246","updated":"2016-08-11 16:07:01.000000000","message":"Ok","commit_id":"949e12d2caa7060051d2da2d96bc402afee4064d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"49338b16149af8b2f3398c8092bf747ed1d31a57","unresolved":false,"context_lines":[{"line_number":72,"context_line":"         help\u003d\"\"\""},{"line_number":73,"context_line":"Number of seconds to wait before querying Neutron for extensions."},{"line_number":74,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":75,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":76,"context_line":"\"\"\"),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_c53a96e6","line":75,"updated":"2016-08-11 11:07:16.000000000","message":"What does \u00270\u0027 mean in this context? Is something disabled? If so, maybe document it and keep the \u0027Possible values\u0027 section?","commit_id":"949e12d2caa7060051d2da2d96bc402afee4064d"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6a237538acd3594afce463f4466984cdb22fb373","unresolved":false,"context_lines":[{"line_number":72,"context_line":"         help\u003d\"\"\""},{"line_number":73,"context_line":"Number of seconds to wait before querying Neutron for extensions."},{"line_number":74,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":75,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":76,"context_line":"\"\"\"),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_da3ffab1","line":75,"in_reply_to":"9ad45d7e_c53a96e6","updated":"2016-08-11 16:14:33.000000000","message":"I disagree with Possible value section. It\u0027s meaningless. Sample file will generate the type (Integer in this case) and default value, so no need for this section.\nThis value is interval so 0 means no wait https://github.com/openstack/nova/blob/71c007d9ed2150b329f258887b8b2e23f887d572/nova/network/neutronv2/api.py#L923","commit_id":"949e12d2caa7060051d2da2d96bc402afee4064d"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"ee305d78f8bdca19db29d9b53fec939a92f86523","unresolved":false,"context_lines":[{"line_number":72,"context_line":"         help\u003d\"\"\""},{"line_number":73,"context_line":"Number of seconds to wait before querying Neutron for extensions."},{"line_number":74,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":75,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":76,"context_line":"\"\"\"),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_14aa1019","line":75,"in_reply_to":"9ad45d7e_c53a96e6","updated":"2016-08-11 16:07:01.000000000","message":"It\u0027s a minimum value, so it the value can\u0027t be negative.  The description talks about it referring to seconds.","commit_id":"949e12d2caa7060051d2da2d96bc402afee4064d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"75aa8ad9a5a8deeaca1701c701f9a3ee03ae7bb0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"neutron_options \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"neutron_opts \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027url\u0027,"},{"line_number":36,"context_line":"        default\u003d\u0027http://127.0.0.1:9696\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"This option specifies the URL for connecting to Neutron."}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_b6c49f5f","line":35,"updated":"2016-08-12 17:19:38.000000000","message":"Nit: URIOpt would be better here.","commit_id":"3f9f2d7f0397f87cafd158710b8c208a5199b7e1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"e65ae586488fec8e9712e5c70ce091564d328453","unresolved":false,"context_lines":[{"line_number":73,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":74,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Any positive Integer value"},{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_dac25a84","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":28},"updated":"2016-08-11 16:15:52.000000000","message":"This should be dropped, Stephen check out sample file and let me know if you think otherwise.","commit_id":"3f9f2d7f0397f87cafd158710b8c208a5199b7e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cb3a3195f60e9621fa768250b1f1f4e5a12b90e3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":74,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Any positive Integer value"},{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_825afd4e","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":28},"in_reply_to":"9ad45d7e_64cc6789","updated":"2016-08-12 15:16:57.000000000","message":"I\u0027m thinking it should read something like this:\n\n    Possible values:\n\n    * Any positive integer value, corresponding to a time interval in seconds\n    * 0, to disable this feature\n\nMy point being that the significance of 0, which is not a positive integer and has special meaning, should be documented. This seems like the best format to use for that.","commit_id":"3f9f2d7f0397f87cafd158710b8c208a5199b7e1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"75aa8ad9a5a8deeaca1701c701f9a3ee03ae7bb0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":74,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Any positive Integer value"},{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_a6474c1c","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":28},"in_reply_to":"9ad45d7e_825afd4e","updated":"2016-08-12 17:19:38.000000000","message":"+1 sfinucane, except...\n\nIt turns out 0 will not disable this feature, it means you always fetch a new list (when you refresh).\n\nhttps://github.com/openstack/nova/blob/71c007d9ed2150b329f258887b8b2e23f887d572/nova/network/neutronv2/api.py#L919","commit_id":"3f9f2d7f0397f87cafd158710b8c208a5199b7e1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"001705e232b4b10e9165078b3e26a039f2259ebb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":74,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Any positive Integer value"},{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_5159ed8d","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":28},"in_reply_to":"9ad45d7e_825afd4e","updated":"2016-08-12 16:20:54.000000000","message":"Why can\u0027t we add description for 0 in text above. I am saying that because that is what we have been doing in other patches, so it will not be consistent if we treat this as different. Refer to this http://docs.openstack.org/developer/nova/sample_config.html from master","commit_id":"3f9f2d7f0397f87cafd158710b8c208a5199b7e1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ea4954e945605e0a60198e9c5a8216d076b46651","unresolved":false,"context_lines":[{"line_number":73,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":74,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Any positive Integer value"},{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_64cc6789","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":28},"in_reply_to":"9ad45d7e_ba0e86e2","updated":"2016-08-11 21:28:35.000000000","message":"So here is o/p from sample file\n# Number of seconds to wait before querying Neutron for extensions.\n# After this number of seconds the next time Nova needs to create a resource in\n# Neutron it will requery Neutron for the extensions that it has loaded.\n#\n# Possible values:\n#\n# * Any positive Integer value\n#  (integer value)\n# Minimum value: 0\n#extension_sync_interval \u003d 600\n\nIf you look into last 3 lines ofthe option above, it coneys all the message. So I think we should drop this section.\n\nOn your other point, it does say \"number of seconds\" as a time unit. Maybe add some description for 0 here.","commit_id":"3f9f2d7f0397f87cafd158710b8c208a5199b7e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a8a8ecd2641310a8328fd6aa7dde9d50bd166b93","unresolved":false,"context_lines":[{"line_number":73,"context_line":"After this number of seconds the next time Nova needs to create a resource in"},{"line_number":74,"context_line":"Neutron it will requery Neutron for the extensions that it has loaded."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Any positive Integer value"},{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_ba0e86e2","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":28},"in_reply_to":"9ad45d7e_dac25a84","updated":"2016-08-11 16:18:25.000000000","message":"IMO this should be kept but should describe the meaning of \u00270\u0027 also. From the code you linked earlier, it seems to mean no wait. If so, this should be documented.\n\nAlso, what units this integer corresponds to should be documented here IMO (seconds, right?)","commit_id":"3f9f2d7f0397f87cafd158710b8c208a5199b7e1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4e1514d57beadc0c4a373e20359cd1fd31997a34","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Neutron for extensions.  After this number of seconds the next time Nova"},{"line_number":74,"context_line":"needs to create a resource in Neutron it will requery Neutron for the"},{"line_number":75,"context_line":"extensions that it has loaded."},{"line_number":76,"context_line":"Setting value to 0 will disable the feature."},{"line_number":77,"context_line":"\"\"\"),"},{"line_number":78,"context_line":"]"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_e668248a","line":76,"updated":"2016-08-12 17:20:38.000000000","message":"Sorry, I just missed this, but this is not true, in this case.\n\nPlease see:\nhttps://github.com/openstack/nova/blob/71c007d9ed2150b329f258887b8b2e23f887d572/nova/network/neutronv2/api.py#L919","commit_id":"15155ccdac9e7bc7f2e698c0fc1b0d472d26fc32"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d1c90c4f21990d2708c621424b04f4bf979098","unresolved":false,"context_lines":[{"line_number":70,"context_line":"         min\u003d0,"},{"line_number":71,"context_line":"         help\u003d\"\"\""},{"line_number":72,"context_line":"Integer value representing the number of seconds to wait before querying"},{"line_number":73,"context_line":"Neutron for extensions.  After this number of seconds the next time Nova"},{"line_number":74,"context_line":"needs to create a resource in Neutron it will requery Neutron for the"},{"line_number":75,"context_line":"extensions that it has loaded.  Setting value to 0 will refresh the"},{"line_number":76,"context_line":"extensions with no wait."}],"source_content_type":"text/x-python","patch_set":14,"id":"3ac371cc_853cb930","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":25},"updated":"2016-08-15 15:01:53.000000000","message":"nit: Remove extra space(s)","commit_id":"d8dca9ed870b3222d92abf40025e415a61ef6cd6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4dc6c0c12f2b6181dc8b38dc13877f09b138cc01","unresolved":false,"context_lines":[{"line_number":70,"context_line":"         min\u003d0,"},{"line_number":71,"context_line":"         help\u003d\"\"\""},{"line_number":72,"context_line":"Integer value representing the number of seconds to wait before querying"},{"line_number":73,"context_line":"Neutron for extensions.  After this number of seconds the next time Nova"},{"line_number":74,"context_line":"needs to create a resource in Neutron it will requery Neutron for the"},{"line_number":75,"context_line":"extensions that it has loaded.  Setting value to 0 will refresh the"},{"line_number":76,"context_line":"extensions with no wait."}],"source_content_type":"text/x-python","patch_set":14,"id":"3ac371cc_4018e81d","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":25},"in_reply_to":"3ac371cc_853cb930","updated":"2016-08-15 16:44:15.000000000","message":"+1","commit_id":"d8dca9ed870b3222d92abf40025e415a61ef6cd6"}]}