)]}'
{"nova/conf/remote_debug.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a051c6a497798a5b88a031047049af731bca5820","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def register_cli_opts(conf):"},{"line_number":67,"context_line":"    conf.register_cli_opts(CLI_OPTS, group\u003ddebugger_group)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_59667a51","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":57},"updated":"2016-08-01 18:00:10.000000000","message":"you have to register group first.","commit_id":"00389afe359e0a0a8cec9e3fbbd82a43c797962e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"238c3952c5d698c2896b3984245931d1a6620e58","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    --remote_debug-host \u003cIP address where the debugger is running\u003e"},{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027port\u0027,"},{"line_number":43,"context_line":"               min\u003d1,"},{"line_number":44,"context_line":"               max\u003d65535,"},{"line_number":45,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c2fd4ab2","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":14},"updated":"2016-08-01 21:55:02.000000000","message":"Shouldn\u0027t this be PortOpt? then you can drop min and max from this","commit_id":"1ff0f1f00cff648fee43c78ee05d426a3d6ce572"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5857642dfa7f9f5b98d805ef97b924437ec948e0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"debugger_group \u003d cfg.OptGroup(\u0027remote_debug\u0027,"},{"line_number":20,"context_line":"    title\u003d\u0027debugger options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CLI_OPTS \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_43e6a044","line":20,"updated":"2016-08-05 14:02:18.000000000","message":"Nit: Really we should have help test for the group.","commit_id":"89e94d1976f649f0972459cc9ae364fc28f11400"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"85b809c5158c775e2af46d417c411736bcf7ec28","unresolved":false,"context_lines":[{"line_number":19,"context_line":"debugger_group \u003d cfg.OptGroup(\u0027remote_debug\u0027,"},{"line_number":20,"context_line":"    title\u003d\u0027debugger options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CLI_OPTS \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":24,"context_line":"               help\u003d\"\"\""},{"line_number":25,"context_line":"Debug host (IP or name) to connect to. This command line parameter is used when"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_ff706ea6","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":8},"updated":"2016-08-03 19:59:39.000000000","message":"nit: Why uppercase? We have been using lower case in all other patches, unless it is ALL_OPTS.","commit_id":"89e94d1976f649f0972459cc9ae364fc28f11400"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5857642dfa7f9f5b98d805ef97b924437ec948e0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"debugger_group \u003d cfg.OptGroup(\u0027remote_debug\u0027,"},{"line_number":20,"context_line":"    title\u003d\u0027debugger options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CLI_OPTS \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":24,"context_line":"               help\u003d\"\"\""},{"line_number":25,"context_line":"Debug host (IP or name) to connect to. This command line parameter is used when"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a3a67c0c","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":8},"in_reply_to":"bacf61ea_42c9e178","updated":"2016-08-05 14:02:18.000000000","message":"I am OK with CLI_OPTS here, we can tidy up these straggler bits later.","commit_id":"89e94d1976f649f0972459cc9ae364fc28f11400"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"ffb02c2f6fcd60f66b1606fb0c4ed53796b86645","unresolved":false,"context_lines":[{"line_number":19,"context_line":"debugger_group \u003d cfg.OptGroup(\u0027remote_debug\u0027,"},{"line_number":20,"context_line":"    title\u003d\u0027debugger options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CLI_OPTS \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":24,"context_line":"               help\u003d\"\"\""},{"line_number":25,"context_line":"Debug host (IP or name) to connect to. This command line parameter is used when"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_42c9e178","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":8},"in_reply_to":"bacf61ea_ff706ea6","updated":"2016-08-03 20:32:35.000000000","message":"Good point. But I find similar change.\nhttps://github.com/openstack/nova/blob/master/nova/conf/spice.py#L98\nhttps://github.com/openstack/nova/blob/master/nova/conf/vnc.py#L327\n\nPlease let me know if you have different suggestion.","commit_id":"89e94d1976f649f0972459cc9ae364fc28f11400"}]}