)]}'
{"nova/conf/rdp.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48ca8074ae0c0d4b9ee3e2cff53dc2e6376e63fa","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"rdp_group \u003d cfg.OptGroup(\u0027rdp\u0027, title\u003d\u0027RDP options\u0027)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"RDP_OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_6068faf5","line":18,"updated":"2016-08-05 13:59:33.000000000","message":"Nit: this should really include some help text.\n\nIts probably worth adding that the whole group is only relevant to Hyper-V users.","commit_id":"eaef1d4a871d1aecce4839cfa89d086bb10bc887"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1d056b7e2df5cd8a61394469ee240ab6595529a3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  The scheme must be identical to the scheme configured for the RDP HTML5"},{"line_number":71,"context_line":"  console proxy service."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  The IP address must be identical to the address on which the RDP HTML5 console"},{"line_number":74,"context_line":"  proxy service is listening."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  The port must be identical to the port on which the RDP HTML5 console proxy"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_9f6c1e9e","line":73,"updated":"2016-08-08 12:49:17.000000000","message":"./nova/conf/rdp.py:73:80: E501 line too long (80 \u003e 79 characters)","commit_id":"502b94c97af2ae04d82e65fb5c58e60e4a10e635"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"54bfcfee19e8de1e0d309b10d8be32f3b0c93051","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def register_opts(conf):"},{"line_number":88,"context_line":"    conf.register_group(rdp_group)"},{"line_number":89,"context_line":"    conf.register_opts(RDP_OPTS, rdp_group.name)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_bfa5a2b6","line":89,"updated":"2016-08-08 12:51:08.000000000","message":"We should just pass the group here.","commit_id":"70cf1831d55b1895cc1f2f111bb2dd6bd0413ed8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f3bf4da06e26d3e22e4493791e627fdfc4bab115","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \u0027rdp\u0027,"},{"line_number":20,"context_line":"    title\u003d\u0027RDP options\u0027,"},{"line_number":21,"context_line":"    help\u003d\"\"\""},{"line_number":22,"context_line":"Options under this group enable and configure Remote Desktop Protocol ("},{"line_number":23,"context_line":"RDP) related features."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This group is only relevant to Hyper-V users."}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_6d58ff8a","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":46},"updated":"2016-08-17 16:43:43.000000000","message":"Drop this - we know what options are for :)","commit_id":"8412c81e5b365115972225434e74f2688486194d"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"bd489b99c05106cb5e6281c59b84b66698d325fc","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Related options:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* ``compute_driver``: Must be hyperv."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\"\"\"),"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_f1ed8126","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":37},"updated":"2016-08-08 17:26:49.000000000","message":"Nit: I am inclined towards moving \"compute_driver\" and \"rdp.enabled\" related options to OptGroup","commit_id":"8412c81e5b365115972225434e74f2688486194d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ed1509446383e759a8b14b69c391d335cb4a309e","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\"\"\"),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":50,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"The URL an end user would use to connect to the RDP HTML5 console proxy."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_3f79b230","line":49,"updated":"2016-08-08 12:52:21.000000000","message":"Nit: URI Opt is better here.","commit_id":"8412c81e5b365115972225434e74f2688486194d"}]}