)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"e99533ba6a0227f9dfa473345c2d406fe96cdb08","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you create a flavor, you can set an is_public flag to be True or"},{"line_number":10,"context_line":"False.  It is True by default.  When False, the intention is that the"},{"line_number":11,"context_line":"flavor is only accessible by an admin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unfortunately, the only place in the code where this was being enforced"},{"line_number":14,"context_line":"was when listing flavors through the API.  It would filter out the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPn%2F%2FgVM%3D","line":11,"updated":"2013-06-28 22:16:18.000000000","message":"This is assuming that non-admin users are not allowed to create flavors, right?  If they are then is_public\u003dFalse should make a flavor accessible only to admins and the user that created it.  Maybe it\u0027s an unlikely enough use case to not worry about?","commit_id":"463f859556aaf4ddec054d0d828830ba75c9ef3a"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"cffa5d33b3b1e2b94a585355d60d2f80e49511e1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you create a flavor, you can set an is_public flag to be True or"},{"line_number":10,"context_line":"False.  It is True by default.  When False, the intention is that the"},{"line_number":11,"context_line":"flavor is only accessible by an admin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unfortunately, the only place in the code where this was being enforced"},{"line_number":14,"context_line":"was when listing flavors through the API.  It would filter out the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPn%2F%2Fcq0%3D","line":11,"in_reply_to":"AAAAPn%2F%2Fc1o%3D","updated":"2013-07-01 19:02:57.000000000","message":"Sure, and I\u0027m fine with this going in as-is.  I just wanted to raise the question because I could imagine a situation where someone might want to allow some users to create flavors without giving them full admin access.\n\nWhat I\u0027m hearing is we don\u0027t consider that a likely use case and we\u0027ll deal with it if/when it happens.  I guess I can live with that (and if I can\u0027t, I can always submit a change to handle it myself ;-).","commit_id":"463f859556aaf4ddec054d0d828830ba75c9ef3a"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"b1d0909ed5de2d1a58a58e53a2737922838d98d6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you create a flavor, you can set an is_public flag to be True or"},{"line_number":10,"context_line":"False.  It is True by default.  When False, the intention is that the"},{"line_number":11,"context_line":"flavor is only accessible by an admin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unfortunately, the only place in the code where this was being enforced"},{"line_number":14,"context_line":"was when listing flavors through the API.  It would filter out the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPn%2F%2Fc1o%3D","line":11,"in_reply_to":"AAAAPn%2F%2FgJY%3D","updated":"2013-07-01 17:58:50.000000000","message":"FWIW, this is policy driven and the default policy is that creating flavors is admin-only.","commit_id":"463f859556aaf4ddec054d0d828830ba75c9ef3a"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b466097f3784bc035208fd6490d1442e260923b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you create a flavor, you can set an is_public flag to be True or"},{"line_number":10,"context_line":"False.  It is True by default.  When False, the intention is that the"},{"line_number":11,"context_line":"flavor is only accessible by an admin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unfortunately, the only place in the code where this was being enforced"},{"line_number":14,"context_line":"was when listing flavors through the API.  It would filter out the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPn%2F%2FgJY%3D","line":11,"in_reply_to":"AAAAPn%2F%2FgVM%3D","updated":"2013-06-29 00:19:33.000000000","message":"Even if they can, I think this is a clear improvement.","commit_id":"463f859556aaf4ddec054d0d828830ba75c9ef3a"}],"nova/tests/db/test_db_api.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b466097f3784bc035208fd6490d1442e260923b9","unresolved":false,"context_lines":[{"line_number":2507,"context_line":""},{"line_number":2508,"context_line":"        inst_type_by_name \u003d db.instance_type_get_by_name(self.ctxt,"},{"line_number":2509,"context_line":"                                                         inst_type[\u0027name\u0027])"},{"line_number":2510,"context_line":"        self._assertEqualObjects(inst_type, inst_type_by_name)"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"        self.assertRaises(exception.InstanceTypeNotFoundByName,"},{"line_number":2513,"context_line":"                db.instance_type_get_by_name, self.user_ctxt,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgJU%3D","line":2510,"updated":"2013-06-29 00:19:33.000000000","message":"This looks like it really is three or maybe four separate tests. I think it would be clearer as separate test cases.","commit_id":"463f859556aaf4ddec054d0d828830ba75c9ef3a"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"b1d0909ed5de2d1a58a58e53a2737922838d98d6","unresolved":false,"context_lines":[{"line_number":2507,"context_line":""},{"line_number":2508,"context_line":"        inst_type_by_name \u003d db.instance_type_get_by_name(self.ctxt,"},{"line_number":2509,"context_line":"                                                         inst_type[\u0027name\u0027])"},{"line_number":2510,"context_line":"        self._assertEqualObjects(inst_type, inst_type_by_name)"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"        self.assertRaises(exception.InstanceTypeNotFoundByName,"},{"line_number":2513,"context_line":"                db.instance_type_get_by_name, self.user_ctxt,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fc1w%3D","line":2510,"in_reply_to":"AAAAPn%2F%2FgJU%3D","updated":"2013-07-01 17:58:50.000000000","message":"Ok, will do","commit_id":"463f859556aaf4ddec054d0d828830ba75c9ef3a"}]}