)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"654cea6853c32a652e3b74be50d37fbe1bdd132a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi NATSUME \u003cnatsume.takashi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-02 17:36:21 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api-ref: Fix \u0027id\u0027 (attachment_id) paramenters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027attachment_id_resp\u0027 in parameters.yaml is changed as \u0027required\u0027"},{"line_number":10,"context_line":"in order to fix \u0027id\u0027 paramenters in os-volume-attachments.inc."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_7d5ced18","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":45},"updated":"2016-08-02 08:43:21.000000000","message":"parameters","commit_id":"73a2eb491c65b0e688e85331119ad9e99a1cea5d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6c93bb2b20fd153e17a883e073ac2d82c78d744d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi NATSUME \u003cnatsume.takashi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-02 17:36:21 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api-ref: Fix \u0027id\u0027 (attachment_id) paramenters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027attachment_id_resp\u0027 in parameters.yaml is changed as \u0027required\u0027"},{"line_number":10,"context_line":"in order to fix \u0027id\u0027 paramenters in os-volume-attachments.inc."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_3dc8b554","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":45},"in_reply_to":"bacf61ea_7d5ced18","updated":"2016-08-02 08:49:37.000000000","message":"Done","commit_id":"73a2eb491c65b0e688e85331119ad9e99a1cea5d"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"cabb3c4daeee82a3083ed7918f3595f1ff8c93de","unresolved":false,"context_lines":[{"line_number":7,"context_line":"api-ref: Fix \u0027id\u0027 (attachment_id) parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027attachment_id_resp\u0027 in parameters.yaml is changed as \u0027required\u0027"},{"line_number":10,"context_line":"in order to fix \u0027id\u0027 paramenters in os-volume-attachments.inc."},{"line_number":11,"context_line":"The \u0027attachment_id_optional\u0027 is newly defined as \u0027Optional\u0027"},{"line_number":12,"context_line":"in parameters.yaml."},{"line_number":13,"context_line":"Replace \u0027attachment_id_resp\u0027 with \u0027attachment_id_optional\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a95cdbc_a558b933","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":32},"updated":"2016-10-06 13:54:54.000000000","message":"parameters","commit_id":"68a270aa4349b479786be9eff330ac2603b964bd"}],"api-ref/source/os-volumes.inc":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ab7afc4fdb4afedee81008265c9e04ac0feb9323","unresolved":false,"context_lines":[{"line_number":92,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  - volume: volume"},{"line_number":95,"context_line":"  - attachments: volumeAttachments"},{"line_number":96,"context_line":"  - attachments.device: attachment_device_resp"},{"line_number":97,"context_line":"  - attachments.id: attachment_id_optional"},{"line_number":98,"context_line":"  - attachments.serverId: attachment_server_id_resp"},{"line_number":99,"context_line":"  - attachments.volumeId: attachment_volumeId_resp"},{"line_number":100,"context_line":"  - availabilityZone: OS-EXT-AZ:availability_zone"},{"line_number":101,"context_line":"  - createdAt: created"},{"line_number":102,"context_line":"  - displayName: display_name"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"7a77a97e_214cba41","line":99,"range":{"start_line":95,"start_character":0,"end_line":99,"end_character":50},"updated":"2016-11-16 10:56:34.000000000","message":"Hang on a sec, I think this is getting confusing.\n\nA valid value is: attachments: []\n\nSo really they are all optional. When a volume is not attached to anything, there are no attachments.\n\nCurrently its totally crazy and we return the volume_id for every attachment id, so I don\u0027t see how we get one rather than the other:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/volumes.py#L226\n\nFor context, I am looking at the sample here:\nhttps://git.openstack.org/cgit/openstack/nova/tree/doc/api_samples/os-volumes/os-volumes-post-resp.json","commit_id":"95a11614c8a8fa79337927de0db10a0a3c9b7d51"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"476edf6db44f3aa3d03932d35c7ce8287ee09462","unresolved":false,"context_lines":[{"line_number":92,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  - volume: volume"},{"line_number":95,"context_line":"  - attachments: volumeAttachments"},{"line_number":96,"context_line":"  - attachments.device: attachment_device_resp"},{"line_number":97,"context_line":"  - attachments.id: attachment_id_optional"},{"line_number":98,"context_line":"  - attachments.serverId: attachment_server_id_resp"},{"line_number":99,"context_line":"  - attachments.volumeId: attachment_volumeId_resp"},{"line_number":100,"context_line":"  - availabilityZone: OS-EXT-AZ:availability_zone"},{"line_number":101,"context_line":"  - createdAt: created"},{"line_number":102,"context_line":"  - displayName: display_name"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"7a77a97e_51ad2c87","line":99,"range":{"start_line":95,"start_character":0,"end_line":99,"end_character":50},"in_reply_to":"7a77a97e_214cba41","updated":"2016-11-22 05:47:30.000000000","message":"IMO, current description is correct.\nIf there are attachments, they are required.\n\nSee another example.\n\nhttp://developer.openstack.org/api-ref/compute/?expanded\u003dlist-servers-detail#list-servers","commit_id":"95a11614c8a8fa79337927de0db10a0a3c9b7d51"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"847b75a54b13c3289bc69ef3a5865c76cd1570a9","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  - volume: volume"},{"line_number":182,"context_line":"  - attachments: volumeAttachments"},{"line_number":183,"context_line":"  - attachment.device: attachment_device_resp"},{"line_number":184,"context_line":"  - attachments.id: attachment_id_optional"},{"line_number":185,"context_line":"  - attachments.serverId: attachment_server_id_resp"},{"line_number":186,"context_line":"  - attachments.volumeId: attachment_volumeId_resp"},{"line_number":187,"context_line":"  - availabilityZone: OS-EXT-AZ:availability_zone"}],"source_content_type":"text/x-c++src","patch_set":21,"id":"3a71b18c_1ed26600","line":184,"updated":"2016-12-12 10:34:22.000000000","message":"So I am finding this hard to review, these are all the places we haven\u0027t changed. So I need to go find all the places that have \"changed\" I guess.","commit_id":"95a11614c8a8fa79337927de0db10a0a3c9b7d51"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"0494401d2de2dcc87d0fcee3559f4a5b65236d50","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"attachment_id_resp:"},{"line_number":1010,"context_line":"  description: |"},{"line_number":1011,"context_line":"    The UUID of the attachment."},{"line_number":1012,"context_line":"  in: body"},{"line_number":1013,"context_line":"  required: true"},{"line_number":1014,"context_line":"  type: string"},{"line_number":1015,"context_line":"attachment_server_id_resp:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a629dbe_6828c69a","line":1012,"updated":"2016-11-11 19:10:42.000000000","message":"Just wondering what is the difference between \u0027the attachment\u0027 and the attached volume?","commit_id":"5e84c0c4f6b709dd622616c22caadc8e9946ede7"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4f19d95ccef264ea7371b0dd8fe1725301a5aa57","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"attachment_id_resp:"},{"line_number":1010,"context_line":"  description: |"},{"line_number":1011,"context_line":"    The UUID of the attachment."},{"line_number":1012,"context_line":"  in: body"},{"line_number":1013,"context_line":"  required: true"},{"line_number":1014,"context_line":"  type: string"},{"line_number":1015,"context_line":"attachment_server_id_resp:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a629dbe_895c321a","line":1012,"in_reply_to":"9a629dbe_6828c69a","updated":"2016-11-12 05:34:13.000000000","message":"Emm...probably that means there is object which describe the relationship between instance volumes, that object is called attachment.\n\nMaybe we should say \u0027volume attachment\u0027 at here, to be clear this attachment is about volume.\n\nBut that can be addressed by another patch","commit_id":"5e84c0c4f6b709dd622616c22caadc8e9946ede7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"847b75a54b13c3289bc69ef3a5865c76cd1570a9","unresolved":false,"context_lines":[{"line_number":999,"context_line":"  description: |"},{"line_number":1000,"context_line":"    Name of the device in the attachment object, such as, ``/dev/vdb``."},{"line_number":1001,"context_line":"  in: body"},{"line_number":1002,"context_line":"  required: false"},{"line_number":1003,"context_line":"  type: string"},{"line_number":1004,"context_line":"attachment_id_optional:"},{"line_number":1005,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3a71b18c_deac6e8a","line":1002,"range":{"start_line":1002,"start_character":0,"end_line":1002,"end_character":17},"updated":"2016-12-12 10:34:22.000000000","message":"Having this false and line 1014 as true seems very in consistent to me.","commit_id":"95a11614c8a8fa79337927de0db10a0a3c9b7d51"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"847b75a54b13c3289bc69ef3a5865c76cd1570a9","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"  in: body"},{"line_number":1008,"context_line":"  required: false"},{"line_number":1009,"context_line":"  type: string"},{"line_number":1010,"context_line":"attachment_id_resp:"},{"line_number":1011,"context_line":"  description: |"},{"line_number":1012,"context_line":"    The UUID of the attachment."},{"line_number":1013,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3a71b18c_be941237","line":1010,"range":{"start_line":1010,"start_character":0,"end_line":1010,"end_character":18},"updated":"2016-12-12 10:34:22.000000000","message":"Oh, I know what confused me here.\n\nIf we call this attachment_id_required, and leave attachment_id_resp the same, then the change is clearer to me.","commit_id":"95a11614c8a8fa79337927de0db10a0a3c9b7d51"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c11440b850bf3ec1d1bab87033ab97eaf3051879","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"  in: body"},{"line_number":1008,"context_line":"  required: false"},{"line_number":1009,"context_line":"  type: string"},{"line_number":1010,"context_line":"attachment_id_resp:"},{"line_number":1011,"context_line":"  description: |"},{"line_number":1012,"context_line":"    The UUID of the attachment."},{"line_number":1013,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1a6eadb0_d31a356e","line":1010,"range":{"start_line":1010,"start_character":0,"end_line":1010,"end_character":18},"in_reply_to":"3a71b18c_be941237","updated":"2016-12-13 06:19:14.000000000","message":"Done","commit_id":"95a11614c8a8fa79337927de0db10a0a3c9b7d51"}]}