)]}'
{"nova/conf/xenserver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"683ed6c8e9e085177ceb46de29748c80a6508443","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cfg.IntOpt(\u0027agent_timeout\u0027,"},{"line_number":36,"context_line":"               default\u003d30,"},{"line_number":37,"context_line":"               help\u003d\"\"\""},{"line_number":38,"context_line":"               Number of seconds to wait for agent\u0027s reply to a request."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"               Nova configures/performs certain administrative actions on a"},{"line_number":41,"context_line":"               server with the help of an agent that\u0027s installed on the server."}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_9eae9283","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":15},"updated":"2016-08-09 17:15:33.000000000","message":"We need to kill all these kinds of things here.","commit_id":"9ce8255d5ee5b0d6f56ff4b0d740f07f4ee7a096"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2212139d29805bd62d56fa826c9dc081510a1985","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* ``agent_version_timeout``"},{"line_number":58,"context_line":"* ``agent_resetnetwork_timeout``"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.IntOpt(\u0027agent_version_timeout\u0027,"},{"line_number":62,"context_line":"               default\u003d300,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_46d2d035","line":59,"updated":"2016-08-12 17:35:27.000000000","message":"Nit: we don\u0027t need this extra space here.","commit_id":"9f427b2e6e938b27d0e056fecb48d46b4e9dc1ad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2212139d29805bd62d56fa826c9dc081510a1985","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                help\u003d\"\"\""},{"line_number":106,"context_line":"Disables the use of XenAPI agent."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"This configuration option suggests whether the use of agent should be enabled"},{"line_number":109,"context_line":"or not regardless of what image properties are present. Image properties have"},{"line_number":110,"context_line":"an effect only when this is set to ``True``. Read description of config option"},{"line_number":111,"context_line":"``use_agent_default`` for more information."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_062f38a2","line":110,"range":{"start_line":108,"start_character":0,"end_line":110,"end_character":44},"updated":"2016-08-12 17:35:27.000000000","message":"So thats all the wrong way around.\n\nWhen disable_agent\u003dTrue, all image properties are ignored, and the agent is never used. The default is to not disable the agent.","commit_id":"9f427b2e6e938b27d0e056fecb48d46b4e9dc1ad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2212139d29805bd62d56fa826c9dc081510a1985","unresolved":false,"context_lines":[{"line_number":215,"context_line":"The value for this option must be choosen from the choices listed"},{"line_number":216,"context_line":"here. Configuring a value other than these will default to \u0027all\u0027."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Note: There is nothing that deletes these images."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Possible values:"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_292a0d7f","line":218,"updated":"2016-08-12 17:35:27.000000000","message":"I think you need a rebase, as thats already been done in a dependent patch.","commit_id":"9f427b2e6e938b27d0e056fecb48d46b4e9dc1ad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2212139d29805bd62d56fa826c9dc081510a1985","unresolved":false,"context_lines":[{"line_number":435,"context_line":"* Any string that represents hostname/ip of Target."},{"line_number":436,"context_line":"* By default this option is not set."},{"line_number":437,"context_line":"\"\"\"),"},{"line_number":438,"context_line":"    cfg.PortOpt(\u0027target_port\u0027,"},{"line_number":439,"context_line":"               default\u003d3260,"},{"line_number":440,"context_line":"               help\u003d\"\"\""},{"line_number":441,"context_line":"The iSCSI Target Port."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_e930f5ea","line":438,"updated":"2016-08-12 17:35:27.000000000","message":"So apparently this is the change that breaks the unit tests, lets not make this change.\n\nA dependent patch adds a TODO in here now.","commit_id":"9f427b2e6e938b27d0e056fecb48d46b4e9dc1ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f66479ff195304da5985bb64af70882e3e3b92f3","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.IntOpt(\u0027agent_version_timeout\u0027,"},{"line_number":62,"context_line":"               default\u003d300,"},{"line_number":63,"context_line":"               min\u003d0,"},{"line_number":64,"context_line":"               help\u003d\"\"\""},{"line_number":65,"context_line":"Number of seconds to wait for agent\u0027t reply to version request."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This indicates the amount of time xapi \u0027agent\u0027 plugin waits for the agent to"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_6941dfa8","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":23},"updated":"2016-10-14 09:10:39.000000000","message":"Can you indent all these by eight spaces only, i.e. a hanging indent? This is what most other files are moving towards now","commit_id":"1094da245bb4a28bf8384c6a52226a29f6042fcf"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"fca2869cff5c073454deea194bbefefe860b9b59","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.IntOpt(\u0027agent_version_timeout\u0027,"},{"line_number":62,"context_line":"               default\u003d300,"},{"line_number":63,"context_line":"               min\u003d0,"},{"line_number":64,"context_line":"               help\u003d\"\"\""},{"line_number":65,"context_line":"Number of seconds to wait for agent\u0027t reply to version request."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This indicates the amount of time xapi \u0027agent\u0027 plugin waits for the agent to"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_08e1e5d0","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":23},"in_reply_to":"fa6399be_6941dfa8","updated":"2016-10-17 19:34:02.000000000","message":"Done.","commit_id":"1094da245bb4a28bf8384c6a52226a29f6042fcf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b219aac98c2731aa9b692b9b4cf0d902fcd140f4","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* ``agent_version_timeout``"},{"line_number":58,"context_line":"* ``agent_resetnetwork_timeout``"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.IntOpt(\u0027agent_version_timeout\u0027,"},{"line_number":62,"context_line":"        default\u003d300,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_15d583b8","line":59,"updated":"2016-11-04 11:33:34.000000000","message":"nit: you don\u0027t need this whitespace","commit_id":"cdc4a28c3fe87f7aa089b69c258daf7d89b659cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4b70a9e9f0cf33bea06135769828fb2150f009d3","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"xenapi_torrent_opts \u003d ["},{"line_number":161,"context_line":"    cfg.StrOpt(\u0027torrent_base_url\u0027,"},{"line_number":162,"context_line":"        help\u003d\"\"\""},{"line_number":163,"context_line":"Base URL for torrent files; must contain a slash character (see RFC 1808,"},{"line_number":164,"context_line":"step 6)."}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_cb2db9a9","line":161,"updated":"2016-11-25 14:39:52.000000000","message":"As a follow on thing, we should probably deprecate all this torrent stuff, as its not tested, and probably has never really been tested.","commit_id":"e7ce1ebefe57ba525ef575d42ef715a46ddd0abc"}]}