)]}'
{"nova/tests/unit/compute/test_tracker.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"e46a766b93350cf648806fb3aa3211dd7d2d50ba","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"        self.assertEqual(1, self.rt.compute_node.vcpus_used)"},{"line_number":1671,"context_line":"        self.assertEqual(1, self.rt.compute_node.local_gb_used)"},{"line_number":1672,"context_line":"        self.assertEqual(128, self.rt.compute_node.memory_mb_used)"},{"line_number":1673,"context_line":"        self.assertEqual(0, len(self.rt.tracked_migrations))"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"    @mock.patch(\u0027nova.pci.stats.PciDeviceStats.support_requests\u0027,"},{"line_number":1676,"context_line":"                return_value\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_4dfe3639","line":1673,"updated":"2016-08-09 16:29:56.000000000","message":"I know that using magic numbers like these is SOP in OpenStack tests, but they still confuse me. Why should rt.compute_node.local_gb_used be equal to 1? Oh, right. All you have to do is scroll up 73 lines to find where that value comes from.\n\nSince you\u0027re refactoring, it would be helpful to replace the use of magic numbers with variables like `orig_local_gb` or similar to make verifying these assertions clearer.","commit_id":"a04db0ff7c6922dfe3b7000673af7418592283f1"}]}
