)]}'
{"nova/virt/libvirt/vif.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"512c3c383266df980df1205c3b0331b576924c0e","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        conf.add_vport_param(\"interfaceid\","},{"line_number":475,"context_line":"                             profile.interface_id)"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def _set_config_VIFPortProfile8021Qbg(self, profile, conf):"},{"line_number":478,"context_line":"        conf.vporttype \u003d \"802.1Qbg\""},{"line_number":479,"context_line":"        conf.add_vport_param(\"managerid\","},{"line_number":480,"context_line":"                             profile.manager_id)"},{"line_number":481,"context_line":"        conf.add_vport_param(\"typeid\","},{"line_number":482,"context_line":"                             profile.type_id)"},{"line_number":483,"context_line":"        conf.add_vport_param(\"typeidversion\","},{"line_number":484,"context_line":"                             profile.type_id_version)"},{"line_number":485,"context_line":"        conf.add_vport_param(\"instanceid\","},{"line_number":486,"context_line":"                             profile.instance_id)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    def _set_config_VIFPortProfile8021Qbh(self, profile, conf):"},{"line_number":489,"context_line":"        conf.vporttype \u003d \"802.1Qbh\""},{"line_number":490,"context_line":"        conf.add_vport_param(\"profileid\","},{"line_number":491,"context_line":"                             profile.profile_id)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _set_config_VIFPortProfile(self, instance, vif, conf):"},{"line_number":494,"context_line":"        # Set any port profile that may be required"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_82b91918","line":491,"range":{"start_line":477,"start_character":0,"end_line":491,"end_character":48},"updated":"2016-08-03 20:40:02.000000000","message":"I\u0027m not sure why these are in this change when os_vif_util doesn\u0027t support them. I thought you said in the previous change that this was leftover from when the plugins were in os-vif, but now they aren\u0027t and aren\u0027t supported yet in os_vif_util so I\u0027m not sure why we\u0027re adding them in here when they won\u0027t be used? It will definitely slow down review here to just get base support with ovs and linuxbridge support. I could be missing something though.","commit_id":"577755ba94b89e8973b388469ab131315030fabe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"512c3c383266df980df1205c3b0331b576924c0e","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                {\u0027obj\u0027: vif.obj_name(), \u0027func\u0027: viffunc})"},{"line_number":524,"context_line":"        func(instance, vif, conf)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        # (vladikr) Not setting up driver and queues for vhostuser"},{"line_number":527,"context_line":"        # as queues are not supported in Libvirt until version 1.2.17"},{"line_number":528,"context_line":"        if (conf.net_type \u003d\u003d \"vhostuser\" and"},{"line_number":529,"context_line":"            not host.has_min_version(MIN_LIBVIRT_VHOSTUSER_MQ)):"},{"line_number":530,"context_line":"            LOG.debug(\u0027Queues are not a vhostuser supported feature.\u0027)"},{"line_number":531,"context_line":"            conf.driver_name \u003d None"},{"line_number":532,"context_line":"            conf.vhost_queues \u003d None"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":535,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_42d8c17f","line":532,"range":{"start_line":526,"start_character":0,"end_line":532,"end_character":36},"updated":"2016-08-03 20:40:02.000000000","message":"I brought this up before, but why are we adding support for these other things that aren\u0027t supported as types in the os_vif_util? Are these somehow built into the OVS plugin support?","commit_id":"577755ba94b89e8973b388469ab131315030fabe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5c67b3fe1aef92b6846542f1f64aef6ca443a0e","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        conf \u003d self.get_base_config(instance, vif, image_meta,"},{"line_number":217,"context_line":"                                    inst_type, virt_type)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        designer.set_vif_host_backend_ovs_config("},{"line_number":220,"context_line":"            conf, self.get_bridge_name(vif),"},{"line_number":221,"context_line":"            self.get_ovs_interfaceid(vif),"},{"line_number":222,"context_line":"            self.get_vif_devname(vif))"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_89df190c","side":"PARENT","line":222,"range":{"start_line":219,"start_character":8,"end_line":222,"end_character":38},"updated":"2016-08-05 15:04:01.000000000","message":"You can remove this method from designer as nothing else is using it now.","commit_id":"a8a0d89fdd7d8b85d64368747618bdf38199b9c3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cfd52b9c8f5d8c716367d650c128d3f408eed62a","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":427,"context_line":"        return conf"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _set_config_VIFBridge(self, instance, vif, conf):"},{"line_number":430,"context_line":"        conf.net_type \u003d \"bridge\""},{"line_number":431,"context_line":"        conf.source_dev \u003d vif.bridge_name"},{"line_number":432,"context_line":"        conf.target_dev \u003d vif.vif_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8976f9a1","line":429,"updated":"2016-08-05 14:35:05.000000000","message":"Why isn\u0027t bandwidth config set in here like in the old style get_config_bridge?\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/designer.py#L164","commit_id":"47a217a82c102183b2f2462049195d8b90c222ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"793685dc5befc49639ad05537398ee3a6e1f4ebe","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":427,"context_line":"        return conf"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _set_config_VIFBridge(self, instance, vif, conf):"},{"line_number":430,"context_line":"        conf.net_type \u003d \"bridge\""},{"line_number":431,"context_line":"        conf.source_dev \u003d vif.bridge_name"},{"line_number":432,"context_line":"        conf.target_dev \u003d vif.vif_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8984395e","line":429,"in_reply_to":"bacf61ea_8976f9a1","updated":"2016-08-05 14:36:42.000000000","message":"Oh I see it\u0027s done generically on line 483.","commit_id":"47a217a82c102183b2f2462049195d8b90c222ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5c67b3fe1aef92b6846542f1f64aef6ca443a0e","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                             profile.interface_id)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    def _set_config_VIFPortProfile(self, instance, vif, conf):"},{"line_number":451,"context_line":"        # Set any port profile that may be required"},{"line_number":452,"context_line":"        profilefunc \u003d \"_set_config_\" + vif.port_profile.obj_name()"},{"line_number":453,"context_line":"        func \u003d getattr(self, profilefunc, None)"},{"line_number":454,"context_line":"        if not func:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_29c26d53","line":451,"updated":"2016-08-05 15:04:01.000000000","message":"I guess it\u0027s not optional, since if the function doesn\u0027t exist, and it looks like _set_config_VIFPortProfileOpenVSwitch is what it\u0027d be given:\n\nhttps://review.openstack.org/#/c/269672/29/nova/network/os_vif_util.py@258\n\nThen we fail if not found.","commit_id":"47a217a82c102183b2f2462049195d8b90c222ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5c67b3fe1aef92b6846542f1f64aef6ca443a0e","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        func(vif.port_profile, conf)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def _get_config_os_vif(self, instance, vif, image_meta, inst_type,"},{"line_number":462,"context_line":"                           virt_type, host):"},{"line_number":463,"context_line":"        \"\"\"Get the domain config for a VIF"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_344800b3","line":461,"updated":"2016-08-05 15:04:01.000000000","message":"We should probably have a test for this for linuxbridge and ovs...","commit_id":"47a217a82c102183b2f2462049195d8b90c222ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5c67b3fe1aef92b6846542f1f64aef6ca443a0e","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                           virt_type, host):"},{"line_number":463,"context_line":"        \"\"\"Get the domain config for a VIF"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        :param vif: os_vif.objects.vif.VIFBase subclass"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        :returns: nova.virt.libvirt.config.LibvirtConfigGuestInterface"},{"line_number":468,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_b4a6b00c","line":465,"updated":"2016-08-05 15:04:01.000000000","message":"Would be nice to document the other parameters if you\u0027re going to document any.","commit_id":"47a217a82c102183b2f2462049195d8b90c222ac"}],"releasenotes/notes/libvirt-uses-os-vif-plugins-31a0617de0c248b9.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"512c3c383266df980df1205c3b0331b576924c0e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"     - forward_bridge_interface"},{"line_number":30,"context_line":"     - vlan_interface"},{"line_number":31,"context_line":"     - flat_interface"},{"line_number":32,"context_line":"     - netwrk_device_mtu"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Currently the plugins will fallback to looking for"},{"line_number":35,"context_line":"    these parameters in the \u0027[DEFAULT]\u0027 group, but this"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_22ddcd42","line":32,"range":{"start_line":32,"start_character":7,"end_line":32,"end_character":24},"updated":"2016-08-03 20:40:02.000000000","message":"typo: network_device_mtu","commit_id":"577755ba94b89e8973b388469ab131315030fabe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"512c3c383266df980df1205c3b0331b576924c0e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     - flat_interface"},{"line_number":32,"context_line":"     - netwrk_device_mtu"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Currently the plugins will fallback to looking for"},{"line_number":35,"context_line":"    these parameters in the \u0027[DEFAULT]\u0027 group, but this"},{"line_number":36,"context_line":"    backwards compatability support will be removed in a"},{"line_number":37,"context_line":"    future release."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_e2873510","line":37,"range":{"start_line":34,"start_character":4,"end_line":37,"end_character":19},"updated":"2016-08-03 20:40:02.000000000","message":"Do the plugins log a warning when doing the fallback lookup to the DEFAULT group? I guess they should because they are defined with deprecated_group\u003d\u0027DEFAULT\u0027. I\u0027ll look for it when we have a good CI run.","commit_id":"577755ba94b89e8973b388469ab131315030fabe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c56e1d9aafdd0366cc7b37fb08c3e651bdbe2070","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     - flat_interface"},{"line_number":32,"context_line":"     - network_device_mtu"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Currently the plugins will fallback to looking for"},{"line_number":35,"context_line":"    these parameters in the \u0027[DEFAULT]\u0027 group, but this"},{"line_number":36,"context_line":"    backwards compatability support will be removed in a"},{"line_number":37,"context_line":"    future release."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_f9033140","line":37,"range":{"start_line":34,"start_character":4,"end_line":37,"end_character":19},"updated":"2016-08-04 18:59:01.000000000","message":"I\u0027m testing this out here:\n\nhttps://review.openstack.org/#/c/351338/","commit_id":"47a217a82c102183b2f2462049195d8b90c222ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9e6219b5851617a18af4be56f560dfc0ede7f01e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     - flat_interface"},{"line_number":32,"context_line":"     - network_device_mtu"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Currently the plugins will fallback to looking for"},{"line_number":35,"context_line":"    these parameters in the \u0027[DEFAULT]\u0027 group, but this"},{"line_number":36,"context_line":"    backwards compatability support will be removed in a"},{"line_number":37,"context_line":"    future release."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_c63f3e85","line":37,"range":{"start_line":34,"start_character":4,"end_line":37,"end_character":19},"in_reply_to":"bacf61ea_f9033140","updated":"2016-08-05 14:19:31.000000000","message":"Verified:\n\nhttp://logs.openstack.org/38/351338/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/6d24fbb/logs/screen-n-cpu.txt.gz#_2016-08-05_02_40_52_489","commit_id":"47a217a82c102183b2f2462049195d8b90c222ac"}]}