)]}'
{"nova/tests/unit/test_policy.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b7cb06bbbd2e4c7e97a6fde63273d72d3703da0e","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        for rule in self.admin_only_rules:"},{"line_number":495,"context_line":"            self.assertRaises(exception.PolicyNotAuthorized, policy.authorize,"},{"line_number":496,"context_line":"                              self.non_admin_context, rule,"},{"line_number":497,"context_line":"                              {\u0027project_id\u0027: \u0027fake\u0027, \u0027user_id\u0027: \u0027fake\u0027})"},{"line_number":498,"context_line":"            policy.authorize(self.admin_context, rule, self.target)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def test_non_admin_only_rules(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_d9747669","line":497,"updated":"2016-08-10 12:58:43.000000000","message":"For other reviewers: self.target is set to {} which causes the policy check to fail for a reason unrelated to what\u0027s being tested here. Since the rule being checked here was \u0027is_admin:True or project_id:%(project_id)s\u0027 and target had no \u0027project_id\u0027 defined the policy check failed for that reason. That masked the fact that the rules being changed in this patch succeed with a proper target due to not being correctly defined.","commit_id":"16a38564cb61031466bf60ac393363bfeaedbd93"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"96bcdfe7ab2a45eeb828b396c1c03e94e52d3f1c","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        for rule in self.admin_only_rules:"},{"line_number":495,"context_line":"            self.assertRaises(exception.PolicyNotAuthorized, policy.authorize,"},{"line_number":496,"context_line":"                              self.non_admin_context, rule,"},{"line_number":497,"context_line":"                              {\u0027project_id\u0027: \u0027fake\u0027, \u0027user_id\u0027: \u0027fake\u0027})"},{"line_number":498,"context_line":"            policy.authorize(self.admin_context, rule, self.target)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def test_non_admin_only_rules(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_b9da62e6","line":497,"in_reply_to":"9ad45d7e_d9747669","updated":"2016-08-10 13:08:08.000000000","message":"Oh... ouch.","commit_id":"16a38564cb61031466bf60ac393363bfeaedbd93"}]}