)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"9a0271ad6e5eb88f89f89fca8d7544258c0f198b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Reduce code complexity to 25"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reduce code complexity to 25 from 35"},{"line_number":10,"context_line":"in pep8."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch contain also the reduced complexity"},{"line_number":13,"context_line":"codes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9ad45d7e_c6b0808e","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":8},"updated":"2016-08-08 19:14:19.000000000","message":"in tox.ini? (Also, you are reducing complexity in nova, not in pep8 :) )","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"9a0271ad6e5eb88f89f89fca8d7544258c0f198b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reduce code complexity to 25 from 35"},{"line_number":10,"context_line":"in pep8."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch contain also the reduced complexity"},{"line_number":13,"context_line":"codes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I2cb9bbc8ebac43135c1b318441f3a71f996d78f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9ad45d7e_866de806","line":12,"range":{"start_line":12,"start_character":17,"end_line":12,"end_character":18},"updated":"2016-08-08 19:14:19.000000000","message":"contains","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"7b345a8ba67f36b4cbffde99ddede452bffc80f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Szarka \u003cszarka@inf.u-szeged.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-24 13:36:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reduce code complexity to 25 (only in tox.ini)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reduce code complexity to 25 from 35 in pep8."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch not contain also the reduced complexity"},{"line_number":12,"context_line":"codes. For reduced complexity codes looks the depends."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1ac06dbe_6156e307","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":45},"updated":"2016-08-24 17:45:09.000000000","message":"I think you should change the title, something like \"Changed maximum complexity to 25 in tox.ini\"","commit_id":"f7a0ba2f490f26de88156403addd49bfb5b60ec8"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"7b345a8ba67f36b4cbffde99ddede452bffc80f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reduce code complexity to 25 from 35 in pep8."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch not contain also the reduced complexity"},{"line_number":12,"context_line":"codes. For reduced complexity codes looks the depends."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I292c13d603b6ab9f21297fbc067e5656dfde582e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1ac06dbe_c147d749","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":14},"updated":"2016-08-24 17:45:09.000000000","message":"does not","commit_id":"f7a0ba2f490f26de88156403addd49bfb5b60ec8"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"7b345a8ba67f36b4cbffde99ddede452bffc80f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reduce code complexity to 25 from 35 in pep8."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch not contain also the reduced complexity"},{"line_number":12,"context_line":"codes. For reduced complexity codes looks the depends."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I292c13d603b6ab9f21297fbc067e5656dfde582e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1ac06dbe_a1673be9","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":27},"updated":"2016-08-24 17:45:09.000000000","message":"shouldn\u0027t be there","commit_id":"f7a0ba2f490f26de88156403addd49bfb5b60ec8"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"7b345a8ba67f36b4cbffde99ddede452bffc80f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reduce code complexity to 25 from 35 in pep8."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch not contain also the reduced complexity"},{"line_number":12,"context_line":"codes. For reduced complexity codes looks the depends."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I292c13d603b6ab9f21297fbc067e5656dfde582e"},{"line_number":15,"context_line":"Depends-On: Ic44d0e17b72d3099d6a1eaf58120cc12a1c7c137"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1ac06dbe_41f767f5","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":41},"updated":"2016-08-24 17:45:09.000000000","message":", see","commit_id":"f7a0ba2f490f26de88156403addd49bfb5b60ec8"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"7b345a8ba67f36b4cbffde99ddede452bffc80f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reduce code complexity to 25 from 35 in pep8."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch not contain also the reduced complexity"},{"line_number":12,"context_line":"codes. For reduced complexity codes looks the depends."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I292c13d603b6ab9f21297fbc067e5656dfde582e"},{"line_number":15,"context_line":"Depends-On: Ic44d0e17b72d3099d6a1eaf58120cc12a1c7c137"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1ac06dbe_e1e65343","line":12,"range":{"start_line":12,"start_character":46,"end_line":12,"end_character":53},"updated":"2016-08-24 17:45:09.000000000","message":"dependencies","commit_id":"f7a0ba2f490f26de88156403addd49bfb5b60ec8"}],"nova/compute/manager.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"9a0271ad6e5eb88f89f89fca8d7544258c0f198b","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"    def _resume_delete_instance(self, context, instance):"},{"line_number":1002,"context_line":"        try:"},{"line_number":1003,"context_line":"            LOG.info(_LI(\u0027Service started deleting the instance during \u0027"},{"line_number":1004,"context_line":"                         \u0027the previous run, but did not finish. Restarting\u0027"},{"line_number":1005,"context_line":"                         \u0027 the deletion now.\u0027), instance\u003dinstance)"},{"line_number":1006,"context_line":"            instance.obj_load_attr(\u0027metadata\u0027)"},{"line_number":1007,"context_line":"            instance.obj_load_attr(\u0027system_metadata\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_06a0d89e","line":1004,"range":{"start_line":1004,"start_character":74,"end_line":1004,"end_character":75},"updated":"2016-08-08 19:14:19.000000000","message":"You should consequently put spaces in the code. I think you should put a space here, and remove it from the next line (it looks so ugly).","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"a7b2031b57fe07d179be959d259ea1a3315a47e6","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"    def _resume_delete_instance(self, context, instance):"},{"line_number":1002,"context_line":"        try:"},{"line_number":1003,"context_line":"            LOG.info(_LI(\u0027Service started deleting the instance during \u0027"},{"line_number":1004,"context_line":"                         \u0027the previous run, but did not finish. Restarting\u0027"},{"line_number":1005,"context_line":"                         \u0027 the deletion now.\u0027), instance\u003dinstance)"},{"line_number":1006,"context_line":"            instance.obj_load_attr(\u0027metadata\u0027)"},{"line_number":1007,"context_line":"            instance.obj_load_attr(\u0027system_metadata\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_ac09eb33","line":1004,"range":{"start_line":1004,"start_character":74,"end_line":1004,"end_character":75},"in_reply_to":"9ad45d7e_06a0d89e","updated":"2016-08-08 20:02:26.000000000","message":"Ok, i will fix it.","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d346f268bcf04d3264ec0b80410446e80a27c940","unresolved":false,"context_lines":[{"line_number":2147,"context_line":"                query_prefix \u003d query_prefix.filter(not_soft_deleted)"},{"line_number":2148,"context_line":""},{"line_number":2149,"context_line":"    if \u0027cleaned\u0027 in filters:"},{"line_number":2150,"context_line":"        filters_pop_bool \u003d models.Instance.cleaned \u003d\u003d 1 \\"},{"line_number":2151,"context_line":"            if filters.pop(\u0027cleaned\u0027) else models.Instance.cleaned \u003d\u003d 0"},{"line_number":2152,"context_line":"        query_prefix \u003d query_prefix.filter(filters_pop_bool)"},{"line_number":2153,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_ae96983b","line":2150,"range":{"start_line":2150,"start_character":56,"end_line":2150,"end_character":57},"updated":"2016-08-04 16:25:44.000000000","message":"I am on a crusade against unnecessary backslash continuations.  This backslash can be eliminated by surrounding the RHS of the assignment in parentheses.","commit_id":"8da259ef74f86c0f02322688e1e9abb34e6ddeb2"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a9de0365aea492f5200b16a50762e043d61d6ad4","unresolved":false,"context_lines":[{"line_number":2153,"context_line":"            filters.pop(\u0027cleaned\u0027)"},{"line_number":2154,"context_line":"                ) else ("},{"line_number":2155,"context_line":"            models.Instance.cleaned \u003d\u003d 0"},{"line_number":2156,"context_line":"                )"},{"line_number":2157,"context_line":"        query_prefix \u003d query_prefix.filter(filters_pop_bool)"},{"line_number":2158,"context_line":""},{"line_number":2159,"context_line":"    if \u0027tags\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8a90dd44","line":2156,"updated":"2016-08-04 17:12:36.000000000","message":"That just seems a bit more ugly than before.  Try the following:\n\n    filters_pop_bool \u003d (models.Instance.cleaned \u003d\u003d 1\n                        if filters.pop(\u0027cleaned\u0027) else\n                        models.Instance.cleaned \u003d\u003d 0)","commit_id":"7f3470df3c646d667d0f9ea8f8263cbc61fe437a"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"9a0271ad6e5eb88f89f89fca8d7544258c0f198b","unresolved":false,"context_lines":[{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"    if \u0027cleaned\u0027 in filters:"},{"line_number":2136,"context_line":"        mic \u003d models.Instance.cleaned"},{"line_number":2137,"context_line":"        filters_pop_bool \u003d mic \u003d\u003d 1 if filters.pop(\u0027cleaned\u0027) else mic \u003d\u003d 0"},{"line_number":2138,"context_line":"        query_prefix \u003d query_prefix.filter(filters_pop_bool)"},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"    if \u0027tags\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_a6ce2c58","line":2137,"range":{"start_line":2137,"start_character":27,"end_line":2137,"end_character":75},"updated":"2016-08-08 19:14:19.000000000","message":"Maybe you should put paranthesis here, but might be just me who wants it.","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"a7b2031b57fe07d179be959d259ea1a3315a47e6","unresolved":false,"context_lines":[{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"    if \u0027cleaned\u0027 in filters:"},{"line_number":2136,"context_line":"        mic \u003d models.Instance.cleaned"},{"line_number":2137,"context_line":"        filters_pop_bool \u003d mic \u003d\u003d 1 if filters.pop(\u0027cleaned\u0027) else mic \u003d\u003d 0"},{"line_number":2138,"context_line":"        query_prefix \u003d query_prefix.filter(filters_pop_bool)"},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"    if \u0027tags\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_2c1dfb73","line":2137,"range":{"start_line":2137,"start_character":27,"end_line":2137,"end_character":75},"in_reply_to":"9ad45d7e_a6ce2c58","updated":"2016-08-08 20:02:26.000000000","message":"I will fix it","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f9b8be01a0af7bee4481775e1cd5827a28b2309b","unresolved":false,"context_lines":[{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"    if \u0027cleaned\u0027 in filters:"},{"line_number":2136,"context_line":"        mic \u003d models.Instance.cleaned"},{"line_number":2137,"context_line":"        filters_pop_bool \u003d (mic \u003d\u003d 1 if filters.pop(\u0027cleaned\u0027) else mic \u003d\u003d 0)"},{"line_number":2138,"context_line":"        query_prefix \u003d query_prefix.filter(filters_pop_bool)"},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"    if \u0027tags\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ac06dbe_ef006868","line":2137,"range":{"start_line":2137,"start_character":8,"end_line":2137,"end_character":77},"updated":"2016-08-23 12:17:13.000000000","message":"Parentheses are redundant. Besides, IHMO removing this if..else construct in favor of oneliner ..if...else... is less readable.\n\nThis construct can be however changed like:\n\n  clean_filter \u003d 1 if filters.pop(\u0027cleaned\u0027) else 0\n  query_prefix \u003d query_prefix.filter(models.Instance.cleaned \u003d\u003d clean_filter)","commit_id":"035ad454d0fe9d9d72ee8e77d6eae7b4ac5f3dc2"}],"nova/network/linux_net.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f9b8be01a0af7bee4481775e1cd5827a28b2309b","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        end \u003d lines[start:].index(\u0027COMMIT\u0027) + start + 2"},{"line_number":388,"context_line":"        return (start, end)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def _modify_rules_get_filter(self, flag, new_filter):"},{"line_number":391,"context_line":"        if flag:"},{"line_number":392,"context_line":"            regex \u003d re.compile(flag)"},{"line_number":393,"context_line":"            temp_filter \u003d [line for line in new_filter if regex.search(line)]"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ac06dbe_0ab21206","line":390,"range":{"start_line":390,"start_character":39,"end_line":390,"end_character":44},"updated":"2016-08-23 12:17:13.000000000","message":"Actually, this is pattern, which happen to be in config, right?","commit_id":"035ad454d0fe9d9d72ee8e77d6eae7b4ac5f3dc2"}],"nova/objects/instance.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d346f268bcf04d3264ec0b80410446e80a27c940","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            if not instance.obj_attr_is_set(\u0027info_cache\u0027):"},{"line_number":333,"context_line":"                # TODO(danms): If this ever happens on a backlevel instance"},{"line_number":334,"context_line":"                # passed to us by a backlevel service, things will break"},{"line_number":335,"context_line":"                instance.info_cache \u003d \\"},{"line_number":336,"context_line":"                    objects.InstanceInfoCache(context).from_db_object(context,"},{"line_number":337,"context_line":"                        instance.info_cache, db_inst[\u0027info_cache\u0027])"},{"line_number":338,"context_line":"        if any([x in expected_attrs for x in ("}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_2e4748bd","line":335,"range":{"start_line":335,"start_character":38,"end_line":335,"end_character":39},"updated":"2016-08-04 16:25:44.000000000","message":"The backslash continuation can be eliminated using parentheses:\n\n    instance.info_cache \u003d (\n        objects.InstanceInfoCache(context).from_db_object(\n            context, instance.info_cache, db_inst[\u0027info_cache\u0027])\n    )","commit_id":"8da259ef74f86c0f02322688e1e9abb34e6ddeb2"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d346f268bcf04d3264ec0b80410446e80a27c940","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                    objects.InstanceInfoCache(context).from_db_object(context,"},{"line_number":337,"context_line":"                        instance.info_cache, db_inst[\u0027info_cache\u0027])"},{"line_number":338,"context_line":"        if any([x in expected_attrs for x in ("},{"line_number":339,"context_line":"                \u0027flavor\u0027, \u0027old_flavor\u0027, \u0027new_flavor\u0027)]) \\"},{"line_number":340,"context_line":"                and (have_extra and db_inst[\u0027extra\u0027].get(\u0027flavor\u0027)):"},{"line_number":341,"context_line":"                instance._flavor_from_db(db_inst[\u0027extra\u0027][\u0027flavor\u0027])"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_4905560f","line":339,"range":{"start_line":339,"start_character":56,"end_line":339,"end_character":57},"updated":"2016-08-04 16:25:44.000000000","message":"1. The backslash continuation can be eliminated.\n2. It is difficult to distinguish the \"then\" clause from the condition due to the indentation.  Try:\n\n    if (any([x in expected_attrs for x in (\n             \u0027flavor\u0027, \u0027old_flavor\u0027, \u0027new_flavor\u0027)]) and\n            have_extra and db_inst[\u0027extra\u0027].get(\u0027flavor\u0027)):\n        instance._flavor_from_db(db_inst[\u0027extra\u0027][\u0027flavor\u0027])\n\n(Note the elimination of the parentheses around the \"have_extra and db_inst[\u0027extra\u0027].get(\u0027flavor\u0027)\" clause; there\u0027s no reason to parenthesize that clause, as all the operators in the condition are \u0027and\u0027 operators.)","commit_id":"8da259ef74f86c0f02322688e1e9abb34e6ddeb2"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a9de0365aea492f5200b16a50762e043d61d6ad4","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                )"},{"line_number":339,"context_line":"        if any([x in expected_attrs for x in ("},{"line_number":340,"context_line":"                \u0027flavor\u0027, \u0027old_flavor\u0027, \u0027new_flavor\u0027)]"},{"line_number":341,"context_line":"               ) and (have_extra and db_inst[\u0027extra\u0027].get(\u0027flavor\u0027)):"},{"line_number":342,"context_line":"                instance._flavor_from_db(db_inst[\u0027extra\u0027][\u0027flavor\u0027])"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8ade1d0f","line":341,"updated":"2016-08-04 17:12:36.000000000","message":"That\u0027ll do, I suppose…","commit_id":"7f3470df3c646d667d0f9ea8f8263cbc61fe437a"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"9a0271ad6e5eb88f89f89fca8d7544258c0f198b","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        if (self.obj_attr_is_set(field) and"},{"line_number":608,"context_line":"                isinstance(self.fields[field], fields.ObjectField)):"},{"line_number":609,"context_line":"            try:"},{"line_number":610,"context_line":"                getattr(self, \u0027_save_%s\u0027 % field)(context)"},{"line_number":611,"context_line":"            except AttributeError:"},{"line_number":612,"context_line":"                if field in _INSTANCE_EXTRA_FIELDS:"},{"line_number":613,"context_line":"                    self._save_extra_generic(field)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_467930fc","line":610,"range":{"start_line":610,"start_character":16,"end_line":610,"end_character":58},"updated":"2016-08-08 19:14:19.000000000","message":"this one looks weird","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"a7b2031b57fe07d179be959d259ea1a3315a47e6","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        if (self.obj_attr_is_set(field) and"},{"line_number":608,"context_line":"                isinstance(self.fields[field], fields.ObjectField)):"},{"line_number":609,"context_line":"            try:"},{"line_number":610,"context_line":"                getattr(self, \u0027_save_%s\u0027 % field)(context)"},{"line_number":611,"context_line":"            except AttributeError:"},{"line_number":612,"context_line":"                if field in _INSTANCE_EXTRA_FIELDS:"},{"line_number":613,"context_line":"                    self._save_extra_generic(field)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_ac228bb7","line":610,"range":{"start_line":610,"start_character":16,"end_line":610,"end_character":58},"in_reply_to":"9ad45d7e_467930fc","updated":"2016-08-08 20:02:26.000000000","message":"i know, but that\u0027s good (as original code)","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"9a0271ad6e5eb88f89f89fca8d7544258c0f198b","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                context, field, changes"},{"line_number":690,"context_line":"            )"},{"line_number":691,"context_line":"            if not caller_succ:"},{"line_number":692,"context_line":"                updates[field] \u003d caller_succ"},{"line_number":693,"context_line":"            else:"},{"line_number":694,"context_line":"                continue"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_c689a0cc","line":692,"range":{"start_line":692,"start_character":33,"end_line":692,"end_character":44},"updated":"2016-08-08 19:14:19.000000000","message":"Shouldn\u0027t we know the value of it?","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"a7b2031b57fe07d179be959d259ea1a3315a47e6","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                context, field, changes"},{"line_number":690,"context_line":"            )"},{"line_number":691,"context_line":"            if not caller_succ:"},{"line_number":692,"context_line":"                updates[field] \u003d caller_succ"},{"line_number":693,"context_line":"            else:"},{"line_number":694,"context_line":"                continue"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_acad6b33","line":692,"range":{"start_line":692,"start_character":33,"end_line":692,"end_character":44},"in_reply_to":"9ad45d7e_c689a0cc","updated":"2016-08-08 20:02:26.000000000","message":"No. The method, return False or data. If return with no false, then have value -\u003e we copy to updates[field] the caller_succ value.","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f9b8be01a0af7bee4481775e1cd5827a28b2309b","unresolved":false,"context_lines":[{"line_number":814,"context_line":"        return dev"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def _get_data(self, element_name):"},{"line_number":817,"context_line":"        element \u003d etree.Element(element_name)"},{"line_number":818,"context_line":"        if element_name \u003d\u003d \u0027iotune\u0027:"},{"line_number":819,"context_line":"            if self.disk_read_bytes_sec is not None:"},{"line_number":820,"context_line":"                element.append(self._text_node(\"read_bytes_sec\","},{"line_number":821,"context_line":"                    self.disk_read_bytes_sec))"},{"line_number":822,"context_line":"            if self.disk_read_iops_sec is not None:"},{"line_number":823,"context_line":"                element.append(self._text_node(\"read_iops_sec\","},{"line_number":824,"context_line":"                    self.disk_read_iops_sec))"},{"line_number":825,"context_line":"            if self.disk_write_bytes_sec is not None:"},{"line_number":826,"context_line":"                element.append(self._text_node(\"write_bytes_sec\","},{"line_number":827,"context_line":"                    self.disk_write_bytes_sec))"},{"line_number":828,"context_line":"            if self.disk_write_iops_sec is not None:"},{"line_number":829,"context_line":"                element.append(self._text_node(\"write_iops_sec\","},{"line_number":830,"context_line":"                    self.disk_write_iops_sec))"},{"line_number":831,"context_line":"            if self.disk_total_bytes_sec is not None:"},{"line_number":832,"context_line":"                element.append(self._text_node(\"total_bytes_sec\","},{"line_number":833,"context_line":"                    self.disk_total_bytes_sec))"},{"line_number":834,"context_line":"            if self.disk_total_iops_sec is not None:"},{"line_number":835,"context_line":"                element.append(self._text_node(\"total_iops_sec\","},{"line_number":836,"context_line":"                    self.disk_total_iops_sec))"},{"line_number":837,"context_line":"        elif element_name \u003d\u003d \u0027driver\u0027:"},{"line_number":838,"context_line":"            if self.driver_name is not None:"},{"line_number":839,"context_line":"                element.set(\"name\", self.driver_name)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ac06dbe_6cf12101","line":836,"range":{"start_line":817,"start_character":8,"end_line":836,"end_character":46},"updated":"2016-08-23 12:17:13.000000000","message":"I wonder if this can be simplified, like:\n\n    iotune \u003d ((self.disk_read_bytes_sec, \"read_bytes_sec\"),\n              (self.disk_read_iops_sec, \"read_iops_sec\"),\n              (self.disk_write_bytes_sec, \"write_bytes_sec\"),\n              (self.disk_write_iops_sec, \"write_iops_sec\"),\n              (self.disk_total_bytes_sec, \"total_bytes_sec\"),\n              (self.disk_total_iops_sec, \"total_iops_sec\"))\n\n    if element_name \u003d\u003d \u0027iotune\u0027:\n        for iotune, text_node in iotune:\n            if iotune is not None:\n                element.append(self._text_node(text_node, iotune)","commit_id":"035ad454d0fe9d9d72ee8e77d6eae7b4ac5f3dc2"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f9b8be01a0af7bee4481775e1cd5827a28b2309b","unresolved":false,"context_lines":[{"line_number":834,"context_line":"            if self.disk_total_iops_sec is not None:"},{"line_number":835,"context_line":"                element.append(self._text_node(\"total_iops_sec\","},{"line_number":836,"context_line":"                    self.disk_total_iops_sec))"},{"line_number":837,"context_line":"        elif element_name \u003d\u003d \u0027driver\u0027:"},{"line_number":838,"context_line":"            if self.driver_name is not None:"},{"line_number":839,"context_line":"                element.set(\"name\", self.driver_name)"},{"line_number":840,"context_line":"            if self.driver_format is not None:"},{"line_number":841,"context_line":"                element.set(\"type\", self.driver_format)"},{"line_number":842,"context_line":"            if self.driver_cache is not None:"},{"line_number":843,"context_line":"                element.set(\"cache\", self.driver_cache)"},{"line_number":844,"context_line":"            if self.driver_discard is not None:"},{"line_number":845,"context_line":"                element.set(\"discard\", self.driver_discard)"},{"line_number":846,"context_line":"            if self.driver_io is not None:"},{"line_number":847,"context_line":"                element.set(\"io\", self.driver_io)"},{"line_number":848,"context_line":"        elif element_name \u003d\u003d \u0027blockio\u0027:"},{"line_number":849,"context_line":"            if self.logical_block_size is not None:"},{"line_number":850,"context_line":"                element.set(\u0027logical_block_size\u0027, self.logical_block_size)"},{"line_number":851,"context_line":"            if self.physical_block_size is not None:"},{"line_number":852,"context_line":"                element.set(\u0027physical_block_size\u0027, self.physical_block_size)"},{"line_number":853,"context_line":"        return element"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":856,"context_line":"        super(LibvirtConfigGuestDisk, self).parse_dom(xmldoc)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ac06dbe_8cc3bd88","line":853,"range":{"start_line":837,"start_character":0,"end_line":853,"end_character":22},"updated":"2016-08-23 12:17:13.000000000","message":"ditto","commit_id":"035ad454d0fe9d9d72ee8e77d6eae7b4ac5f3dc2"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f9b8be01a0af7bee4481775e1cd5827a28b2309b","unresolved":false,"context_lines":[{"line_number":2028,"context_line":"        utils.execute(\"qemu-img\", \"rebase\", \"-b\", backing_file,"},{"line_number":2029,"context_line":"                      *qemu_img_extra_arg)"},{"line_number":2030,"context_line":""},{"line_number":2031,"context_line":"    def _volume_snapshot_raise_exceptions(self, gcow\u003dNone, get_guest\u003dNone,"},{"line_number":2032,"context_line":"                                          notfound\u003dNone):"},{"line_number":2033,"context_line":"        if gcow is not None:"},{"line_number":2034,"context_line":"            if gcow !\u003d \u0027qcow2\u0027:"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ac06dbe_4c854505","line":2031,"range":{"start_line":2031,"start_character":8,"end_line":2031,"end_character":41},"updated":"2016-08-23 12:17:13.000000000","message":"Name suggests, that we will always raise an exception, but it not always do that.","commit_id":"035ad454d0fe9d9d72ee8e77d6eae7b4ac5f3dc2"}],"tox.ini":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"9a0271ad6e5eb88f89f89fca8d7544258c0f198b","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"ignore \u003d E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405"},{"line_number":117,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,tools/xenserver*,releasenotes"},{"line_number":118,"context_line":"max-complexity\u003d25"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"[hacking]"},{"line_number":121,"context_line":"local-check-factory \u003d nova.hacking.checks.factory"}],"source_content_type":"text/x-properties","patch_set":10,"id":"9ad45d7e_a6f62cd5","line":118,"range":{"start_line":118,"start_character":15,"end_line":118,"end_character":17},"updated":"2016-08-08 19:14:19.000000000","message":"I think you should keep this for now (so we can check if everything is ok with pep8), and reduce this only when you are finished the refactorings","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"a7b2031b57fe07d179be959d259ea1a3315a47e6","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"ignore \u003d E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405"},{"line_number":117,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,tools/xenserver*,releasenotes"},{"line_number":118,"context_line":"max-complexity\u003d25"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"[hacking]"},{"line_number":121,"context_line":"local-check-factory \u003d nova.hacking.checks.factory"}],"source_content_type":"text/x-properties","patch_set":10,"id":"9ad45d7e_8c5a2782","line":118,"range":{"start_line":118,"start_character":15,"end_line":118,"end_character":17},"in_reply_to":"9ad45d7e_a6f62cd5","updated":"2016-08-08 20:02:26.000000000","message":"You\u0027re wrong, this patch (if be done) contain all modification, which require to complexity 25. If now change complexity to 25, the Jenkins and the other gate tester use this setting to tests. If all code reduction be done, then will give +1 the Jenkins for pep8","commit_id":"5f948fd836c7b1b12d0e381f41284bbee0e779a6"}]}