)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"9f99699b81caf53d3b2b5a17d750120cf26e83b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: Deprecate CONF.conductor.topic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is no need to let users choose the RPC topic for all our"},{"line_number":10,"context_line":"difference services. Its best to deprecate and remove these options as"},{"line_number":11,"context_line":"its really easy to break nova by using these options, and there is"},{"line_number":12,"context_line":"little gain for deployers in changing this option."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_f882a8fd","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":24},"updated":"2016-08-08 07:26:04.000000000","message":"It\u0027s","commit_id":"78a926c07f913f9de68f319cd82bfb9feb6fb2e3"},{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"9f99699b81caf53d3b2b5a17d750120cf26e83b2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is no need to let users choose the RPC topic for all our"},{"line_number":10,"context_line":"difference services. Its best to deprecate and remove these options as"},{"line_number":11,"context_line":"its really easy to break nova by using these options, and there is"},{"line_number":12,"context_line":"little gain for deployers in changing this option."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TODO - consider deprecating all the topic options in a single commit and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_3879e02f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":3},"updated":"2016-08-08 07:26:04.000000000","message":"it\u0027s","commit_id":"78a926c07f913f9de68f319cd82bfb9feb6fb2e3"}],"nova/conf/cells.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8433b2089f7e3962c75f3b3540aef7724feb527","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\"\"\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027topic\u0027,"},{"line_number":50,"context_line":"                default\u003d\u0027cells\u0027,"},{"line_number":51,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":52,"context_line":"                deprecated_reason\u003d\"\"\""},{"line_number":53,"context_line":"There is no need to let users choose the RPC topic for all services - there"},{"line_number":54,"context_line":"is little gain from this. Furthermore, it makes it really easy to break Nova"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_dfabc51c","line":51,"updated":"2016-09-12 12:19:13.000000000","message":"Could you include a \u0027deprecated_since\u0027 parameter here, since they\u0027re supported now.","commit_id":"0335e28ee25d86a8382e8a32c905046073b7881f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8433b2089f7e3962c75f3b3540aef7724feb527","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                default\u003d\u0027cells\u0027,"},{"line_number":51,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":52,"context_line":"                deprecated_reason\u003d\"\"\""},{"line_number":53,"context_line":"There is no need to let users choose the RPC topic for all services - there"},{"line_number":54,"context_line":"is little gain from this. Furthermore, it makes it really easy to break Nova"},{"line_number":55,"context_line":"by using this option."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Removal may be as early as 15.0."},{"line_number":58,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_df07451b","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":21},"updated":"2016-09-12 12:19:13.000000000","message":"Can I suggest something briefer?\n\n    Configurable RPC topics provide little value and can result\n    in a wide variety of errors. They should not be used.","commit_id":"0335e28ee25d86a8382e8a32c905046073b7881f"}],"nova/conf/conductor.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"eb0a6516c767c50693e81376cb361ff89aa60792","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright (c) 2010 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_cb0de991","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"updated":"2016-08-09 18:49:14.000000000","message":"Take this tag out.","commit_id":"820cabc51e667d6016df324e6cb91bf4bc55fe75"}],"nova/conf/consoleauth.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"04c14ca8fc5ac31290aa047977412f88ab51e80b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Removal may be as early as 15.0."},{"line_number":36,"context_line":"\"\"\","},{"line_number":37,"context_line":"    help\u003d\"\"\""},{"line_number":38,"context_line":"This option allows you to change the message topic used by nova-consoleauth"},{"line_number":39,"context_line":"service when communicating via the AMQP server. Nova Console Authentication"},{"line_number":40,"context_line":"server authenticates nova consoles. Users can then access their instances"},{"line_number":41,"context_line":"through VNC clients. The Nova API service uses a message queue to"},{"line_number":42,"context_line":"communicate with nova-consoleauth to get a VNC console."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Possible Values:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  * \u0027consoleauth\u0027 (default) or Any string representing topic exchange name."},{"line_number":47,"context_line":"\"\"\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"console_token_ttl \u003d cfg.IntOpt(\u0027console_token_ttl\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_80094098","line":46,"range":{"start_line":38,"start_character":0,"end_line":46,"end_character":75},"updated":"2016-08-15 16:51:26.000000000","message":"Nit: tempting to make the help text consistent, could do that in a follow up.","commit_id":"ded7d4c63233be32e0caa9e7ca3da89fe9c53e3b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8433b2089f7e3962c75f3b3540aef7724feb527","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright (c) 2016 Intel, Inc."},{"line_number":9,"context_line":"# Copyright (c) 2013 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_9a0ceb3c","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":0},"updated":"2016-09-12 12:19:13.000000000","message":"Is this supposed to be added?","commit_id":"0335e28ee25d86a8382e8a32c905046073b7881f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"d0ce6f0eca6b737162eb8a3c9063324b4dd88cc2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright (c) 2016 Intel, Inc."},{"line_number":9,"context_line":"# Copyright (c) 2013 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_be38b5d4","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":0},"in_reply_to":"9a89bdaa_9a0ceb3c","updated":"2016-09-12 15:27:31.000000000","message":"No, this should be removed.","commit_id":"0335e28ee25d86a8382e8a32c905046073b7881f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"118dcd6e12ee33946bad275aca136427a6721e63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright (c) 2016 Intel, Inc."},{"line_number":9,"context_line":"# Copyright (c) 2013 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a8bc5a2_2fa12395","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":0},"updated":"2016-09-22 19:01:59.000000000","message":"Why are these headers added back?","commit_id":"86a4ac174f7b18f1f17664bf39dc8333754a130d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c648f295c2398941248231ce4856e3c7c148240","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright (c) 2016 Intel, Inc."},{"line_number":9,"context_line":"# Copyright (c) 2013 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a8bc5a2_e830f6ea","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":0},"in_reply_to":"5a8bc5a2_2fa12395","updated":"2016-09-23 09:26:24.000000000","message":"Done","commit_id":"86a4ac174f7b18f1f17664bf39dc8333754a130d"}],"releasenotes/notes/deprecate-topic-opts-68b1a752dba1eb24.yaml":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d8d3328ba122296ab9fe712056ed351c0d66bb8a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The ``topic`` config options are now deprecated and may be removed"},{"line_number":4,"context_line":"    as early as the 15.0.0 release. There is no need to let users choose the"},{"line_number":5,"context_line":"    RPC topic for all services - there is little gain from this."},{"line_number":6,"context_line":"    Furthermore, it makes it really easy to break Nova by using these options."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_26e00129","line":6,"updated":"2016-08-10 17:33:25.000000000","message":"We should really list the options in here.","commit_id":"8455111b2c00f434ec949897460ed9a6f92b3064"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"04c14ca8fc5ac31290aa047977412f88ab51e80b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    RPC topic for all services - there is little gain from this."},{"line_number":6,"context_line":"    Furthermore, it makes it really easy to break Nova by using these options."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Options to be removed:"},{"line_number":9,"context_line":"    * cells.topic"},{"line_number":10,"context_line":"    * compute_topic"},{"line_number":11,"context_line":"    * conductor.topic"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ac371cc_80366001","line":8,"updated":"2016-08-15 16:51:26.000000000","message":"I am not sure that will render correctly. it looks like its badly formatted.","commit_id":"ded7d4c63233be32e0caa9e7ca3da89fe9c53e3b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8433b2089f7e3962c75f3b3540aef7724feb527","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The ``topic`` config options are now deprecated and may be removed"},{"line_number":4,"context_line":"    as early as the 15.0.0 release. There is no need to let users choose the"},{"line_number":5,"context_line":"    RPC topic for all services - there is little gain from this."},{"line_number":6,"context_line":"    Furthermore, it makes it really easy to break Nova by using these options."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_9a230ba7","line":3,"range":{"start_line":3,"start_character":56,"end_line":3,"end_character":59},"updated":"2016-09-12 12:19:13.000000000","message":"will","commit_id":"0335e28ee25d86a8382e8a32c905046073b7881f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8433b2089f7e3962c75f3b3540aef7724feb527","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The ``topic`` config options are now deprecated and may be removed"},{"line_number":4,"context_line":"    as early as the 15.0.0 release. There is no need to let users choose the"},{"line_number":5,"context_line":"    RPC topic for all services - there is little gain from this."},{"line_number":6,"context_line":"    Furthermore, it makes it really easy to break Nova by using these options."},{"line_number":7,"context_line":"    The deprecated options are as below:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_fa3417df","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":15},"updated":"2016-09-12 12:19:13.000000000","message":"in","commit_id":"0335e28ee25d86a8382e8a32c905046073b7881f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8433b2089f7e3962c75f3b3540aef7724feb527","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The ``topic`` config options are now deprecated and may be removed"},{"line_number":4,"context_line":"    as early as the 15.0.0 release. There is no need to let users choose the"},{"line_number":5,"context_line":"    RPC topic for all services - there is little gain from this."},{"line_number":6,"context_line":"    Furthermore, it makes it really easy to break Nova by using these options."},{"line_number":7,"context_line":"    The deprecated options are as below:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - cells.topic"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_3a74bf9a","line":6,"range":{"start_line":4,"start_character":36,"end_line":6,"end_character":78},"updated":"2016-09-12 12:19:13.000000000","message":"I\u0027d remove this as the information is already found in the individual options","commit_id":"0335e28ee25d86a8382e8a32c905046073b7881f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06ab6e3f40a1d74bfae8822aa51ea16b340762db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The ``topic`` config options are now deprecated and will be removed"},{"line_number":4,"context_line":"    in the next release. The deprecated options are as below:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    - |"},{"line_number":7,"context_line":"      cells.topic"},{"line_number":8,"context_line":"    - |"},{"line_number":9,"context_line":"      compute_topic"},{"line_number":10,"context_line":"    - |"},{"line_number":11,"context_line":"      conductor.topic"},{"line_number":12,"context_line":"    - |"},{"line_number":13,"context_line":"      console_topic"},{"line_number":14,"context_line":"    - |"},{"line_number":15,"context_line":"      consoleauth_topic"},{"line_number":16,"context_line":"    - |"},{"line_number":17,"context_line":"      network_topic"},{"line_number":18,"context_line":"    - |"},{"line_number":19,"context_line":"      scheduler_topic"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a8bc5a2_aafff832","line":19,"range":{"start_line":3,"start_character":0,"end_line":19,"end_character":21},"updated":"2016-09-22 13:37:57.000000000","message":"Are you sure this is right? Something like the below look more correct:\n\n  - |\n    The ``topic`` config options are now deprecated and will be removed\n    in the next release. The deprecated options are as below:\n\n    * cells.topic\n    * compute.topic\n    * ...\n\nNot tested though...","commit_id":"3856cac1dd5faab8fc817ca3f348c1ca8c5a40e0"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"608da811d9b615cad1c07e3ab1eee028de6f351a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The ``topic`` config options are now deprecated and will be removed"},{"line_number":4,"context_line":"    in the next release. The deprecated options are as below:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    - |"},{"line_number":7,"context_line":"      cells.topic"},{"line_number":8,"context_line":"    - |"},{"line_number":9,"context_line":"      compute_topic"},{"line_number":10,"context_line":"    - |"},{"line_number":11,"context_line":"      conductor.topic"},{"line_number":12,"context_line":"    - |"},{"line_number":13,"context_line":"      console_topic"},{"line_number":14,"context_line":"    - |"},{"line_number":15,"context_line":"      consoleauth_topic"},{"line_number":16,"context_line":"    - |"},{"line_number":17,"context_line":"      network_topic"},{"line_number":18,"context_line":"    - |"},{"line_number":19,"context_line":"      scheduler_topic"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a8bc5a2_cde7fe3e","line":19,"range":{"start_line":3,"start_character":0,"end_line":19,"end_character":21},"in_reply_to":"5a8bc5a2_aafff832","updated":"2016-09-22 13:45:28.000000000","message":"You are probably right. I was trying to follow the doc and it was a bit confusing to me.","commit_id":"3856cac1dd5faab8fc817ca3f348c1ca8c5a40e0"}]}