)]}'
{"nova/conf/s3.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3004c2d054d743fd79f7a4f355f7279f0456e399","unresolved":false,"context_lines":[{"line_number":44,"context_line":"1 - 65535"},{"line_number":45,"context_line":"\"\"\"),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027s3_access_key\u0027,"},{"line_number":47,"context_line":"               deprecated_for_removal\u003dTrue,  # needs:fix_opt_description"},{"line_number":48,"context_line":"               deprecated_reason\u003d\u0027EC2 API related options are not supported.\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027notchecked\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Access key to use S3 server for images\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_b32a037d","line":47,"range":{"start_line":47,"start_character":43,"end_line":47,"end_character":72},"updated":"2016-08-08 11:37:58.000000000","message":"No need for that, we are deprecating all of these.","commit_id":"1e690406ae470f8005e7475a0600ca39fa3283c4"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"545e5ae03d3a87c0a573c1b4a1817929b780e4e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2010 United States Government as represented by the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_6eedeb24","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"updated":"2016-08-09 18:59:31.000000000","message":"All options in this file are already deprecated, I think its worth to take out this flag rather than raising a separate patch for this. Ping John and he will +2 again on your next patch.","commit_id":"cbe96c3dd7fc3f1a2728f9ce361506c19d6dae88"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"a8eb00270a3746a4d69746549e7378afd87c3063","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2010 United States Government as represented by the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_54a511b3","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"in_reply_to":"9ad45d7e_25ccae69","updated":"2016-08-09 22:22:09.000000000","message":"So my assumption was that we are not going to remove any deprecated option from Newton anymore, as it has more code impact and we don\u0027t want that at this moment. Only deprecate by setting the flag if required and remove in next cycle.","commit_id":"cbe96c3dd7fc3f1a2728f9ce361506c19d6dae88"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"07c2ba1580e4d53ae9824bfdf584b594f6895a86","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2010 United States Government as represented by the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_9a3b1e38","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"in_reply_to":"9ad45d7e_54a511b3","updated":"2016-08-10 08:41:18.000000000","message":"So I dug a bit further, turns out its just dead code now, that this is configuring, so we should be clear to remove this next time.","commit_id":"cbe96c3dd7fc3f1a2728f9ce361506c19d6dae88"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ca2a98628f7e9df3bbcb3c13a1570e80a74ec585","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2010 United States Government as represented by the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_25ccae69","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"in_reply_to":"9ad45d7e_6eedeb24","updated":"2016-08-09 21:18:46.000000000","message":"So the idea of this flag is also to check if we can remove them already.\n\nIn this case, I am not sure we can remove these, but we might need to look at deprecating some other configuration options, so we are actually able to remove these.","commit_id":"cbe96c3dd7fc3f1a2728f9ce361506c19d6dae88"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"88d633d79588dd3cb6efbc7ecb46a6db5ac08b04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2010 United States Government as represented by the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_ac7fbd64","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"in_reply_to":"9ad45d7e_9a3b1e38","updated":"2016-08-10 14:29:41.000000000","message":"Looks like these options were deprecated in this cycle only. Even though not used in code anymore, we should remove these in next cycle?","commit_id":"cbe96c3dd7fc3f1a2728f9ce361506c19d6dae88"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6bc933d6a0d7f535ed26032d9c8eee1f2dd90cbe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2010 United States Government as represented by the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_56069586","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"in_reply_to":"9ad45d7e_9a3b1e38","updated":"2016-08-10 12:44:43.000000000","message":"Ok, Thanks for the info. I will raise a patch to remove these options, if these are deprecated in M or before.","commit_id":"cbe96c3dd7fc3f1a2728f9ce361506c19d6dae88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"91b6c792cc22b0f9a92f1fdde496930e05d185dd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Port used when accessing the S3 API. It should be in the range of"},{"line_number":41,"context_line":"1 - 65535"},{"line_number":42,"context_line":"\"\"\"),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027s3_access_key\u0027,"},{"line_number":44,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":45,"context_line":"               deprecated_reason\u003d\u0027EC2 API related options are not supported.\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027notchecked\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Access key to use S3 server for images\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027s3_secret_key\u0027,"},{"line_number":49,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":50,"context_line":"               deprecated_reason\u003d\u0027EC2 API related options are not supported.\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027notchecked\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Secret key to use for S3 server for images\u0027),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027s3_use_ssl\u0027,"},{"line_number":54,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":55,"context_line":"                deprecated_reason\u003d\u0027EC2 API related options are not supported.\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_0e576ccb","line":52,"range":{"start_line":43,"start_character":4,"end_line":52,"end_character":66},"updated":"2016-08-18 19:28:58.000000000","message":"It seems very weird to have a default value of \u0027notchecked\u0027 when that doesn\u0027t look like a special value in boto:\n\nhttps://github.com/boto/boto/blob/develop/boto/s3/connection.py#L162\n\nThe default should probably just be None.\n\nBut, these are deprecated options and probably don\u0027t work anyway, so meh, these could be cleaned up later if anyone cared.","commit_id":"98dd53bbd37434a5f4c25dc17de7e56b8ae2f477"}]}