)]}'
{"nova/tests/api/openstack/compute/plugins/v3/test_quota_sets.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2fe513e732e9520a745edd7d98f865b2aa27ca75","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _generate_quota_set(self, id\u003dNone):"},{"line_number":40,"context_line":"        generated_quota_set \u003d {"},{"line_number":41,"context_line":"            \u0027quota_set\u0027:{"},{"line_number":42,"context_line":"                    \u0027metadata_items\u0027: 128,"},{"line_number":43,"context_line":"                    \u0027ram\u0027: 51200,"},{"line_number":44,"context_line":"                    \u0027floating_ips\u0027: 10,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fnwg%3D","line":41,"updated":"2013-07-15 18:55:19.000000000","message":"Needs a space between the \u0027:\u0027 and \u0027}\u0027.","commit_id":"cbc36d12735582d16636697df5d5cc3a4eeceb63"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"3556d555edf643ec9d18e3b2aaa667b936baac3e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                          req, 1234)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_quotas_update_as_admin(self):"},{"line_number":101,"context_line":"        self.ext_mgr.is_loaded(\u0027os-extended-quotas\u0027).AndReturn(True)"},{"line_number":102,"context_line":"        self.mox.ReplayAll()"},{"line_number":103,"context_line":"        body \u003d self._generate_quota_set()"},{"line_number":104,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/os-quota-sets/update_me\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FauM%3D","line":101,"updated":"2013-07-02 12:33:36.000000000","message":"self.ext_mgr.is_loaded(\u0027os-extended-quotas\u0027).AndReturn(True)\n\nWhy didn\u0027t you move this to setUp()?","commit_id":"cbc36d12735582d16636697df5d5cc3a4eeceb63"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"877e537327dfb46ec43e9987f7f04b6760b0ca00","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                          req, 1234)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_quotas_update_as_admin(self):"},{"line_number":101,"context_line":"        self.ext_mgr.is_loaded(\u0027os-extended-quotas\u0027).AndReturn(True)"},{"line_number":102,"context_line":"        self.mox.ReplayAll()"},{"line_number":103,"context_line":"        body \u003d self._generate_quota_set()"},{"line_number":104,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/os-quota-sets/update_me\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FXcU%3D","line":101,"in_reply_to":"AAAAPn%2F%2FXgY%3D","updated":"2013-07-03 08:04:10.000000000","message":"ok","commit_id":"cbc36d12735582d16636697df5d5cc3a4eeceb63"},{"author":{"_account_id":7727,"name":"Eduard Yuzlikeev","email":"eyuzlikeev@mirantis.com","username":"eyuzlikeev"},"change_message_id":"9b0164e7cb0c5eceb63ce72cedbc0585901cb5a3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                          req, 1234)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_quotas_update_as_admin(self):"},{"line_number":101,"context_line":"        self.ext_mgr.is_loaded(\u0027os-extended-quotas\u0027).AndReturn(True)"},{"line_number":102,"context_line":"        self.mox.ReplayAll()"},{"line_number":103,"context_line":"        body \u003d self._generate_quota_set()"},{"line_number":104,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/os-quota-sets/update_me\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FXgY%3D","line":101,"in_reply_to":"AAAAPn%2F%2FXlM%3D","updated":"2013-07-03 07:39:33.000000000","message":"Just look at test_delete_quotas_when_extension_not_loaded.","commit_id":"cbc36d12735582d16636697df5d5cc3a4eeceb63"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f5503585df72b5ae2250b079017c8f1253763ea9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                          req, 1234)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_quotas_update_as_admin(self):"},{"line_number":101,"context_line":"        self.ext_mgr.is_loaded(\u0027os-extended-quotas\u0027).AndReturn(True)"},{"line_number":102,"context_line":"        self.mox.ReplayAll()"},{"line_number":103,"context_line":"        body \u003d self._generate_quota_set()"},{"line_number":104,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/os-quota-sets/update_me\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FXlM%3D","line":101,"in_reply_to":"AAAAPn%2F%2FXwA%3D","updated":"2013-07-03 06:40:35.000000000","message":"Will it really break some test if it moves to setUp()? It will reduce code duplication.","commit_id":"cbc36d12735582d16636697df5d5cc3a4eeceb63"},{"author":{"_account_id":7727,"name":"Eduard Yuzlikeev","email":"eyuzlikeev@mirantis.com","username":"eyuzlikeev"},"change_message_id":"6765f2016d8e77908e3d40ed3950121f7913a159","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                          req, 1234)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_quotas_update_as_admin(self):"},{"line_number":101,"context_line":"        self.ext_mgr.is_loaded(\u0027os-extended-quotas\u0027).AndReturn(True)"},{"line_number":102,"context_line":"        self.mox.ReplayAll()"},{"line_number":103,"context_line":"        body \u003d self._generate_quota_set()"},{"line_number":104,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/os-quota-sets/update_me\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FXwA%3D","line":101,"in_reply_to":"AAAAPn%2F%2FauM%3D","updated":"2013-07-03 05:42:25.000000000","message":"Because it\u0027s not required in some tests.","commit_id":"cbc36d12735582d16636697df5d5cc3a4eeceb63"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"71a12d06ca759ea9d74cb3b0250b7e35a4a05387","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                          req, \u0027update_me\u0027, body)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_quotas_update_invalid_limit(self):"},{"line_number":122,"context_line":"        body \u003d self._generate_quota_set()"},{"line_number":123,"context_line":"        body[\u0027quota_set\u0027][\u0027instances\u0027] \u003d -2"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/os-quota-sets/update_me\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FXXc%3D","line":122,"updated":"2013-08-01 10:55:39.000000000","message":"why do you not pass the instances as a parameter?","commit_id":"7ab8aabb83bfe74c399168a52a7248584d00db6c"},{"author":{"_account_id":6509,"name":"Roman Bogorodskiy","email":"rbogorodskiy@mirantis.com","username":"novel"},"change_message_id":"4de908a3eb955db6f35f95583f1b0719011ffab9","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                          req, \u0027update_me\u0027, body)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_quotas_update_invalid_limit(self):"},{"line_number":122,"context_line":"        body \u003d self._generate_quota_set()"},{"line_number":123,"context_line":"        body[\u0027quota_set\u0027][\u0027instances\u0027] \u003d -2"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/os-quota-sets/update_me\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FXWw%3D","line":122,"in_reply_to":"AAAAQn%2F%2FXXc%3D","updated":"2013-08-01 11:02:14.000000000","message":"Ah, I just modified _generate_quota_set() to accept kwargs for overriding parameters, but forgot to adopt this piece of code accordingly. Thanks for catching that.","commit_id":"7ab8aabb83bfe74c399168a52a7248584d00db6c"}]}