)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6b122556b1023e933f38c96d30552da3a036df0a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace mox with mock in test_cinder"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Avoid race conditions with test_compute tests and complete"},{"line_number":10,"context_line":"the replacement for the full file as listed in the old"},{"line_number":11,"context_line":"blueprint."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_9351b2db","line":9,"updated":"2016-08-12 14:43:49.000000000","message":"With test_compute or test_cinder? :)","commit_id":"bc5b3cdafec572b20fc96d488ec0b30302f58b6e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"127ea1a2baf696c5f7222e4051bcbce6608125c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace mox with mock in test_cinder"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Avoid race conditions with test_compute tests and complete"},{"line_number":10,"context_line":"the replacement for the full file as listed in the old"},{"line_number":11,"context_line":"blueprint."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_62c9c9ac","line":9,"in_reply_to":"9ad45d7e_9351b2db","updated":"2016-08-12 15:10:26.000000000","message":"Somehow the reserve_volume test in test_cinder got a collision with another one in test_compute according to the logs: http://logs.openstack.org/58/335358/12/check/gate-nova-python34-db/404641d/console.html#_2016-08-08_19_47_57_286193\n\nThis is why there is a fix in test_compute as well in the follow up patch. I didn\u0027t want to mix the two, but will update the commit message accordingly.","commit_id":"bc5b3cdafec572b20fc96d488ec0b30302f58b6e"}],"nova/tests/unit/volume/test_cinder.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6b122556b1023e933f38c96d30552da3a036df0a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class FakeVolume(object):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, volume_id, size \u003d 1, attachments \u003d [],"},{"line_number":36,"context_line":"                 multiattach \u003d False):"},{"line_number":37,"context_line":"        self.id \u003d volume_id"},{"line_number":38,"context_line":"        self.name \u003d \u0027volume_name\u0027"},{"line_number":39,"context_line":"        self.description \u003d \u0027volume_description\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f35c6ef2","line":36,"updated":"2016-08-12 14:43:49.000000000","message":"Here are throughout, please ensure keyword arguments do not have spaces in between the argument name and the default value of the argument.","commit_id":"bc5b3cdafec572b20fc96d488ec0b30302f58b6e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"127ea1a2baf696c5f7222e4051bcbce6608125c7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class FakeVolume(object):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, volume_id, size \u003d 1, attachments \u003d [],"},{"line_number":36,"context_line":"                 multiattach \u003d False):"},{"line_number":37,"context_line":"        self.id \u003d volume_id"},{"line_number":38,"context_line":"        self.name \u003d \u0027volume_name\u0027"},{"line_number":39,"context_line":"        self.description \u003d \u0027volume_description\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_42ce45b5","line":36,"in_reply_to":"9ad45d7e_f35c6ef2","updated":"2016-08-12 15:10:26.000000000","message":"Done","commit_id":"bc5b3cdafec572b20fc96d488ec0b30302f58b6e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"90c74ed5048935989156d8d8d0db22ef49344605","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            cinder_exception.NotFound(404, \u0027404\u0027))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertRaises(exception.VolumeNotFound,"},{"line_number":92,"context_line":"                  self.api.get, self.ctx, \u0027id1\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @mock.patch(\u0027nova.volume.cinder.cinderclient\u0027)"},{"line_number":95,"context_line":"    def test_get_failed_badrequest(self, mock_cinderclient):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_33bcd8db","line":92,"updated":"2016-08-22 17:49:05.000000000","message":"The above lines didn\u0027t need to change. You could just leave the line:\n\n volume_id \u003d \u0027volume_id\u0027\n\nat the top of the methods and then the only lines of code necessary to change would be the changes from mox to mock...","commit_id":"0f078a26f77ede45dfbaa177bd0bc1a5eca378de"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a44a8b01f7be55e4ecfc0c7a53869031f19c196","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            cinder_exception.NotFound(404, \u0027404\u0027))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertRaises(exception.VolumeNotFound,"},{"line_number":92,"context_line":"                  self.api.get, self.ctx, \u0027id1\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @mock.patch(\u0027nova.volume.cinder.cinderclient\u0027)"},{"line_number":95,"context_line":"    def test_get_failed_badrequest(self, mock_cinderclient):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_b6640d22","line":92,"in_reply_to":"1ac06dbe_33bcd8db","updated":"2016-08-23 10:45:02.000000000","message":"Right, I think I felt this unnecessary, when I saw only the code and not the diff like here. You need to add the \"volume_id \u003d \u0027volume_id\u0027\" line to the new test cases too to keep it consistent and I thought it would be many extra lines for no good reason here. I can change this back if a new patch set is needed.","commit_id":"0f078a26f77ede45dfbaa177bd0bc1a5eca378de"}]}