)]}'
{"nova/tests/unit/api/openstack/compute/test_suspend_server.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"04211f5c78e95dc4c15533e0aef6969be1da6af1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self, get_instance_mock):"},{"line_number":81,"context_line":"        get_instance_mock.return_value \u003d ("},{"line_number":82,"context_line":"            fake_instance.fake_instance_obj(self.req.environ[\u0027nova.context\u0027]))"},{"line_number":83,"context_line":"        rule_name \u003d \"os_compute_api:os-suspend-server:suspend\""},{"line_number":84,"context_line":"        self.policy.set_rules({rule_name: \"user_id:%(user_id)s\"})"},{"line_number":85,"context_line":"        # Change the user_id in request context."},{"line_number":86,"context_line":"        self.req.environ[\u0027nova.context\u0027].user_id \u003d \u0027other-user\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_9567554c","line":83,"updated":"2016-08-10 16:38:17.000000000","message":"It feels bad this is cut and pasted in so many places.","commit_id":"07cc703f5d77e795ea6b35d6e203948478c8f535"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d64eccea18dc17d42ca9ee63f02f05f9825248f0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self, get_instance_mock):"},{"line_number":81,"context_line":"        get_instance_mock.return_value \u003d ("},{"line_number":82,"context_line":"            fake_instance.fake_instance_obj(self.req.environ[\u0027nova.context\u0027]))"},{"line_number":83,"context_line":"        rule_name \u003d \"os_compute_api:os-suspend-server:suspend\""},{"line_number":84,"context_line":"        self.policy.set_rules({rule_name: \"user_id:%(user_id)s\"})"},{"line_number":85,"context_line":"        # Change the user_id in request context."},{"line_number":86,"context_line":"        self.req.environ[\u0027nova.context\u0027].user_id \u003d \u0027other-user\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_2b809cf4","line":83,"in_reply_to":"9ad45d7e_2871c744","updated":"2016-08-11 12:45:16.000000000","message":"yes, that\u0027s a good point","commit_id":"07cc703f5d77e795ea6b35d6e203948478c8f535"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a063d563acf56c3a75cfdebf4f92d0fde42bda6b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self, get_instance_mock):"},{"line_number":81,"context_line":"        get_instance_mock.return_value \u003d ("},{"line_number":82,"context_line":"            fake_instance.fake_instance_obj(self.req.environ[\u0027nova.context\u0027]))"},{"line_number":83,"context_line":"        rule_name \u003d \"os_compute_api:os-suspend-server:suspend\""},{"line_number":84,"context_line":"        self.policy.set_rules({rule_name: \"user_id:%(user_id)s\"})"},{"line_number":85,"context_line":"        # Change the user_id in request context."},{"line_number":86,"context_line":"        self.req.environ[\u0027nova.context\u0027].user_id \u003d \u0027other-user\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_f32224a2","line":83,"in_reply_to":"9ad45d7e_9567554c","updated":"2016-08-10 19:07:51.000000000","message":"maybe we can consider create something like\n\nPOLICY_ROOT \u003d \u0027os_compute_api:os-suspend-server:%s\u0027\n\nOS_SUSPEND_SERVER_SUSPEND \u003d OLICY_ROOT % \u0027suspend\u0027\n\nsuspend_server_policies \u003d [\n    policy.RuleDefault(\n        name\u003dPOLICY_ROOT % \u0027resume\u0027,\n        check_str\u003dbase.RULE_ADMIN_OR_OWNER),\n    policy.RuleDefault(\n        name\u003dOS_SUSPEND_SERVER_SUSPEND,\n        check_str\u003dbase.RULE_ADMIN_OR_OWNER),\n    policy.RuleDefault(\n        name\u003dPOLICY_ROOT % \u0027discoverable\u0027,\n        check_str\u003dbase.RULE_ANY),\n]\n\nand reuse  OS_SUSPEND_SERVER_SUSPEND?","commit_id":"07cc703f5d77e795ea6b35d6e203948478c8f535"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e894171f4ec37d1e0d9283a3f60fc0d662b1f14b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self, get_instance_mock):"},{"line_number":81,"context_line":"        get_instance_mock.return_value \u003d ("},{"line_number":82,"context_line":"            fake_instance.fake_instance_obj(self.req.environ[\u0027nova.context\u0027]))"},{"line_number":83,"context_line":"        rule_name \u003d \"os_compute_api:os-suspend-server:suspend\""},{"line_number":84,"context_line":"        self.policy.set_rules({rule_name: \"user_id:%(user_id)s\"})"},{"line_number":85,"context_line":"        # Change the user_id in request context."},{"line_number":86,"context_line":"        self.req.environ[\u0027nova.context\u0027].user_id \u003d \u0027other-user\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_2871c744","line":83,"in_reply_to":"9ad45d7e_f32224a2","updated":"2016-08-11 11:16:04.000000000","message":"Actually this is helpful for ensure the rule name is right. If we use OS_SUSPEND_SERVER_SUSPEND, that means if the value of OS_SUSPEND_SERVER_SUSPEND changed, the test can\u0027t help us to find that.\n\nMaybe we can have constant in the test file.","commit_id":"07cc703f5d77e795ea6b35d6e203948478c8f535"}]}