)]}'
{"nova/image/glance.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"08d1ca225be3c9848d2492ced89ccb7e29e91d8c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        image_metas \u003d self.detail(context, filters\u003d{\u0027name\u0027: name})"},{"line_number":231,"context_line":"        for image_meta in image_metas:"},{"line_number":232,"context_line":"            if name \u003d\u003d image_meta.get(\u0027name\u0027):"},{"line_number":233,"context_line":"                return image_meta"},{"line_number":234,"context_line":"        raise exception.ImageNotFound(image_id\u003dname)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get(self, context, image_id, data):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F9Kc%3D","line":233,"updated":"2012-01-29 06:06:24.000000000","message":"Can\u0027t you get rid of this for loop now and do something like:\nif not image_metas:\n  raise ...\nreturn image_metas[0]\n\n?","commit_id":"a64335bb09e21a536d236ca86902f3001a63e9fb"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"da95bea9fb74e932ea2b0157fef0c1aef0da1f35","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        image_metas \u003d self.detail(context, filters\u003d{\u0027name\u0027: name})"},{"line_number":231,"context_line":"        for image_meta in image_metas:"},{"line_number":232,"context_line":"            if name \u003d\u003d image_meta.get(\u0027name\u0027):"},{"line_number":233,"context_line":"                return image_meta"},{"line_number":234,"context_line":"        raise exception.ImageNotFound(image_id\u003dname)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get(self, context, image_id, data):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F9KQ%3D","line":233,"in_reply_to":"AAAAEH%2F%2F9Kc%3D","updated":"2012-01-29 06:20:10.000000000","message":"Went with a try/except approach, but cleaned it up nonetheless. See latest patchset","commit_id":"a64335bb09e21a536d236ca86902f3001a63e9fb"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6235d7c31245b6b768e2cf6dc9e97a2cf4c10a9f","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        try:"},{"line_number":232,"context_line":"            return image_metas[0]"},{"line_number":233,"context_line":"        except (IndexError, TypeError):"},{"line_number":234,"context_line":"            raise exception.ImageNotFound(image_id\u003dname)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get(self, context, image_id, data):"},{"line_number":237,"context_line":"        \"\"\"Calls out to Glance for metadata and data and writes data.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F9IY%3D","line":234,"updated":"2012-01-29 18:51:29.000000000","message":"Wouldn\u0027t it be easier to do:\n\n if not image_metas:\n     raise exception.ImageNotFound(image_id\u003dname)\n\n?","commit_id":"755f660b7ca129f869da07db0cc4433106f47ff9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"332d90f115d31cfc68508d8a315bbee481b7fc12","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        try:"},{"line_number":232,"context_line":"            return image_metas[0]"},{"line_number":233,"context_line":"        except (IndexError, TypeError):"},{"line_number":234,"context_line":"            raise exception.ImageNotFound(image_id\u003dname)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get(self, context, image_id, data):"},{"line_number":237,"context_line":"        \"\"\"Calls out to Glance for metadata and data and writes data.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F9As%3D","line":234,"in_reply_to":"AAAAEH%2F%2F9IE%3D","updated":"2012-01-30 17:32:45.000000000","message":"I don\u0027t really see getting no results as being a failure... but whatever, it\u0027s not a big enough deal to hold up :)","commit_id":"755f660b7ca129f869da07db0cc4433106f47ff9"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"210522dea951e2a036942b13873068b4925d6644","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        try:"},{"line_number":232,"context_line":"            return image_metas[0]"},{"line_number":233,"context_line":"        except (IndexError, TypeError):"},{"line_number":234,"context_line":"            raise exception.ImageNotFound(image_id\u003dname)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get(self, context, image_id, data):"},{"line_number":237,"context_line":"        \"\"\"Calls out to Glance for metadata and data and writes data.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F9IE%3D","line":234,"in_reply_to":"AAAAEH%2F%2F9IY%3D","updated":"2012-01-29 18:55:19.000000000","message":"Easier in what sense? I like to assume everything went as planned and handle failures only if they occur. I feel it is clunky to check for every failure case up front with if statements like that.","commit_id":"755f660b7ca129f869da07db0cc4433106f47ff9"}]}