)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"6b9ed16c013440d549d7b2fa4ba0572f7e619701","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix HTTP response for PortNotFound during boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a non-existent Quantum port is passed as a network parameter during create"},{"line_number":10,"context_line":"instance, Nova API should return an HTTP BadRequest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixes bug #1195468"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAQn%2F%2FTbY%3D","line":10,"updated":"2013-08-02 08:04:53.000000000","message":"should be \"Nova API should not return an HTTP BadRequest\"?","commit_id":"4721408ea861a66af1ad1df5a45c42addcd8a95f"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"6025406f86e855db6627dfc07bc017056109dd84","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix HTTP response for PortNotFound during boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a non-existent Quantum port is passed as a network parameter during create"},{"line_number":10,"context_line":"instance, Nova API should return an HTTP BadRequest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixes bug #1195468"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAQn%2F%2FP4Y%3D","line":10,"in_reply_to":"AAAAQn%2F%2FTRM%3D","updated":"2013-08-04 02:37:59.000000000","message":"Rohit, the commit message is right since you updated the bug description","commit_id":"4721408ea861a66af1ad1df5a45c42addcd8a95f"},{"author":{"_account_id":4120,"name":"Rohit Karajgi","email":"rohit.karajgi@ril.com","username":"rohitkarajgi"},"change_message_id":"2b6787c3ca4edf1509279eccfc1b754612522fe0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix HTTP response for PortNotFound during boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a non-existent Quantum port is passed as a network parameter during create"},{"line_number":10,"context_line":"instance, Nova API should return an HTTP BadRequest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixes bug #1195468"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAQn%2F%2FTRM%3D","line":10,"in_reply_to":"AAAAQn%2F%2FTbY%3D","updated":"2013-08-02 09:06:54.000000000","message":"Jian: Can you explain why Nova API should \"not\" return HTTP BadReuest? This response code is in accordance with the way Nova API returns error response for resources not found by the clients.","commit_id":"4721408ea861a66af1ad1df5a45c42addcd8a95f"}],"nova/network/quantumv2/api.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"af5d82c9e8725d3942b57cd21b2dcc7d35f6857d","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                                     .get(\u0027port\u0027))"},{"line_number":462,"context_line":"                except quantumv2.exceptions.QuantumClientException as e:"},{"line_number":463,"context_line":"                    if e.status_code \u003d\u003d 404:"},{"line_number":464,"context_line":"                        port \u003d None"},{"line_number":465,"context_line":"                if not port:"},{"line_number":466,"context_line":"                    raise exception.PortNotFound(port_id\u003dport_id)"},{"line_number":467,"context_line":"                if port.get(\u0027device_id\u0027, None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fh1E%3D","line":464,"updated":"2013-07-16 22:43:57.000000000","message":"what will quantum client return if the port is not found?  In other words why didn\u0027t the line below work?","commit_id":"54ea9894f2ed2228b21f118758b7fb6221606ddd"},{"author":{"_account_id":4120,"name":"Rohit Karajgi","email":"rohit.karajgi@ril.com","username":"rohitkarajgi"},"change_message_id":"b4ba84c783afa2fa86eb22c38f4c00e4b0a8bb07","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                                     .get(\u0027port\u0027))"},{"line_number":462,"context_line":"                except quantumv2.exceptions.QuantumClientException as e:"},{"line_number":463,"context_line":"                    if e.status_code \u003d\u003d 404:"},{"line_number":464,"context_line":"                        port \u003d None"},{"line_number":465,"context_line":"                if not port:"},{"line_number":466,"context_line":"                    raise exception.PortNotFound(port_id\u003dport_id)"},{"line_number":467,"context_line":"                if port.get(\u0027device_id\u0027, None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F88U%3D","line":464,"in_reply_to":"AAAAP3%2F%2Fh1E%3D","updated":"2013-07-18 15:49:49.000000000","message":"Right, the line below did not work earlier. Quantum client raised a QuantumClientException and set the error code in the object. To make the line below work, the error code, i.e 404 in this case needed to be checked. \nEarlier, the PortNotFound exception was never caught by Nova API due this problem.","commit_id":"54ea9894f2ed2228b21f118758b7fb6221606ddd"}],"nova/tests/network/test_quantumv2.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e9fc087d9b118aa9c1e6cef6cfd500379e54224d","unresolved":false,"context_lines":[{"line_number":851,"context_line":"    def test_validate_networks_port_not_found(self):"},{"line_number":852,"context_line":"        \"\"\"Verify that the correct exception is thrown when a non existent"},{"line_number":853,"context_line":"           port is passed to validate_networks."},{"line_number":854,"context_line":"        \"\"\""},{"line_number":855,"context_line":"        requested_networks \u003d [(\u0027my_netid1\u0027, None, \u00273123-ad34-bc43-32332ca33e\u0027)]"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        QuantumNotFound \u003d quantumv2.exceptions.QuantumClientException("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fniw%3D","line":854,"updated":"2013-07-15 19:36:43.000000000","message":"Please drop the docstring.  It makes sense to convert to a comment, but docstrings on tests often get reported by test frameworks in preference to the test method name, which makes it more difficult to track down which test is failing…","commit_id":"54ea9894f2ed2228b21f118758b7fb6221606ddd"},{"author":{"_account_id":4120,"name":"Rohit Karajgi","email":"rohit.karajgi@ril.com","username":"rohitkarajgi"},"change_message_id":"b4ba84c783afa2fa86eb22c38f4c00e4b0a8bb07","unresolved":false,"context_lines":[{"line_number":851,"context_line":"    def test_validate_networks_port_not_found(self):"},{"line_number":852,"context_line":"        \"\"\"Verify that the correct exception is thrown when a non existent"},{"line_number":853,"context_line":"           port is passed to validate_networks."},{"line_number":854,"context_line":"        \"\"\""},{"line_number":855,"context_line":"        requested_networks \u003d [(\u0027my_netid1\u0027, None, \u00273123-ad34-bc43-32332ca33e\u0027)]"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        QuantumNotFound \u003d quantumv2.exceptions.QuantumClientException("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F878%3D","line":854,"in_reply_to":"AAAAP3%2F%2Fniw%3D","updated":"2013-07-18 15:49:49.000000000","message":"Done","commit_id":"54ea9894f2ed2228b21f118758b7fb6221606ddd"}]}