)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"80ab005d5c03411696f9ccd728113ae6ffa53c53","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            raise exception.NoValidHost(reason\u003d\u0027\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # Returns HostState objects."},{"line_number":176,"context_line":"        dests \u003d [host for host in selected_hosts]"},{"line_number":177,"context_line":"        return dests"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _provision_resource(self, context, weighed_host, request_spec,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FWKQ%3D","line":176,"updated":"2013-07-03 15:59:44.000000000","message":"Do you mean \"dests \u003d [host for host.obj in selected_hosts]\"??","commit_id":"b5a289039d701a36b6c2f0734a4e61c81ace42db"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"5a2d4c684aff741d251da9f5483958bffa474440","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            raise exception.NoValidHost(reason\u003d\u0027\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # Returns HostState objects."},{"line_number":176,"context_line":"        dests \u003d [host for host in selected_hosts]"},{"line_number":177,"context_line":"        return dests"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _provision_resource(self, context, weighed_host, request_spec,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FWE8%3D","line":176,"in_reply_to":"AAAAPn%2F%2FWGA%3D","updated":"2013-07-03 16:31:18.000000000","message":"Thanks Andrew. I think that we should not return WeighedHost as we want to make select_destinations() as generic as possible,  some customized nova scheduler might not include WeighedHost but hostState is common for all nova schedulers.\n\nYes, it is my typo. Should be \"dests \u003d [host.obj for host in selected_hosts]\"","commit_id":"b5a289039d701a36b6c2f0734a4e61c81ace42db"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"676907491b98bd325186733b4621fd6bfc3774b3","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            raise exception.NoValidHost(reason\u003d\u0027\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # Returns HostState objects."},{"line_number":176,"context_line":"        dests \u003d [host for host in selected_hosts]"},{"line_number":177,"context_line":"        return dests"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _provision_resource(self, context, weighed_host, request_spec,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FWGA%3D","line":176,"in_reply_to":"AAAAPn%2F%2FWKQ%3D","updated":"2013-07-03 16:26:36.000000000","message":"Nice catch.  This is actually what\u0027s desired, well really [host.obj for host in ...].  It\u0027s not very clear but selected_hosts are WeighedHosts and selected_hosts[0].obj is a HostState.\n\nI\u0027m not sure there\u0027s benefit from returning the WeighedHost and constantly pulling the HostState out later.","commit_id":"b5a289039d701a36b6c2f0734a4e61c81ace42db"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"0b2baa6c55256326a4be528c19aa7843c4920195","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            raise exception.NoValidHost(reason\u003d\u0027\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # Returns HostState objects."},{"line_number":176,"context_line":"        dests \u003d [host for host in selected_hosts]"},{"line_number":177,"context_line":"        return dests"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _provision_resource(self, context, weighed_host, request_spec,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FWIg%3D","line":176,"in_reply_to":"AAAAPn%2F%2FWKQ%3D","updated":"2013-07-03 16:13:19.000000000","message":"for host in selected_hosts:\n    dests.append(host.obj)\n\nShall we only return host.obj? As weight might not be used by other schedulers.","commit_id":"b5a289039d701a36b6c2f0734a4e61c81ace42db"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"32f63650c21a417a23ad982c53dec3f7f89f89f6","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # Returns HostState objects."},{"line_number":176,"context_line":"        dests \u003d [host for host in selected_hosts]"},{"line_number":177,"context_line":"        return dests"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _provision_resource(self, context, weighed_host, request_spec,"},{"line_number":180,"context_line":"            filter_properties, requested_networks, injected_files,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FWQQ%3D","line":177,"updated":"2013-07-03 15:33:24.000000000","message":"Just curious why not return selected_hosts directly? Thanks.","commit_id":"b5a289039d701a36b6c2f0734a4e61c81ace42db"}]}