)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1c1205442221492e359f011b6ab81c79746c8ec4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The nova.network.model.Network class uses names"},{"line_number":10,"context_line":"\u0027should_create_{bridge,vlan}\u0027 not \u0027should_provide_{bridge,vlan}\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I245f560156d596be14ef9181bfb881be9680c166"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_2553a018","line":12,"updated":"2016-08-11 15:16:55.000000000","message":"Closes-Bug?","commit_id":"cc36c42dee78974463dd254cb3d8c4fb9866b4c1"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9ad876110c820e01dc243e8aae908e6d2f3e3f68","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    if network.get_meta(\"bridge_interface\") is not None:"},{"line_number":216,"context_line":"        netobj.bridge_interface \u003d network.get_meta(\"bridge_interface\")"},{"line_number":217,"context_line":"    if network.get_meta(\"should_create_vlan\") is not None:"},{"line_number":218,"context_line":"        netobj.should_provide_vlan \u003d network.get_meta(\"should_create_vlan\")"},{"line_number":219,"context_line":"    if network.get_meta(\"vlan\") is not None:"},{"line_number":220,"context_line":"        netobj.vlan \u003d network.get_meta(\"vlan\")"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_85afec7b","line":218,"range":{"start_line":218,"start_character":8,"end_line":218,"end_character":75},"updated":"2016-08-11 15:24:53.000000000","message":"I can see where this is going to trip us up with the different names, but not much we can do now beyond making an alias in the network object or doing a v2 of that, which I don\u0027t want to do right after we landed this code.","commit_id":"50a9088a32b32ca987e8a05a7ed4ee659ae15aed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c94a6dfd863d9263e6ac668fd04480e0377e46d5","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    if network.get_meta(\"bridge_interface\") is not None:"},{"line_number":216,"context_line":"        netobj.bridge_interface \u003d network.get_meta(\"bridge_interface\")"},{"line_number":217,"context_line":"    if network.get_meta(\"should_create_vlan\") is not None:"},{"line_number":218,"context_line":"        netobj.should_provide_vlan \u003d network.get_meta(\"should_create_vlan\")"},{"line_number":219,"context_line":"    if network.get_meta(\"vlan\") is not None:"},{"line_number":220,"context_line":"        netobj.vlan \u003d network.get_meta(\"vlan\")"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_20c0ae4f","line":218,"range":{"start_line":218,"start_character":8,"end_line":218,"end_character":75},"in_reply_to":"9ad45d7e_600bc624","updated":"2016-08-11 15:34:39.000000000","message":"famouse. last. words. :)","commit_id":"50a9088a32b32ca987e8a05a7ed4ee659ae15aed"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"49eaf3b7b160ed455904fb965a060779a8d92f4a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    if network.get_meta(\"bridge_interface\") is not None:"},{"line_number":216,"context_line":"        netobj.bridge_interface \u003d network.get_meta(\"bridge_interface\")"},{"line_number":217,"context_line":"    if network.get_meta(\"should_create_vlan\") is not None:"},{"line_number":218,"context_line":"        netobj.should_provide_vlan \u003d network.get_meta(\"should_create_vlan\")"},{"line_number":219,"context_line":"    if network.get_meta(\"vlan\") is not None:"},{"line_number":220,"context_line":"        netobj.vlan \u003d network.get_meta(\"vlan\")"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_600bc624","line":218,"range":{"start_line":218,"start_character":8,"end_line":218,"end_character":75},"in_reply_to":"9ad45d7e_85afec7b","updated":"2016-08-11 15:29:19.000000000","message":"NB its only short term pain, as in a release or two, the nova.network.model classes will die, leaving just os-vif.","commit_id":"50a9088a32b32ca987e8a05a7ed4ee659ae15aed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f49b7ac9fad52ebb4d56cc9ed8393a4093cac1d4","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    if network.get_meta(\"should_create_vlan\") is not None:"},{"line_number":218,"context_line":"        netobj.should_provide_vlan \u003d network.get_meta(\"should_create_vlan\")"},{"line_number":219,"context_line":"        if network.get_meta(\"vlan\") is None:"},{"line_number":220,"context_line":"            raise exception.NovaException(_LE(\"Missing vlan number in %s\") %"},{"line_number":221,"context_line":"                                          network)"},{"line_number":222,"context_line":"        netobj.vlan \u003d network.get_meta(\"vlan\")"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_a1981679","line":220,"range":{"start_line":220,"start_character":42,"end_line":220,"end_character":45},"updated":"2016-08-11 19:10:53.000000000","message":"Not supposed to put translated messages in an exception, see:\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"549e41ffabfaf667a64b4b4a96fd8a320efbb352"}],"nova/tests/unit/network/test_os_vif_util.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e2234c9145a03420aecbfda8c64f1958033e0682","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            address\u003d\"22:52:25:62:e2:aa\","},{"line_number":441,"context_line":"            network\u003dmodel.Network("},{"line_number":442,"context_line":"                id\u003d\"b82c1929-051e-481d-8110-4669916c7915\","},{"line_number":443,"context_line":"                bridge_interface\u003dNone,"},{"line_number":444,"context_line":"                label\u003d\"Demo Net\","},{"line_number":445,"context_line":"                subnets\u003d[]),"},{"line_number":446,"context_line":"            details\u003d{"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_f328299c","line":443,"updated":"2016-08-11 17:11:44.000000000","message":"You shouldn\u0027t have to specify this on the vif model object here and below as get_meta defaults to return None.","commit_id":"13d07940f1f2b0cc701dbe56a55d948a64303c7b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1d00c2f7f17dd6b4a22d46d2752b184024f47bda","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            address\u003d\"22:52:25:62:e2:aa\","},{"line_number":441,"context_line":"            network\u003dmodel.Network("},{"line_number":442,"context_line":"                id\u003d\"b82c1929-051e-481d-8110-4669916c7915\","},{"line_number":443,"context_line":"                bridge_interface\u003dNone,"},{"line_number":444,"context_line":"                label\u003d\"Demo Net\","},{"line_number":445,"context_line":"                subnets\u003d[]),"},{"line_number":446,"context_line":"            details\u003d{"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_0e5034d3","line":443,"in_reply_to":"9ad45d7e_f328299c","updated":"2016-08-11 17:17:23.000000000","message":"Oh true.","commit_id":"13d07940f1f2b0cc701dbe56a55d948a64303c7b"}]}