)]}'
{"nova/cells/opts.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"94d56dd26d33ed70167674f9fc9319807c83db86","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        if cell_type \u003d\u003d \u0027api\u0027 or cell_type \u003d\u003d \u0027compute\u0027:"},{"line_number":89,"context_line":"            return cell_type"},{"line_number":90,"context_line":"        msg \u003d _(\"cell_type must be configured as \u0027api\u0027 or \u0027compute\u0027\")"},{"line_number":91,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":92,"context_line":"    LOG.deprecated(_(\"The compute_api_class is now deprecated and \""},{"line_number":93,"context_line":"                     \"will be removed in next release. Please set the\""},{"line_number":94,"context_line":"                     \" cell_type option to \u0027api\u0027 or \u0027compute\u0027\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FXcI%3D","line":91,"updated":"2013-07-03 08:23:46.000000000","message":"this raised exception should be caught and handled in upper code where the function is called","commit_id":"981dc75c9ca45580fce49dc20427b52e31f68b1f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"1e724ec34e4e339b6fa0e73ecf8997e4c70cdcb9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        if cell_type \u003d\u003d \u0027api\u0027 or cell_type \u003d\u003d \u0027compute\u0027:"},{"line_number":89,"context_line":"            return cell_type"},{"line_number":90,"context_line":"        msg \u003d _(\"cell_type must be configured as \u0027api\u0027 or \u0027compute\u0027\")"},{"line_number":91,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":92,"context_line":"    LOG.deprecated(_(\"The compute_api_class is now deprecated and \""},{"line_number":93,"context_line":"                     \"will be removed in next release. Please set the\""},{"line_number":94,"context_line":"                     \" cell_type option to \u0027api\u0027 or \u0027compute\u0027\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FWxg%3D","line":91,"in_reply_to":"AAAAPn%2F%2FXcI%3D","updated":"2013-07-03 13:14:55.000000000","message":"The old code does not do this.  And there\u0027s not really any way to handle it.  You want the service to bomb out because of an invalid config in this case.","commit_id":"981dc75c9ca45580fce49dc20427b52e31f68b1f"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"94d56dd26d33ed70167674f9fc9319807c83db86","unresolved":false,"context_lines":[{"line_number":9140,"context_line":"        result \u003d compute._get_compute_api_class_name()"},{"line_number":9141,"context_line":"        self.assertEqual(\u0027nova.compute.api.API\u0027, result)"},{"line_number":9142,"context_line":""},{"line_number":9143,"context_line":"    def test_cell_compute_api_class_name_deprecated(self):"},{"line_number":9144,"context_line":"        self.flags(enable\u003dTrue, group\u003d\u0027cells\u0027)"},{"line_number":9145,"context_line":"        self.flags(cell_type\u003d\u0027\u0027, group\u003d\u0027cells\u0027)"},{"line_number":9146,"context_line":"        api_cls_name \u003d \u0027nova.compute.cells_api.ComputeCellsAPI\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FXaA%3D","line":9143,"updated":"2013-07-03 08:23:46.000000000","message":"exception.InvalidInput should be tested in this test case or in another test case","commit_id":"981dc75c9ca45580fce49dc20427b52e31f68b1f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"1e724ec34e4e339b6fa0e73ecf8997e4c70cdcb9","unresolved":false,"context_lines":[{"line_number":9140,"context_line":"        result \u003d compute._get_compute_api_class_name()"},{"line_number":9141,"context_line":"        self.assertEqual(\u0027nova.compute.api.API\u0027, result)"},{"line_number":9142,"context_line":""},{"line_number":9143,"context_line":"    def test_cell_compute_api_class_name_deprecated(self):"},{"line_number":9144,"context_line":"        self.flags(enable\u003dTrue, group\u003d\u0027cells\u0027)"},{"line_number":9145,"context_line":"        self.flags(cell_type\u003d\u0027\u0027, group\u003d\u0027cells\u0027)"},{"line_number":9146,"context_line":"        api_cls_name \u003d \u0027nova.compute.cells_api.ComputeCellsAPI\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FWxY%3D","line":9143,"in_reply_to":"AAAAPn%2F%2FXaA%3D","updated":"2013-07-03 13:14:55.000000000","message":"It\u0027s in the test right below this one.  As mentioned in the other comment, I did not change the behavior.  I just moved the code.","commit_id":"981dc75c9ca45580fce49dc20427b52e31f68b1f"}]}