)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5fe94587d1aa8a490ddefd13e247fafa6f14a17a","unresolved":false,"context_lines":[{"line_number":6037,"context_line":"        # currently oslo_config will raise ValueError instead of setting"},{"line_number":6038,"context_line":"        # option value to its min/max."},{"line_number":6039,"context_line":"        if downtime \u003c downtime_min:"},{"line_number":6040,"context_line":"            LOG.warning(_LE(\"Config option live_migration_downtime\u0027s value \""},{"line_number":6041,"context_line":"                            \"is less than minimum value %dms, rounded up to\""},{"line_number":6042,"context_line":"                            \"the minimum value.\"), downtime_min)"},{"line_number":6043,"context_line":"            downtime \u003d downtime_min"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_76134e5d","line":6040,"range":{"start_line":6040,"start_character":24,"end_line":6040,"end_character":27},"updated":"2016-08-15 03:44:17.000000000","message":"It should be \u0027_LW\u0027.","commit_id":"e21ce292009da825852ebd809f0dced1081db640"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5fe94587d1aa8a490ddefd13e247fafa6f14a17a","unresolved":false,"context_lines":[{"line_number":6043,"context_line":"            downtime \u003d downtime_min"},{"line_number":6044,"context_line":""},{"line_number":6045,"context_line":"        if steps \u003c steps_min:"},{"line_number":6046,"context_line":"            LOG.warning(_LE(\"Config option live_migration_downtime_steps\u0027s \""},{"line_number":6047,"context_line":"                            \"value is less than minimum value %dms, rounded \""},{"line_number":6048,"context_line":"                            \"up to the minimum value.\"), steps_min)"},{"line_number":6049,"context_line":"            steps \u003d steps_min"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_5610d24e","line":6046,"range":{"start_line":6046,"start_character":24,"end_line":6046,"end_character":27},"updated":"2016-08-15 03:44:17.000000000","message":"ditto","commit_id":"e21ce292009da825852ebd809f0dced1081db640"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5fe94587d1aa8a490ddefd13e247fafa6f14a17a","unresolved":false,"context_lines":[{"line_number":6048,"context_line":"                            \"up to the minimum value.\"), steps_min)"},{"line_number":6049,"context_line":"            steps \u003d steps_min"},{"line_number":6050,"context_line":"        if delay \u003c delay_min:"},{"line_number":6051,"context_line":"            LOG.warning(_LE(\"Config option live_migration_downtime_delay\u0027s \""},{"line_number":6052,"context_line":"                            \"value is less than minimum value %dms, rounded \""},{"line_number":6053,"context_line":"                            \"up to the minimum value.\"), delay_min)"},{"line_number":6054,"context_line":"            delay \u003d delay_min"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_f6257eae","line":6051,"range":{"start_line":6051,"start_character":24,"end_line":6051,"end_character":27},"updated":"2016-08-15 03:44:17.000000000","message":"ditto","commit_id":"e21ce292009da825852ebd809f0dced1081db640"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0cdac696d0aa94fefa2d98004484b8d3064fb7aa","unresolved":false,"context_lines":[{"line_number":5974,"context_line":""},{"line_number":5975,"context_line":"        # TODO(hieulq): Need to move min/max value into the config option,"},{"line_number":5976,"context_line":"        # currently oslo_config will raise ValueError instead of setting"},{"line_number":5977,"context_line":"        # option value to its min/max."},{"line_number":5978,"context_line":"        if downtime \u003c downtime_min:"},{"line_number":5979,"context_line":"            LOG.warning(_LW(\"Config option live_migration_downtime\u0027s value \""},{"line_number":5980,"context_line":"                            \"is less than minimum value %dms, rounded up to \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_5658c5fa","line":5977,"updated":"2016-10-11 15:40:25.000000000","message":"IMHO you should just do what this comment suggests and set the min value on the config parameter, so olso.conf deals with validating the range.","commit_id":"e6d3367811052bcbce0a909e80c085d22da938dd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bdae2224641b93595774e19443b86d2712f3a7b6","unresolved":false,"context_lines":[{"line_number":5974,"context_line":""},{"line_number":5975,"context_line":"        # TODO(hieulq): Need to move min/max value into the config option,"},{"line_number":5976,"context_line":"        # currently oslo_config will raise ValueError instead of setting"},{"line_number":5977,"context_line":"        # option value to its min/max."},{"line_number":5978,"context_line":"        if downtime \u003c downtime_min:"},{"line_number":5979,"context_line":"            LOG.warning(_LW(\"Config option live_migration_downtime\u0027s value \""},{"line_number":5980,"context_line":"                            \"is less than minimum value %dms, rounded up to \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_c2740bd1","line":5977,"in_reply_to":"fa6399be_5658c5fa","updated":"2016-10-11 17:21:16.000000000","message":"You can\u0027t do that for at least one cycle. Doing so would be a breaking change for anyone who is currently specifying a negative value","commit_id":"e6d3367811052bcbce0a909e80c085d22da938dd"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"5fa704b4d5e0399baed0fbdb5ec98b643b76575f","unresolved":false,"context_lines":[{"line_number":5974,"context_line":""},{"line_number":5975,"context_line":"        # TODO(hieulq): Need to move min/max value into the config option,"},{"line_number":5976,"context_line":"        # currently oslo_config will raise ValueError instead of setting"},{"line_number":5977,"context_line":"        # option value to its min/max."},{"line_number":5978,"context_line":"        if downtime \u003c downtime_min:"},{"line_number":5979,"context_line":"            LOG.warning(_LW(\"Config option live_migration_downtime\u0027s value \""},{"line_number":5980,"context_line":"                            \"is less than minimum value %dms, rounded up to \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_7ccf517f","line":5977,"in_reply_to":"fa6399be_c2740bd1","updated":"2016-10-12 07:19:33.000000000","message":"I did that in https://review.openstack.org/#/c/323313/, but as suggested, we need add warning in one release before we really restrict them.","commit_id":"e6d3367811052bcbce0a909e80c085d22da938dd"}]}