)]}'
{"nova/tests/unit/api/openstack/compute/test_admin_password.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"708c6537f8f9095911a1c51c1c8fcb26ec8e5916","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_change_password_policy_failed(self):"},{"line_number":160,"context_line":"        rule_name \u003d \"os_compute_api:os-admin-password\""},{"line_number":161,"context_line":"        rule \u003d {rule_name: \"project:non_fake\"}"},{"line_number":162,"context_line":"        self.policy.set_rules(rule)"},{"line_number":163,"context_line":"        body \u003d {\u0027changePassword\u0027: {\u0027adminPass\u0027: \u00271234pass\u0027}}"},{"line_number":164,"context_line":"        exc \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_8a8b4b1e","side":"PARENT","line":161,"updated":"2016-08-12 08:54:17.000000000","message":"wow, that was an awful test.","commit_id":"b0570a2b3ae96a6987b6533e5d9351589dfd4cab"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"708c6537f8f9095911a1c51c1c8fcb26ec8e5916","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def test_change_password_policy_failed_with_other_project(self):"},{"line_number":184,"context_line":"        rule_name \u003d \"os_compute_api:os-admin-password\""},{"line_number":185,"context_line":"        rule \u003d {rule_name: \"project_id:%(project_id)s\"}"},{"line_number":186,"context_line":"        self.policy.set_rules(rule)"},{"line_number":187,"context_line":"        body \u003d {\u0027changePassword\u0027: {\u0027adminPass\u0027: \u00271234pass\u0027}}"},{"line_number":188,"context_line":"        # Change the project_id in request context."},{"line_number":189,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ca9c2360","line":186,"updated":"2016-08-12 08:54:17.000000000","message":"Looks like you are calling this twice here?","commit_id":"93b484d4ef84e102912a54916232530a0a20e366"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e7556f0932d192ab36232f66dffb2c5ec8b1fce","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def test_change_password_policy_failed_with_other_project(self):"},{"line_number":184,"context_line":"        rule_name \u003d \"os_compute_api:os-admin-password\""},{"line_number":185,"context_line":"        rule \u003d {rule_name: \"project_id:%(project_id)s\"}"},{"line_number":186,"context_line":"        self.policy.set_rules(rule)"},{"line_number":187,"context_line":"        body \u003d {\u0027changePassword\u0027: {\u0027adminPass\u0027: \u00271234pass\u0027}}"},{"line_number":188,"context_line":"        # Change the project_id in request context."},{"line_number":189,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_8a7cebec","line":186,"in_reply_to":"9ad45d7e_ca9c2360","updated":"2016-08-12 08:58:12.000000000","message":"ops, yea will update.","commit_id":"93b484d4ef84e102912a54916232530a0a20e366"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"708c6537f8f9095911a1c51c1c8fcb26ec8e5916","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self.policy.set_rules(rule)"},{"line_number":187,"context_line":"        body \u003d {\u0027changePassword\u0027: {\u0027adminPass\u0027: \u00271234pass\u0027}}"},{"line_number":188,"context_line":"        # Change the project_id in request context."},{"line_number":189,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":190,"context_line":"        req.environ[\u0027nova.context\u0027].project_id \u003d \u0027other-project\u0027"},{"line_number":191,"context_line":"        self._common_policy_check("},{"line_number":192,"context_line":"            rule, rule_name, self.controller.change_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_4ad793ed","line":189,"updated":"2016-08-12 08:54:17.000000000","message":"why not self.req here?","commit_id":"93b484d4ef84e102912a54916232530a0a20e366"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e7556f0932d192ab36232f66dffb2c5ec8b1fce","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self.policy.set_rules(rule)"},{"line_number":187,"context_line":"        body \u003d {\u0027changePassword\u0027: {\u0027adminPass\u0027: \u00271234pass\u0027}}"},{"line_number":188,"context_line":"        # Change the project_id in request context."},{"line_number":189,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":190,"context_line":"        req.environ[\u0027nova.context\u0027].project_id \u003d \u0027other-project\u0027"},{"line_number":191,"context_line":"        self._common_policy_check("},{"line_number":192,"context_line":"            rule, rule_name, self.controller.change_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_cad423bf","line":189,"in_reply_to":"9ad45d7e_4ad793ed","updated":"2016-08-12 08:58:12.000000000","message":"That actually due to get_instance we stub_out in setUp,\n\nIf we use self.req then same project_id will be passed on instance also in above stub","commit_id":"93b484d4ef84e102912a54916232530a0a20e366"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f31ce628a1fd5d0844296e245da0dae2bcd89c6f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self.policy.set_rules(rule)"},{"line_number":187,"context_line":"        body \u003d {\u0027changePassword\u0027: {\u0027adminPass\u0027: \u00271234pass\u0027}}"},{"line_number":188,"context_line":"        # Change the project_id in request context."},{"line_number":189,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":190,"context_line":"        req.environ[\u0027nova.context\u0027].project_id \u003d \u0027other-project\u0027"},{"line_number":191,"context_line":"        self._common_policy_check("},{"line_number":192,"context_line":"            rule, rule_name, self.controller.change_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_cd5a7d2a","line":189,"in_reply_to":"9ad45d7e_cad423bf","updated":"2016-08-12 09:02:13.000000000","message":"ah, OK, I guess we need this then.","commit_id":"93b484d4ef84e102912a54916232530a0a20e366"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"708c6537f8f9095911a1c51c1c8fcb26ec8e5916","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        rule_name \u003d \"os_compute_api:os-admin-password\""},{"line_number":207,"context_line":"        rule \u003d {rule_name: \"user_id:%(user_id)s\"}"},{"line_number":208,"context_line":"        # Change the user_id in request context."},{"line_number":209,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":210,"context_line":"        req.environ[\u0027nova.context\u0027].user_id \u003d \u0027other-user\u0027"},{"line_number":211,"context_line":"        body \u003d {\u0027changePassword\u0027: {\u0027adminPass\u0027: \u00271234pass\u0027}}"},{"line_number":212,"context_line":"        self._common_policy_check("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_2af7bf8d","line":209,"updated":"2016-08-12 08:54:17.000000000","message":"why not self.req here?","commit_id":"93b484d4ef84e102912a54916232530a0a20e366"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"925d71a9e96036fe80cfa7c4542907b261beab62","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        rule_name \u003d \"os_compute_api:os-admin-password\""},{"line_number":207,"context_line":"        rule \u003d {rule_name: \"user_id:%(user_id)s\"}"},{"line_number":208,"context_line":"        # Change the user_id in request context."},{"line_number":209,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":210,"context_line":"        req.environ[\u0027nova.context\u0027].user_id \u003d \u0027other-user\u0027"},{"line_number":211,"context_line":"        body \u003d {\u0027changePassword\u0027: {\u0027adminPass\u0027: \u00271234pass\u0027}}"},{"line_number":212,"context_line":"        self._common_policy_check("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ed6ca1d2","line":209,"in_reply_to":"9ad45d7e_2af7bf8d","updated":"2016-08-12 09:03:01.000000000","message":"scratch that one.","commit_id":"93b484d4ef84e102912a54916232530a0a20e366"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"438b7c9c9c6e431709c414cdb4882054d8b01d60","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            return fake_instance.fake_instance_obj("},{"line_number":168,"context_line":"                req_context,"},{"line_number":169,"context_line":"                project_id\u003dreq_context.project_id,"},{"line_number":170,"context_line":"                user_id\u003dreq_context.user_id)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.stub_out("},{"line_number":173,"context_line":"            \u0027nova.api.openstack.common.get_instance\u0027, fake_get_instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_df169657","line":170,"updated":"2016-08-12 12:30:33.000000000","message":"Nit: why is this not using fake_get above? Also seems like we should pass the id here really.","commit_id":"18aa14360c5810f85c1b7dbbcce02e2e48beb2b0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"af8e3970c4a6c44cba34fb8e55f1515d5d1cf02d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                req_context,"},{"line_number":169,"context_line":"                uuid\u003did,"},{"line_number":170,"context_line":"                project_id\u003dreq_context.project_id,"},{"line_number":171,"context_line":"                user_id\u003dreq_context.user_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.stub_out("},{"line_number":174,"context_line":"            \u0027nova.api.openstack.common.get_instance\u0027, fake_get_instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_351c3313","line":171,"updated":"2016-08-12 12:53:01.000000000","message":"Nit: Feels like we could just call fake_get here, but its a nit.","commit_id":"c2e0c6985df8926d608c3741e626501b03fe0d23"}]}