)]}'
{"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"94320b496f5ce0a4a9e282f20943ebf9c1b8caa9","unresolved":false,"context_lines":[{"line_number":1511,"context_line":"            vm_state\u003dvm_states.ACTIVE,"},{"line_number":1512,"context_line":"            project_id\u003dreq.environ[\u0027nova.context\u0027].project_id,"},{"line_number":1513,"context_line":"            user_id\u003dreq.environ[\u0027nova.context\u0027].user_id)"},{"line_number":1514,"context_line":"        self.stubs.Set(compute_api.API, \u0027get\u0027,"},{"line_number":1515,"context_line":"                       lambda api, *a, **k: fake_get(*a, **k))"},{"line_number":1516,"context_line":"        return req"},{"line_number":1517,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_0a50fb5d","line":1514,"updated":"2016-08-12 08:56:12.000000000","message":"We should not use stubs, you could use self.stub_out instead I believe.","commit_id":"4e18a5f4509da6fc149c85a4dff3a47b995ad9fb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dd9f8cf688cbaec8c197d81aa2b5ce1c230c1c4a","unresolved":false,"context_lines":[{"line_number":1511,"context_line":"            vm_state\u003dvm_states.ACTIVE,"},{"line_number":1512,"context_line":"            project_id\u003dreq.environ[\u0027nova.context\u0027].project_id,"},{"line_number":1513,"context_line":"            user_id\u003dreq.environ[\u0027nova.context\u0027].user_id)"},{"line_number":1514,"context_line":"        self.stubs.Set(compute_api.API, \u0027get\u0027,"},{"line_number":1515,"context_line":"                       lambda api, *a, **k: fake_get(*a, **k))"},{"line_number":1516,"context_line":"        return req"},{"line_number":1517,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ca70a3df","line":1514,"in_reply_to":"9ad45d7e_0a50fb5d","updated":"2016-08-12 08:58:19.000000000","message":"Hmm, its a move I guess...","commit_id":"4e18a5f4509da6fc149c85a4dff3a47b995ad9fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e890bc00a88a5e4bbc223b9b6d0d48e07b97c183","unresolved":false,"context_lines":[{"line_number":1511,"context_line":"            vm_state\u003dvm_states.ACTIVE,"},{"line_number":1512,"context_line":"            project_id\u003dreq.environ[\u0027nova.context\u0027].project_id,"},{"line_number":1513,"context_line":"            user_id\u003dreq.environ[\u0027nova.context\u0027].user_id)"},{"line_number":1514,"context_line":"        self.stubs.Set(compute_api.API, \u0027get\u0027,"},{"line_number":1515,"context_line":"                       lambda api, *a, **k: fake_get(*a, **k))"},{"line_number":1516,"context_line":"        return req"},{"line_number":1517,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_cdaefd97","line":1514,"in_reply_to":"9ad45d7e_ca70a3df","updated":"2016-08-12 09:09:35.000000000","message":"nice catch. ll update.","commit_id":"4e18a5f4509da6fc149c85a4dff3a47b995ad9fb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ca27ba6a59ea17dd11fa61108d2789a516d6ca15","unresolved":false,"context_lines":[{"line_number":4341,"context_line":"        rule_name \u003d \"os_compute_api:servers:delete\""},{"line_number":4342,"context_line":"        self.policy.set_rules({rule_name: \"project_id:%(project_id)s\"})"},{"line_number":4343,"context_line":"        self.controller.delete(self.req, fakes.FAKE_UUID)"},{"line_number":4344,"context_line":"        if CONF.reclaim_instance_interval:"},{"line_number":4345,"context_line":"            delete_mock_called \u003d soft_delete_mock"},{"line_number":4346,"context_line":"        else:"},{"line_number":4347,"context_line":"            delete_mock_called \u003d delete_mock"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_cdf6fdf8","line":4344,"updated":"2016-08-12 09:05:47.000000000","message":"This seems really odd here, can\u0027t we just set the flag the way we expect it to go, or just assume the default value?","commit_id":"4e18a5f4509da6fc149c85a4dff3a47b995ad9fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e890bc00a88a5e4bbc223b9b6d0d48e07b97c183","unresolved":false,"context_lines":[{"line_number":4341,"context_line":"        rule_name \u003d \"os_compute_api:servers:delete\""},{"line_number":4342,"context_line":"        self.policy.set_rules({rule_name: \"project_id:%(project_id)s\"})"},{"line_number":4343,"context_line":"        self.controller.delete(self.req, fakes.FAKE_UUID)"},{"line_number":4344,"context_line":"        if CONF.reclaim_instance_interval:"},{"line_number":4345,"context_line":"            delete_mock_called \u003d soft_delete_mock"},{"line_number":4346,"context_line":"        else:"},{"line_number":4347,"context_line":"            delete_mock_called \u003d delete_mock"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_cd855d08","line":4344,"in_reply_to":"9ad45d7e_cdf6fdf8","updated":"2016-08-12 09:09:35.000000000","message":"yea, i think override flag will be better one.","commit_id":"4e18a5f4509da6fc149c85a4dff3a47b995ad9fb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ca27ba6a59ea17dd11fa61108d2789a516d6ca15","unresolved":false,"context_lines":[{"line_number":4374,"context_line":"        rule_name \u003d \"os_compute_api:servers:delete\""},{"line_number":4375,"context_line":"        self.policy.set_rules({rule_name: \"user_id:%(user_id)s\"})"},{"line_number":4376,"context_line":"        self.controller.delete(self.req, fakes.FAKE_UUID)"},{"line_number":4377,"context_line":"        if CONF.reclaim_instance_interval:"},{"line_number":4378,"context_line":"            delete_mock_called \u003d soft_delete_mock"},{"line_number":4379,"context_line":"        else:"},{"line_number":4380,"context_line":"            delete_mock_called \u003d delete_mock"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_8dd3655f","line":4377,"updated":"2016-08-12 09:05:47.000000000","message":"As above.","commit_id":"4e18a5f4509da6fc149c85a4dff3a47b995ad9fb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d3bf25deb426e1223f575d109f1ac3395672dd8a","unresolved":false,"context_lines":[{"line_number":4329,"context_line":""},{"line_number":4330,"context_line":"    @mock.patch(\u0027nova.compute.api.API.soft_delete\u0027)"},{"line_number":4331,"context_line":"    @mock.patch(\u0027nova.api.openstack.common.get_instance\u0027)"},{"line_number":4332,"context_line":"    def test_delete_overridden_policy_pass_with_same_project(self,"},{"line_number":4333,"context_line":"                                                             get_instance_mock,"},{"line_number":4334,"context_line":"                                                             soft_delete_mock):"},{"line_number":4335,"context_line":"        self.flags(reclaim_instance_interval\u003d3600)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_fa7f2864","line":4332,"updated":"2016-08-12 12:32:19.000000000","message":"Nit: this is sort of a duplicate.","commit_id":"cbd3037e4171b70c4f4c60eb80714371a13d8d32"}]}