)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0276d990341e923566eeab16720ed4956d6e2974","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the is_volume_backed_instance check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changing the check for volume backed instance to handle instances with no root_device_name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes LP bug #1197237"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQn%2F%2Ftck%3D","line":9,"updated":"2013-07-24 16:44:07.000000000","message":"Please word-wrap the commit message at 72 columns—this line is 90 columns in length.","commit_id":"60eb0ca10396db99a5ac88d491f82175f712f33b"}],"nova/compute/api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0f9da48ac9f41c3c94dbd7657bf1901add582e25","unresolved":false,"context_lines":[{"line_number":2536,"context_line":""},{"line_number":2537,"context_line":"        if bdms is None:"},{"line_number":2538,"context_line":"            bdms \u003d block_device.legacy_mapping("},{"line_number":2539,"context_line":"                self.get_instance_bdms(context, instance))"},{"line_number":2540,"context_line":""},{"line_number":2541,"context_line":"        for bdm in bdms:"},{"line_number":2542,"context_line":"            if (instance[\u0027root_device_name\u0027] is not None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FXJ4%3D","line":2539,"updated":"2013-07-03 09:52:18.000000000","message":"Is there an issue here that bdms passed in could be the new format, but this code expects the legacy_mapping format?","commit_id":"0cb9f9ed360bd91e702fdedb7d40c2682c0da347"},{"author":{"_account_id":6992,"name":"Kaushik Chandrashekar","email":"kaushik.chandrashekar@rackspace.com","username":"kaushikc"},"change_message_id":"51b3d4bd414ac136ee7c5c46b1456bb1924d55ec","unresolved":false,"context_lines":[{"line_number":2536,"context_line":""},{"line_number":2537,"context_line":"        if bdms is None:"},{"line_number":2538,"context_line":"            bdms \u003d block_device.legacy_mapping("},{"line_number":2539,"context_line":"                self.get_instance_bdms(context, instance))"},{"line_number":2540,"context_line":""},{"line_number":2541,"context_line":"        for bdm in bdms:"},{"line_number":2542,"context_line":"            if (instance[\u0027root_device_name\u0027] is not None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FXGQ%3D","line":2539,"in_reply_to":"AAAAPn%2F%2FXJ4%3D","updated":"2013-07-03 10:15:34.000000000","message":"i am not sure about the new format of bdm, but we should not return True if the device_name is NULL. I\u0027d leave the changes to this method for new format to the commits that are introducing it","commit_id":"0cb9f9ed360bd91e702fdedb7d40c2682c0da347"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"8b06f2ce037f20b0edc1d20efea7a9adaf21fee0","unresolved":false,"context_lines":[{"line_number":2539,"context_line":"                self.get_instance_bdms(context, instance))"},{"line_number":2540,"context_line":""},{"line_number":2541,"context_line":"        for bdm in bdms:"},{"line_number":2542,"context_line":"            if (instance[\u0027root_device_name\u0027] is not None"},{"line_number":2543,"context_line":"                and block_device.strip_dev(bdm[\u0027device_name\u0027]) \u003d\u003d"},{"line_number":2544,"context_line":"                block_device.strip_dev(instance[\u0027root_device_name\u0027])):"},{"line_number":2545,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F%2BiE%3D","line":2542,"updated":"2013-07-08 08:13:55.000000000","message":"It\u0027s a bit confusing/inefficient like this actually.\ninstance[\u0027root_device_name\u0027] is invariant so would be better outside the loop:\n\n  if (instance[\u0027root_device_name\u0027] is not None\n      for bdm in bdms:\n          if ....: return True\n\n  return False","commit_id":"735a88fd3637edc5e37207cdab0e7c87de3b05b9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e136b5762fdc31aff515c12557739888493b2024","unresolved":false,"context_lines":[{"line_number":2549,"context_line":"        if not instance[\u0027image_ref\u0027]:"},{"line_number":2550,"context_line":"            return True"},{"line_number":2551,"context_line":""},{"line_number":2552,"context_line":"        if instance.get(\u0027root_device_name\u0027) is None:"},{"line_number":2553,"context_line":"            return False"},{"line_number":2554,"context_line":""},{"line_number":2555,"context_line":"        if bdms is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F7xQ%3D","line":2552,"updated":"2013-07-18 21:17:30.000000000","message":"can we get a comment in here about the reason for the early escape. I fear someone cleaning it up later not understanding.","commit_id":"09da1b51fd883daf8db5029cfe24ce96f843203f"},{"author":{"_account_id":6992,"name":"Kaushik Chandrashekar","email":"kaushik.chandrashekar@rackspace.com","username":"kaushikc"},"change_message_id":"5c189eca8377e2b149121824c79b1fb6b61a09e5","unresolved":false,"context_lines":[{"line_number":2549,"context_line":"        if not instance[\u0027image_ref\u0027]:"},{"line_number":2550,"context_line":"            return True"},{"line_number":2551,"context_line":""},{"line_number":2552,"context_line":"        if instance.get(\u0027root_device_name\u0027) is None:"},{"line_number":2553,"context_line":"            return False"},{"line_number":2554,"context_line":""},{"line_number":2555,"context_line":"        if bdms is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F6b0%3D","line":2552,"in_reply_to":"AAAAQn%2F%2F7xQ%3D","updated":"2013-07-19 09:38:21.000000000","message":"I am not too keen on adding comments in code unless it\u0027s very confusing.\n\nIdeally the test will act as documentation - test_is_volume_backed_being_false_if_root_device_is_not_set \n\nAnd this test will break if someone accidentally deletes it.","commit_id":"09da1b51fd883daf8db5029cfe24ce96f843203f"}],"nova/tests/compute/test_compute_api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0f9da48ac9f41c3c94dbd7657bf1901add582e25","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_is_volume_backed_being_false_if_root_device_is_not_set(self):"},{"line_number":221,"context_line":"        bdms \u003d [{\u0027device_name\u0027: None}]"},{"line_number":222,"context_line":"        params \u003d {\u0027image_ref\u0027: \u0027some-image-ref\u0027, \u0027root_device_name\u0027: None}"},{"line_number":223,"context_line":"        instance \u003d self._create_instance_obj(params\u003dparams)"},{"line_number":224,"context_line":"        print(self.compute_api.is_volume_backed_instance("},{"line_number":225,"context_line":"                                                        self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FXK0%3D","line":222,"updated":"2013-07-03 09:52:18.000000000","message":"Is this valid, would the root_device_name not become some other disk?","commit_id":"0cb9f9ed360bd91e702fdedb7d40c2682c0da347"},{"author":{"_account_id":6992,"name":"Kaushik Chandrashekar","email":"kaushik.chandrashekar@rackspace.com","username":"kaushikc"},"change_message_id":"51b3d4bd414ac136ee7c5c46b1456bb1924d55ec","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_is_volume_backed_being_false_if_root_device_is_not_set(self):"},{"line_number":221,"context_line":"        bdms \u003d [{\u0027device_name\u0027: None}]"},{"line_number":222,"context_line":"        params \u003d {\u0027image_ref\u0027: \u0027some-image-ref\u0027, \u0027root_device_name\u0027: None}"},{"line_number":223,"context_line":"        instance \u003d self._create_instance_obj(params\u003dparams)"},{"line_number":224,"context_line":"        print(self.compute_api.is_volume_backed_instance("},{"line_number":225,"context_line":"                                                        self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FXGw%3D","line":222,"in_reply_to":"AAAAPn%2F%2FXK0%3D","updated":"2013-07-03 10:15:34.000000000","message":"the root_device_name can be NULL. in most cases i see that it\u0027s value is default. Only if it\u0027s volume based instance we see that root_device_name matches the device_name of a bdm mapping","commit_id":"0cb9f9ed360bd91e702fdedb7d40c2682c0da347"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0f9da48ac9f41c3c94dbd7657bf1901add582e25","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        bdms \u003d [{\u0027device_name\u0027: None}]"},{"line_number":222,"context_line":"        params \u003d {\u0027image_ref\u0027: \u0027some-image-ref\u0027, \u0027root_device_name\u0027: None}"},{"line_number":223,"context_line":"        instance \u003d self._create_instance_obj(params\u003dparams)"},{"line_number":224,"context_line":"        print(self.compute_api.is_volume_backed_instance("},{"line_number":225,"context_line":"                                                        self.context,"},{"line_number":226,"context_line":"                                                        instance, bdms))"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FXMI%3D","line":224,"updated":"2013-07-03 09:52:18.000000000","message":"I guess this was meant to have an assert?","commit_id":"0cb9f9ed360bd91e702fdedb7d40c2682c0da347"},{"author":{"_account_id":6992,"name":"Kaushik Chandrashekar","email":"kaushik.chandrashekar@rackspace.com","username":"kaushikc"},"change_message_id":"51b3d4bd414ac136ee7c5c46b1456bb1924d55ec","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        bdms \u003d [{\u0027device_name\u0027: None}]"},{"line_number":222,"context_line":"        params \u003d {\u0027image_ref\u0027: \u0027some-image-ref\u0027, \u0027root_device_name\u0027: None}"},{"line_number":223,"context_line":"        instance \u003d self._create_instance_obj(params\u003dparams)"},{"line_number":224,"context_line":"        print(self.compute_api.is_volume_backed_instance("},{"line_number":225,"context_line":"                                                        self.context,"},{"line_number":226,"context_line":"                                                        instance, bdms))"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FXHI%3D","line":224,"in_reply_to":"AAAAPn%2F%2FXMI%3D","updated":"2013-07-03 10:15:34.000000000","message":"Done","commit_id":"0cb9f9ed360bd91e702fdedb7d40c2682c0da347"}]}