)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"a3f3b477e7dd3aa21793a0422447ec956c22944c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-29 15:39:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add log for instance with host field set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when doing bug debug, found some instances deleted in"},{"line_number":10,"context_line":"api layer with DELETE call while no rpc message found in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_38c9cd5b","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":25},"updated":"2016-08-24 13:37:59.000000000","message":"without?","commit_id":"02e12c6c221ca896d6236d37c3e1d50657587875"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"2e2beb8a31492be0335eabcf15f540c4a69b6b7f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-29 15:39:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add log for instance with host field set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when doing bug debug, found some instances deleted in"},{"line_number":10,"context_line":"api layer with DELETE call while no rpc message found in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_64b89be6","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":25},"in_reply_to":"1ac06dbe_38c9cd5b","updated":"2016-08-26 20:19:56.000000000","message":"Done","commit_id":"02e12c6c221ca896d6236d37c3e1d50657587875"}],"nova/compute/api.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"be07e80f2cb9f12dd67d6d5956d85bef7a052167","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance do not have host field and \u0027"},{"line_number":1738,"context_line":"                              \u0027its vm_state is %s, deleted in api layer\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027, instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"},{"line_number":1741,"context_line":"                except exception.ObjectActionError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_15e773e5","line":1738,"range":{"start_line":1738,"start_character":47,"end_line":1738,"end_character":49},"updated":"2016-08-15 02:19:08.000000000","message":"It should be \u0027%(state)s\u0027.","commit_id":"97511b39e6687a9e3d55585da3aedac48c204665"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"29c3539ffe1e1c2baaabf27b7b8b1cd5b45d04ed","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance do not have host field and \u0027"},{"line_number":1738,"context_line":"                              \u0027its vm_state is %s, deleted in api layer\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027, instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"},{"line_number":1741,"context_line":"                except exception.ObjectActionError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_44ac9aed","line":1738,"range":{"start_line":1738,"start_character":47,"end_line":1738,"end_character":49},"in_reply_to":"3ac371cc_15e773e5","updated":"2016-08-19 14:52:00.000000000","message":"right, thanks","commit_id":"97511b39e6687a9e3d55585da3aedac48c204665"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"a3f3b477e7dd3aa21793a0422447ec956c22944c","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"                            \"%s.end\" % delete_type,"},{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance do not have host field and its \u0027"},{"line_number":1738,"context_line":"                              \u0027vm_state is %(state)s, deleted in api layer\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027: instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_4c95ee86","line":1737,"range":{"start_line":1737,"start_character":40,"end_line":1737,"end_character":42},"updated":"2016-08-24 13:37:59.000000000","message":"s/does","commit_id":"02e12c6c221ca896d6236d37c3e1d50657587875"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"a3f3b477e7dd3aa21793a0422447ec956c22944c","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"                            \"%s.end\" % delete_type,"},{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance do not have host field and its \u0027"},{"line_number":1738,"context_line":"                              \u0027vm_state is %(state)s, deleted in api layer\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027: instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_2cd99284","line":1737,"range":{"start_line":1737,"start_character":24,"end_line":1737,"end_character":29},"updated":"2016-08-24 13:37:59.000000000","message":"what about warning?","commit_id":"02e12c6c221ca896d6236d37c3e1d50657587875"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"2e2beb8a31492be0335eabcf15f540c4a69b6b7f","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"                            \"%s.end\" % delete_type,"},{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance do not have host field and its \u0027"},{"line_number":1738,"context_line":"                              \u0027vm_state is %(state)s, deleted in api layer\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027: instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_d8ddd871","line":1737,"range":{"start_line":1737,"start_character":40,"end_line":1737,"end_character":42},"in_reply_to":"1ac06dbe_4c95ee86","updated":"2016-08-26 20:19:56.000000000","message":"no, this is not a warning that will lead to potential error \njust for easy debug","commit_id":"02e12c6c221ca896d6236d37c3e1d50657587875"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"a3f3b477e7dd3aa21793a0422447ec956c22944c","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance do not have host field and its \u0027"},{"line_number":1738,"context_line":"                              \u0027vm_state is %(state)s, deleted in api layer\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027: instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"},{"line_number":1741,"context_line":"                except exception.ObjectActionError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_cc80be4c","line":1738,"range":{"start_line":1738,"start_character":54,"end_line":1738,"end_character":74},"updated":"2016-08-24 13:37:59.000000000","message":"I\u0027d rephrase this, because this code could be called from compute.manager.","commit_id":"02e12c6c221ca896d6236d37c3e1d50657587875"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"2e2beb8a31492be0335eabcf15f540c4a69b6b7f","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance do not have host field and its \u0027"},{"line_number":1738,"context_line":"                              \u0027vm_state is %(state)s, deleted in api layer\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027: instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"},{"line_number":1741,"context_line":"                except exception.ObjectActionError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_81559151","line":1738,"range":{"start_line":1738,"start_character":54,"end_line":1738,"end_character":74},"in_reply_to":"1ac06dbe_cc80be4c","updated":"2016-08-26 20:19:56.000000000","message":"ok","commit_id":"02e12c6c221ca896d6236d37c3e1d50657587875"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"32b7182aa714651843a51933d9e0a392fead1bec","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"                            \"%s.end\" % delete_type,"},{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance deleted and does not have host field, \u0027"},{"line_number":1738,"context_line":"                              \u0027its vm_state is %(state)s\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027: instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_d7303beb","line":1737,"updated":"2016-08-26 20:33:08.000000000","message":"I would consider using LOG.info here. We log many of the other delete conditions at INFO level, and this is important enough that debug shouldn\u0027t be required to see it.","commit_id":"4da95af9e9e150ddf1310ca1f029b2e72db57631"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a8ea72a2531dbbc3f25c0c1bb91389293e9d4c6b","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"                            \"%s.end\" % delete_type,"},{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.debug(\u0027Instance deleted and does not have host field, \u0027"},{"line_number":1738,"context_line":"                              \u0027its vm_state is %(state)s\u0027,"},{"line_number":1739,"context_line":"                              {\u0027state\u0027: instance.vm_state}, instance\u003dinstance)"},{"line_number":1740,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_17d46345","line":1737,"in_reply_to":"fa7ab95a_d7303beb","updated":"2016-08-26 20:36:33.000000000","message":"ok, will update it, thx","commit_id":"4da95af9e9e150ddf1310ca1f029b2e72db57631"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"27337c107f9bd95c8df7814c1532974f133a50c8","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"                            \"%s.end\" % delete_type,"},{"line_number":1735,"context_line":"                            system_metadata\u003dinstance.system_metadata)"},{"line_number":1736,"context_line":"                    quotas.commit()"},{"line_number":1737,"context_line":"                    LOG.info(_LI(\u0027Instance deleted and does not have host \u0027"},{"line_number":1738,"context_line":"                                 \u0027field, its vm_state is %(state)s.\u0027),"},{"line_number":1739,"context_line":"                                 {\u0027state\u0027: instance.vm_state},"},{"line_number":1740,"context_line":"                                 instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_bb6c0009","line":1737,"range":{"start_line":1737,"start_character":24,"end_line":1737,"end_character":28},"updated":"2016-08-30 10:44:25.000000000","message":"Feels like it should be a warning, but info is high enough, and probably the most consistent here.","commit_id":"9361b4878d2aacae5c9480fbc58e9b1522881cff"}]}