)]}'
{"nova/conf/floating_ips.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"640326298f12f017392437ed59466cbc181c29b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 Huawei Technology corp."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_67ed1aef","line":1,"updated":"2016-08-16 09:04:37.000000000","message":"We should drop this","commit_id":"a1a38e1251c327d8f6a32e012ccc965d610c5a42"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"65125343d310915a8a3b54c0706955700f815ae8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 Huawei Technology corp."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_2df3eed7","line":1,"in_reply_to":"3ac371cc_67ed1aef","updated":"2016-08-16 15:14:26.000000000","message":"Done","commit_id":"a1a38e1251c327d8f6a32e012ccc965d610c5a42"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"640326298f12f017392437ed59466cbc181c29b2","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Related options:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    * use_neutron: this option only works with nova-network."},{"line_number":42,"context_line":"\"\"\"),"},{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027auto_assign_floating_ip\u0027,"},{"line_number":44,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_e7b74af3","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":4},"updated":"2016-08-16 09:04:37.000000000","message":"Nit: we shouldn\u0027t have this gap here.","commit_id":"a1a38e1251c327d8f6a32e012ccc965d610c5a42"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"65125343d310915a8a3b54c0706955700f815ae8","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Related options:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    * use_neutron: this option only works with nova-network."},{"line_number":42,"context_line":"\"\"\"),"},{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027auto_assign_floating_ip\u0027,"},{"line_number":44,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_6dbb26e6","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":4},"in_reply_to":"3ac371cc_e7b74af3","updated":"2016-08-16 15:14:26.000000000","message":"Done","commit_id":"a1a38e1251c327d8f6a32e012ccc965d610c5a42"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"65adde176751ec07325c14373cf8af8403d30554","unresolved":false,"context_lines":[{"line_number":92,"context_line":"\"\"\"),"},{"line_number":93,"context_line":"    # TODO(aunnam): remove default"},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027instance_dns_domain\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027\u0027,"},{"line_number":96,"context_line":"        help\u003d\"\"\""},{"line_number":97,"context_line":"If specified, Nova checks if the availability_zone of every instance matches"},{"line_number":98,"context_line":"what the database says the availability_zone should be for the specified"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_3c1f9a60","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":19},"updated":"2016-08-16 16:21:46.000000000","message":"I think this can be dropped.","commit_id":"a3100dbfe20a1b6b44059bd5ce142f7095bea5dc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"172183f2b29dee57059e629a536035777277de49","unresolved":false,"context_lines":[{"line_number":92,"context_line":"\"\"\"),"},{"line_number":93,"context_line":"    # TODO(aunnam): remove default"},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027instance_dns_domain\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027\u0027,"},{"line_number":96,"context_line":"        help\u003d\"\"\""},{"line_number":97,"context_line":"If specified, Nova checks if the availability_zone of every instance matches"},{"line_number":98,"context_line":"what the database says the availability_zone should be for the specified"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_49fa5a76","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":19},"in_reply_to":"3ac371cc_3c1f9a60","updated":"2016-08-17 16:07:05.000000000","message":"Along with the TODO above, but this should be a separate commit","commit_id":"a3100dbfe20a1b6b44059bd5ce142f7095bea5dc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29744f9702336ef9f1e2ffd6647599124cdd4925","unresolved":false,"context_lines":[{"line_number":92,"context_line":"\"\"\"),"},{"line_number":93,"context_line":"    # TODO(aunnam): remove default"},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027instance_dns_domain\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027\u0027,"},{"line_number":96,"context_line":"        help\u003d\"\"\""},{"line_number":97,"context_line":"If specified, Nova checks if the availability_zone of every instance matches"},{"line_number":98,"context_line":"what the database says the availability_zone should be for the specified"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_8991f2f3","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":19},"in_reply_to":"3ac371cc_49fa5a76","updated":"2016-08-17 16:08:11.000000000","message":"https://review.openstack.org/356572","commit_id":"a3100dbfe20a1b6b44059bd5ce142f7095bea5dc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8005aec5b39ceb399167dfaf1ee5f71cd94e7949","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Related options:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* use_neutron: this option only works with nova-network."},{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":"    cfg.BoolOpt(\u0027auto_assign_floating_ip\u0027,"},{"line_number":42,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_52706872","line":39,"updated":"2016-09-21 17:32:59.000000000","message":"Turns out this is used by neutron:\nhttps://github.com/openstack/nova/blob/ff6b192aede1f1362f2c5252a50d9b5ffe201e3b/nova/network/neutronv2/api.py#L1917","commit_id":"4872f313467015751adbc98c4c3aeb2e0ee6f11a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8005aec5b39ceb399167dfaf1ee5f71cd94e7949","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* use_neutron: this options only works with nova-network."},{"line_number":52,"context_line":"\"\"\"),"},{"line_number":53,"context_line":"   cfg.StrOpt(\u0027floating_ip_dns_manager\u0027,"},{"line_number":54,"context_line":"        default\u003d\u0027nova.network.noop_dns_driver.NoopDNSDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_784b85b1","line":51,"updated":"2016-09-21 17:32:59.000000000","message":"Not sure about this one now, I think its probably used by neutron to, need to double check that though.","commit_id":"4872f313467015751adbc98c4c3aeb2e0ee6f11a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6858af0fbfb5a0dd63b893b57e647d28975255f3","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* use_neutron: this options only works with nova-network."},{"line_number":52,"context_line":"\"\"\"),"},{"line_number":53,"context_line":"   cfg.StrOpt(\u0027floating_ip_dns_manager\u0027,"},{"line_number":54,"context_line":"        default\u003d\u0027nova.network.noop_dns_driver.NoopDNSDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_99737bb1","line":51,"in_reply_to":"7a8ec9b2_784b85b1","updated":"2016-10-11 12:30:40.000000000","message":"This is used in floating_ips, which is also used by neutron. The above can be removed here also.","commit_id":"4872f313467015751adbc98c4c3aeb2e0ee6f11a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6858af0fbfb5a0dd63b893b57e647d28975255f3","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* use_neutron: this options only works with nova-network."},{"line_number":92,"context_line":"\"\"\"),"},{"line_number":93,"context_line":"    # TODO(aunnam): remove default"},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027instance_dns_domain\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027\u0027,"},{"line_number":96,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_59ee4323","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":34},"updated":"2016-10-11 12:30:40.000000000","message":"nit: this TODO could be removed here as it\u0027s invalid. The default for StrOpt is None, not \u0027\u0027, meaning the default is valid.","commit_id":"4872f313467015751adbc98c4c3aeb2e0ee6f11a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c379240c1be815025a910e069d1266f87e0d521e","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* use_neutron: this options only works with nova-network."},{"line_number":92,"context_line":"\"\"\"),"},{"line_number":93,"context_line":"    # TODO(aunnam): remove default"},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027instance_dns_domain\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027\u0027,"},{"line_number":96,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_7941470b","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":34},"in_reply_to":"fa6399be_59ee4323","updated":"2016-10-11 12:31:19.000000000","message":"actually, nvm\n\nhttps://review.openstack.org/#/c/356572/3","commit_id":"4872f313467015751adbc98c4c3aeb2e0ee6f11a"}]}