)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"43c4eb2483b4b4f122be041130c9d204cd9b5de7","unresolved":false,"context_lines":[{"line_number":7798,"context_line":"            (\u0027xen\u0027, \u0027xenmigr://%s/system\u0027),"},{"line_number":7799,"context_line":"            (\u0027kvm\u0027, \u0027qemu+tcp://%s/system\u0027),"},{"line_number":7800,"context_line":"            (\u0027qemu\u0027, \u0027qemu+tcp://%s/system\u0027),"},{"line_number":7801,"context_line":"            # anything else will return None"},{"line_number":7802,"context_line":"            (\u0027lxc\u0027, None),"},{"line_number":7803,"context_line":"            (\u0027parallels\u0027, None),"},{"line_number":7804,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_08080d91","side":"PARENT","line":7801,"range":{"start_line":7801,"start_character":14,"end_line":7801,"end_character":44},"updated":"2017-01-09 16:20:31.000000000","message":"IMHO this comment should stay there and parallels should be added above it","commit_id":"3130b1cec00b42f63cf77118167bba3d4095ec92"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"332d6625a6a819591c8377e827bc1d9875087143","unresolved":false,"context_lines":[{"line_number":7798,"context_line":"            (\u0027xen\u0027, \u0027xenmigr://%s/system\u0027),"},{"line_number":7799,"context_line":"            (\u0027kvm\u0027, \u0027qemu+tcp://%s/system\u0027),"},{"line_number":7800,"context_line":"            (\u0027qemu\u0027, \u0027qemu+tcp://%s/system\u0027),"},{"line_number":7801,"context_line":"            # anything else will return None"},{"line_number":7802,"context_line":"            (\u0027lxc\u0027, None),"},{"line_number":7803,"context_line":"            (\u0027parallels\u0027, None),"},{"line_number":7804,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_bc8f3fcb","side":"PARENT","line":7801,"range":{"start_line":7801,"start_character":14,"end_line":7801,"end_character":44},"in_reply_to":"ba5201f7_08080d91","updated":"2017-01-09 17:10:37.000000000","message":"Done","commit_id":"3130b1cec00b42f63cf77118167bba3d4095ec92"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"265cf366b2c167491fb4da1a5dfccdc5fad7516f","unresolved":false,"context_lines":[{"line_number":5846,"context_line":"                    guest, migrate_data, self._get_volume_config)"},{"line_number":5847,"context_line":"            if (self._host.has_min_version("},{"line_number":5848,"context_line":"                    MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION) and"},{"line_number":5849,"context_line":"                    CONF.libvirt.virt_type !\u003d hv_type.PARALLELS):"},{"line_number":5850,"context_line":"                params \u003d {"},{"line_number":5851,"context_line":"                    \u0027bandwidth\u0027: CONF.libvirt.live_migration_bandwidth,"},{"line_number":5852,"context_line":"                    \u0027destination_xml\u0027: new_xml_str,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_068705d8","line":5849,"range":{"start_line":5849,"start_character":20,"end_line":5849,"end_character":63},"updated":"2016-08-22 08:15:16.000000000","message":"Why this check is needed there? Isn\u0027t migrateToURI3 supported when openvz is in use?\n\nmigrateToURI3 is required in case of image-backed virtual machines with additional cinder volumes attached. Isn\u0027t such scenario supported in openvz?","commit_id":"675614290334047637069c1e28f094426087e333"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"ed0df7ce49ac5a2c559689b5f2132b82b3b52135","unresolved":false,"context_lines":[{"line_number":5846,"context_line":"                    guest, migrate_data, self._get_volume_config)"},{"line_number":5847,"context_line":"            if (self._host.has_min_version("},{"line_number":5848,"context_line":"                    MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION) and"},{"line_number":5849,"context_line":"                    CONF.libvirt.virt_type !\u003d hv_type.PARALLELS):"},{"line_number":5850,"context_line":"                params \u003d {"},{"line_number":5851,"context_line":"                    \u0027bandwidth\u0027: CONF.libvirt.live_migration_bandwidth,"},{"line_number":5852,"context_line":"                    \u0027destination_xml\u0027: new_xml_str,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_ff7fc863","line":5849,"range":{"start_line":5849,"start_character":20,"end_line":5849,"end_character":63},"in_reply_to":"1ac06dbe_068705d8","updated":"2016-08-22 08:53:38.000000000","message":"migrateToURI3 is supported by vz driver, but we don\u0027t support VIR_MIGRATE_PARAM_MIGRATE_DISKS parameter in libvirt yet. In this commit I\u0027d like to cover very basic live migration case without cinder volumes involved. In future we will support more capabilities and this check will be eliminated.","commit_id":"675614290334047637069c1e28f094426087e333"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"6f439146e416fceb6715b3cc83fc6e151398e3e2","unresolved":false,"context_lines":[{"line_number":5991,"context_line":"        if (self._block_migration_flags \u0026"},{"line_number":5992,"context_line":"                libvirt.VIR_MIGRATE_TUNNELLED \u003d\u003d 0 and"},{"line_number":5993,"context_line":"                self._host.has_min_version("},{"line_number":5994,"context_line":"                    MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION)):"},{"line_number":5995,"context_line":"            bdm_list \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":5996,"context_line":"                context, instance.uuid)"},{"line_number":5997,"context_line":"            block_device_info \u003d driver.get_block_device_info(instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_6e903e44","line":5994,"updated":"2016-08-22 12:50:51.000000000","message":"Given your comment that you do not support selective disk migration, this can be blocked early and we can avoid some DB calls","commit_id":"675614290334047637069c1e28f094426087e333"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"586d77737059374fe2332b201a83c9be8840d0b9","unresolved":false,"context_lines":[{"line_number":5939,"context_line":"                    migrate_uri \u003d self._migrate_uri(dest)"},{"line_number":5940,"context_line":""},{"line_number":5941,"context_line":"            params \u003d None"},{"line_number":5942,"context_line":"            new_xml_str \u003d None"},{"line_number":5943,"context_line":"            if CONF.libvirt.virt_type !\u003d \"parallels\":"},{"line_number":5944,"context_line":"                new_xml_str \u003d libvirt_migrate.get_updated_guest_xml("},{"line_number":5945,"context_line":"                    # TODO(sahid): It\u0027s not a really good idea to pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a74a57a_a993a5ff","line":5942,"range":{"start_line":5942,"start_character":12,"end_line":5942,"end_character":30},"updated":"2016-11-29 17:05:48.000000000","message":"I don\u0027t know that this is okay. Is there some doc that says it\u0027s okay to have None for this in the params to guest.migrate()?\n\nAlso, I don\u0027t see the live migration test running in the Virtuozzo CI report. Can you turn that on somehow so we can see it running?","commit_id":"821c659246d125d9d8785396f1ae6f2f342e855c"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"554866ea7b81e8d9494349ff2ebad676870d1a8b","unresolved":false,"context_lines":[{"line_number":5939,"context_line":"                    migrate_uri \u003d self._migrate_uri(dest)"},{"line_number":5940,"context_line":""},{"line_number":5941,"context_line":"            params \u003d None"},{"line_number":5942,"context_line":"            new_xml_str \u003d None"},{"line_number":5943,"context_line":"            if CONF.libvirt.virt_type !\u003d \"parallels\":"},{"line_number":5944,"context_line":"                new_xml_str \u003d libvirt_migrate.get_updated_guest_xml("},{"line_number":5945,"context_line":"                    # TODO(sahid): It\u0027s not a really good idea to pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a74a57a_3f308b07","line":5942,"range":{"start_line":5942,"start_character":12,"end_line":5942,"end_character":30},"in_reply_to":"5a74a57a_a993a5ff","updated":"2016-11-30 08:48:51.000000000","message":"If new_xml_str is None, then we fall back to migrateToURI. See [1]. Also I see no reasons to update domain XML and pass it to libvirt every time we migrate guest. It should be updated only in specific cases, i.e. VNC/SPICE console of source and destination hosts have different listen addresses.\nRegarding CI: currently we\u0027re working on providing multinode Virtuozzo CI. The we will be able to enable live migration tempest testcases.\n\n[1] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L568-L570","commit_id":"821c659246d125d9d8785396f1ae6f2f342e855c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"586d77737059374fe2332b201a83c9be8840d0b9","unresolved":false,"context_lines":[{"line_number":6699,"context_line":""},{"line_number":6700,"context_line":"        \"\"\""},{"line_number":6701,"context_line":""},{"line_number":6702,"context_line":"        # Virtuozzo containers doesn\u0027t use backing file"},{"line_number":6703,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \"parallels\" and"},{"line_number":6704,"context_line":"                instance.vm_mode \u003d\u003d vm_mode.EXE):"},{"line_number":6705,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a74a57a_c992a14b","line":6702,"range":{"start_line":6702,"start_character":31,"end_line":6702,"end_character":38},"updated":"2016-11-29 17:05:48.000000000","message":"This should be \"don\u0027t\" or \"do not\"","commit_id":"821c659246d125d9d8785396f1ae6f2f342e855c"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"43c4eb2483b4b4f122be041130c9d204cd9b5de7","unresolved":false,"context_lines":[{"line_number":6799,"context_line":"        \"\"\""},{"line_number":6800,"context_line":""},{"line_number":6801,"context_line":"        # Virtuozzo containers don\u0027t use backing file"},{"line_number":6802,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \"parallels\" and"},{"line_number":6803,"context_line":"                instance.vm_mode \u003d\u003d fields.VMMode.EXE):"},{"line_number":6804,"context_line":"            return"},{"line_number":6805,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_6b1fd309","line":6802,"updated":"2017-01-09 16:20:31.000000000","message":"Shouldn\u0027t be a test cases added for this as well? To ensure that _fetch_instance_kernel_ramdisk will not be called if parallels is in use.","commit_id":"e8801f63b5a43208fd969f27f97b20c10f19bc73"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"332d6625a6a819591c8377e827bc1d9875087143","unresolved":false,"context_lines":[{"line_number":6799,"context_line":"        \"\"\""},{"line_number":6800,"context_line":""},{"line_number":6801,"context_line":"        # Virtuozzo containers don\u0027t use backing file"},{"line_number":6802,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \"parallels\" and"},{"line_number":6803,"context_line":"                instance.vm_mode \u003d\u003d fields.VMMode.EXE):"},{"line_number":6804,"context_line":"            return"},{"line_number":6805,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_7cacf735","line":6802,"in_reply_to":"ba5201f7_6b1fd309","updated":"2017-01-09 17:10:37.000000000","message":"Done","commit_id":"e8801f63b5a43208fd969f27f97b20c10f19bc73"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e714391718a10071865ecee548af0be905ac961","unresolved":false,"context_lines":[{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    @staticmethod"},{"line_number":683,"context_line":"    def _live_migration_uri(dest):"},{"line_number":684,"context_line":"        # Only Xen and QEMU support live migration, see"},{"line_number":685,"context_line":"        # https://libvirt.org/migration.html#scenarios for reference"},{"line_number":686,"context_line":"        uris \u003d {"},{"line_number":687,"context_line":"            \u0027kvm\u0027: \u0027qemu+tcp://%s/system\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a57fde8_5b4bb92b","line":684,"updated":"2017-01-12 15:59:57.000000000","message":"We should update this comment now. The docs in the link below also seem outdated, unless we have separate live migration docs for parallels that we can link in here?","commit_id":"4190699ca18f608730cf0b345e789802386c5f91"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"c175219bfe063ce2fc138170acfa2575d1899648","unresolved":false,"context_lines":[{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    @staticmethod"},{"line_number":683,"context_line":"    def _live_migration_uri(dest):"},{"line_number":684,"context_line":"        # Only Xen and QEMU support live migration, see"},{"line_number":685,"context_line":"        # https://libvirt.org/migration.html#scenarios for reference"},{"line_number":686,"context_line":"        uris \u003d {"},{"line_number":687,"context_line":"            \u0027kvm\u0027: \u0027qemu+tcp://%s/system\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a57fde8_ad6aaa18","line":684,"in_reply_to":"9a57fde8_5b4bb92b","updated":"2017-01-12 16:11:19.000000000","message":"Good point, ++, missed that commment","commit_id":"4190699ca18f608730cf0b345e789802386c5f91"}]}