)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bc7f306b1ea11661daee690508704c90061807d8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We must handle this case and use v2.37 samples if we are testing"},{"line_number":16,"context_line":"microversions \u003e\u003d 2.37."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I40cac263c97a4a871072d0efe5ebff295c2d917e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_c63934f4","line":17,"updated":"2016-08-17 08:27:17.000000000","message":"you\u0027re missing a bug number here.","commit_id":"bf6d26e721837f32ff6c272f19c1ecd3f5293752"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"22f8c45ca156c7a5368850aa7dad4425923a7d61","unresolved":false,"context_lines":[{"line_number":10,"context_line":"microversion 2.37. This microversion added required field \u0027networks\u0027"},{"line_number":11,"context_line":"into create server request. By default Nova functional api tests use"},{"line_number":12,"context_line":"samples from \u0027/servers\u0027 directory to create a server. But now such"},{"line_number":13,"context_line":"requests got 400 Bad Request because of missed \u0027networks\u0027 field."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We must handle this case and use v2.37 samples if we are testing"},{"line_number":16,"context_line":"microversions \u003e\u003d 2.37."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_4a29a936","line":13,"updated":"2016-08-17 16:25:06.000000000","message":"s/missed/missing/","commit_id":"f1c6607d96275df1fa24d9e0b1a8ccf748e593d7"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ee38256e301e63eff9e1b930aaf1b29b23b8f5d2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"requests got 400 Bad Request because of missed \u0027networks\u0027 field."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We must handle this case and use v2.37 samples if we are testing"},{"line_number":16,"context_line":"microversions \u003e\u003d 2.37."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch will change samples for microversion 2.37 to be almost"},{"line_number":19,"context_line":"equal default samples from \u0027/servers\u0027 directory. It wouldn\u0027t damage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_38980ac0","line":16,"range":{"start_line":16,"start_character":14,"end_line":16,"end_character":16},"updated":"2016-08-17 15:24:33.000000000","message":"very curious why 2.37 can pass test\n\nmaybe 2.37 still works under original frame work \nand from 2.38 it will fail?","commit_id":"f1c6607d96275df1fa24d9e0b1a8ccf748e593d7"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"9bc1eea1a3ceb015e4dda86d8d1106978ab5ee65","unresolved":false,"context_lines":[{"line_number":13,"context_line":"requests got 400 Bad Request because of missed \u0027networks\u0027 field."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We must handle this case and use v2.37 samples if we are testing"},{"line_number":16,"context_line":"microversions \u003e\u003d 2.37."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch will change samples for microversion 2.37 to be almost"},{"line_number":19,"context_line":"equal default samples from \u0027/servers\u0027 directory. It wouldn\u0027t damage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_13e6cfaf","line":16,"range":{"start_line":16,"start_character":14,"end_line":16,"end_character":16},"in_reply_to":"3ac371cc_38980ac0","updated":"2016-08-17 15:45:17.000000000","message":"2.37 pass because it use samples form its directory (/servers/v2.37)\n\nMy change will use this directory for all mciroversions \u003e 2.37","commit_id":"f1c6607d96275df1fa24d9e0b1a8ccf748e593d7"}],"doc/api_samples/servers/v2.37/server-create-req.json":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"22f8c45ca156c7a5368850aa7dad4425923a7d61","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"auto-allocate-network\","},{"line_number":4,"context_line":"        \"imageRef\": \"70a599e0-31e7-49b7-b260-868f441e862b\","},{"line_number":5,"context_line":"        \"flavorRef\": \"http://openstack.example.com/flavors/1\","},{"line_number":6,"context_line":"        \"networks\": \"auto\""},{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"3ac371cc_aa22dd4f","side":"PARENT","line":6,"updated":"2016-08-17 16:25:06.000000000","message":"In the commit message, you say that \"now such requests got 400 Bad Request because of missed \u0027networks\u0027 field\". However, the networks field is indeed in the request here, so I\u0027m wondering why this change was needed?","commit_id":"9a1f48403defac2290570ca40fc20955ec081164"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e5b8ceb06db128f8e5eb913a8e1708b44ad199af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"server\" : {"},{"line_number":3,"context_line":"        \"accessIPv4\": \"1.2.3.4\","},{"line_number":4,"context_line":"        \"accessIPv6\": \"80fe::\","},{"line_number":5,"context_line":"        \"name\" : \"new-server-test\","},{"line_number":6,"context_line":"        \"imageRef\" : \"70a599e0-31e7-49b7-b260-868f441e862b\","},{"line_number":7,"context_line":"        \"flavorRef\" : \"1\","},{"line_number":8,"context_line":"        \"availability_zone\": \"nova\","},{"line_number":9,"context_line":"        \"OS-DCF:diskConfig\": \"AUTO\","},{"line_number":10,"context_line":"        \"metadata\" : {"},{"line_number":11,"context_line":"            \"My Server Name\" : \"Apache1\""},{"line_number":12,"context_line":"        },"},{"line_number":13,"context_line":"        \"personality\": ["},{"line_number":14,"context_line":"            {"},{"line_number":15,"context_line":"                \"path\": \"/etc/banner.txt\","},{"line_number":16,"context_line":"                \"contents\": \"ICAgICAgDQoiQSBjbG91ZCBkb2VzIG5vdCBrbm93IHdoeSBp dCBtb3ZlcyBpbiBqdXN0IHN1Y2ggYSBkaXJlY3Rpb24gYW5k IGF0IHN1Y2ggYSBzcGVlZC4uLkl0IGZlZWxzIGFuIGltcHVs c2lvbi4uLnRoaXMgaXMgdGhlIHBsYWNlIHRvIGdvIG5vdy4g QnV0IHRoZSBza3kga25vd3MgdGhlIHJlYXNvbnMgYW5kIHRo ZSBwYXR0ZXJucyBiZWhpbmQgYWxsIGNsb3VkcywgYW5kIHlv dSB3aWxsIGtub3csIHRvbywgd2hlbiB5b3UgbGlmdCB5b3Vy c2VsZiBoaWdoIGVub3VnaCB0byBzZWUgYmV5b25kIGhvcml6 b25zLiINCg0KLVJpY2hhcmQgQmFjaA\u003d\u003d\""},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        ],"},{"line_number":19,"context_line":"        \"security_groups\": ["},{"line_number":20,"context_line":"            {"},{"line_number":21,"context_line":"                \"name\": \"default\""},{"line_number":22,"context_line":"            }"},{"line_number":23,"context_line":"        ],"},{"line_number":24,"context_line":"        \"user_data\" : \"IyEvYmluL2Jhc2gKL2Jpbi9zdQplY2hvICJJIGFtIGluIHlvdSEiCg\u003d\u003d\","},{"line_number":25,"context_line":"        \"networks\": \"auto\""},{"line_number":26,"context_line":"    },"},{"line_number":27,"context_line":"    \"OS-SCH-HNT:scheduler_hints\": {"}],"source_content_type":"application/json","patch_set":3,"id":"3ac371cc_a4dfac67","line":24,"range":{"start_line":3,"start_character":8,"end_line":24,"end_character":81},"updated":"2016-08-17 18:01:56.000000000","message":"Yeah why is any of this necessary? This sample is in the docs:\n\nhttp://developer.openstack.org/api-ref/compute/?expanded\u003dcreate-server-detail#create-server\n\nAnd the point of the sample being simple is because get me a network should be simple, pass a flavor, image, name and networks\u003d\u0027auto\u0027 and you\u0027re good to go.","commit_id":"f1c6607d96275df1fa24d9e0b1a8ccf748e593d7"}],"nova/tests/functional/api_samples_test_base.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bc7f306b1ea11661daee690508704c90061807d8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            # requests we must use 2.37 samples if we test microversion \u003e\u003d 2.37"},{"line_number":113,"context_line":"            if (avr.APIVersionRequest(api_version)"},{"line_number":114,"context_line":"                    \u003e\u003d avr.APIVersionRequest(\u00272.37\u0027)):"},{"line_number":115,"context_line":"                parts.append(\u0027v2.37\u0027)"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            parts.append(cls.sample_dir)"},{"line_number":118,"context_line":"            if api_version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_46570426","line":115,"updated":"2016-08-17 08:27:17.000000000","message":"I\u0027m not super happy with the logic here, which defaults to not being 2.37 (so I\u0027d probably be looking at a negative conditional) but okay.","commit_id":"bf6d26e721837f32ff6c272f19c1ecd3f5293752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"badedcfac974e6cf9d20c665d401c6f8a2b3eb21","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        # will be used. As of now it is being used for server POST request"},{"line_number":105,"context_line":"        # to avoid duplicate copy of server req and resp sample files."},{"line_number":106,"context_line":"        # Example - ServersSampleBase\u0027s _post_server method."},{"line_number":107,"context_line":"        if cls._use_common_server_api_samples:"},{"line_number":108,"context_line":"            parts.append(\u0027servers\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            # Note(snikitin): Microversion 2.37 added required field \u0027networks\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_a4220c50","line":107,"range":{"start_line":107,"start_character":15,"end_line":107,"end_character":45},"updated":"2016-08-17 18:10:51.000000000","message":"I guess this is the problem....it\u0027s using the unversioned server samples, but then why is 2.37 being used? Are the failing tests using 2.latest?","commit_id":"f1c6607d96275df1fa24d9e0b1a8ccf748e593d7"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ee38256e301e63eff9e1b930aaf1b29b23b8f5d2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            # requests we must use 2.37 samples if we test microversion \u003e\u003d 2.37"},{"line_number":113,"context_line":"            if (avr.APIVersionRequest(api_version)"},{"line_number":114,"context_line":"                    \u003e\u003d avr.APIVersionRequest(\u00272.37\u0027)):"},{"line_number":115,"context_line":"                parts.append(\u0027v2.37\u0027)"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            parts.append(cls.sample_dir)"},{"line_number":118,"context_line":"            if api_version:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_82c6ef65","line":115,"range":{"start_line":115,"start_character":35,"end_line":115,"end_character":37},"updated":"2016-08-17 15:24:33.000000000","message":"defaults to 2.37 seems not good \n\nmaybe some common files for this kind of support?","commit_id":"f1c6607d96275df1fa24d9e0b1a8ccf748e593d7"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"9bc1eea1a3ceb015e4dda86d8d1106978ab5ee65","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            # requests we must use 2.37 samples if we test microversion \u003e\u003d 2.37"},{"line_number":113,"context_line":"            if (avr.APIVersionRequest(api_version)"},{"line_number":114,"context_line":"                    \u003e\u003d avr.APIVersionRequest(\u00272.37\u0027)):"},{"line_number":115,"context_line":"                parts.append(\u0027v2.37\u0027)"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            parts.append(cls.sample_dir)"},{"line_number":118,"context_line":"            if api_version:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_0e07c818","line":115,"range":{"start_line":115,"start_character":35,"end_line":115,"end_character":37},"in_reply_to":"3ac371cc_82c6ef65","updated":"2016-08-17 15:45:17.000000000","message":"of course we can create some common file \u0027server-create-req-2.37\u0027 and put it into /servers. but in this case we get two equal samples, one in /servers and other in /servers/v2.37. I think we should have one \"entry point\" for microversions \u003e 2.37","commit_id":"f1c6607d96275df1fa24d9e0b1a8ccf748e593d7"}]}