)]}'
{"nova/api/openstack/compute/multinic.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"1bd0b1e7cfd9af60803075ab2cc481cd1de339de","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @wsgi.response(202)"},{"line_number":39,"context_line":"    @wsgi.action(\u0027addFixedIp\u0027)"},{"line_number":40,"context_line":"    @extensions.expected_errors((400, 404, 409))"},{"line_number":41,"context_line":"    @validation.schema(multinic.add_fixed_ip)"},{"line_number":42,"context_line":"    def _add_fixed_ip(self, req, id, body):"},{"line_number":43,"context_line":"        \"\"\"Adds an IP on a given network to an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_ad47a1ba","line":40,"range":{"start_line":40,"start_character":43,"end_line":40,"end_character":46},"updated":"2016-08-17 14:35:07.000000000","message":"409 need microveresion\n\nhttps://github.com/openstack/nova/blob/master/doc/source/api_microversion_dev.rst\n\nthe list of status codes allowed for a particular request\n\nExample: an API previously could return 200, 400, 403, 404 and the change would make the API now also be allowed to return 409.","commit_id":"53788d64e971b4d9f9df43d5e813fc8e6ef60338"},{"author":{"_account_id":20734,"name":"Prateek Arora","email":"1192prateek@gmail.com","username":"prateek_a"},"change_message_id":"706d7569263d0ea250946118b38475e9185b9da1","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @wsgi.response(202)"},{"line_number":39,"context_line":"    @wsgi.action(\u0027addFixedIp\u0027)"},{"line_number":40,"context_line":"    @extensions.expected_errors((400, 404, 409))"},{"line_number":41,"context_line":"    @validation.schema(multinic.add_fixed_ip)"},{"line_number":42,"context_line":"    def _add_fixed_ip(self, req, id, body):"},{"line_number":43,"context_line":"        \"\"\"Adds an IP on a given network to an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_aeab9fd5","line":40,"range":{"start_line":40,"start_character":43,"end_line":40,"end_character":46},"in_reply_to":"3ac371cc_ad47a1ba","updated":"2016-08-19 07:36:26.000000000","message":"Thanks for pointing that out jichenjc. The same doc mentions in the footnotes that rather than creating a new microversion, map that to 400 if none of the previous codes look suitable to you. \n\nDone","commit_id":"53788d64e971b4d9f9df43d5e813fc8e6ef60338"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f7f75ac146ea4dd3a30a73793212319df63fc4fb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        except exception.NoMoreFixedIps as e:"},{"line_number":54,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":55,"context_line":"        except exception.InstanceInvalidState as e:"},{"line_number":56,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @wsgi.response(202)"},{"line_number":59,"context_line":"    @wsgi.action(\u0027removeFixedIp\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_50dd6613","line":56,"range":{"start_line":56,"start_character":22,"end_line":56,"end_character":36},"updated":"2016-08-19 19:28:09.000000000","message":"I agree with you that doc has those info, but I really think we need consistent to other code ,they used something like following and return 409..\n\n       except exception.InstanceInvalidState as state_error:\n           common.raise_http_conflict_for_instance_invalid_state(state_error,\n                   \u0027reboot\u0027, id)","commit_id":"7ffb889457c756fef3b56f9e5e56b81cc5e137eb"}]}