)]}'
{"nova/compute/api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c163ff634dc953ffb68160bfba8e274f77d6a608","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                            pass"},{"line_number":1010,"context_line":"                    for instance_mapping in instance_mappings:"},{"line_number":1011,"context_line":"                        try:"},{"line_number":1012,"context_line":"                            instance_mapping.destroy()"},{"line_number":1013,"context_line":"                        except exception.InstanceMappingNotFound:"},{"line_number":1014,"context_line":"                            pass"},{"line_number":1015,"context_line":"                    for build_request in build_requests:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_93797996","line":1012,"updated":"2016-08-26 15:06:43.000000000","message":"What if the instance delete is not working because for example on a DB issue, and then the instance mapping is deleted ? \nShould we maybe be sure that the instance is deleted before deleting the mapping ?","commit_id":"9cd8bbc7e1098a00b6a56058c76cd1d8ab772f11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"335383968f68dd1c56c6fe7ec393bcac28467a34","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                            pass"},{"line_number":1010,"context_line":"                    for instance_mapping in instance_mappings:"},{"line_number":1011,"context_line":"                        try:"},{"line_number":1012,"context_line":"                            instance_mapping.destroy()"},{"line_number":1013,"context_line":"                        except exception.InstanceMappingNotFound:"},{"line_number":1014,"context_line":"                            pass"},{"line_number":1015,"context_line":"                    for build_request in build_requests:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_3ff8fcc2","line":1012,"in_reply_to":"fa7ab95a_34475a4c","updated":"2016-08-29 21:26:03.000000000","message":"Okay, I was originally thinking of a deadlock, but you\u0027re right, it will raise an exception that won\u0027t be destroying the mappings.","commit_id":"9cd8bbc7e1098a00b6a56058c76cd1d8ab772f11"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f6ef07c8eba0ebf35a6ad4b6899ad9fa8a8c181d","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                            pass"},{"line_number":1010,"context_line":"                    for instance_mapping in instance_mappings:"},{"line_number":1011,"context_line":"                        try:"},{"line_number":1012,"context_line":"                            instance_mapping.destroy()"},{"line_number":1013,"context_line":"                        except exception.InstanceMappingNotFound:"},{"line_number":1014,"context_line":"                            pass"},{"line_number":1015,"context_line":"                    for build_request in build_requests:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_34475a4c","line":1012,"in_reply_to":"fa7ab95a_93797996","updated":"2016-08-29 14:53:50.000000000","message":"We only catch ObjectActionError on instance.destroy, and from what I can see that will never be raised. It is only raised if id or uuid are not set, or if the host changes during the destroy. So a DB issue would raise out of that loop and the instance_mapping would not be destroyed.\n\nI\u0027m fine with guarding against different outcomes I just don\u0027t want to get complicated here. What change would you suggest?","commit_id":"9cd8bbc7e1098a00b6a56058c76cd1d8ab772f11"}]}