)]}'
{"nova/tests/virt/libvirt/test_imagecache.py":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"640f80eab349c1670092cce5ce0c5f078b795c93","unresolved":false,"context_lines":[{"line_number":819,"context_line":"            self.assertTrue(was[\u0027called\u0027])"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"class VerifyChecksumTestCase(test.TestCase):"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"    def setUp(self):"},{"line_number":825,"context_line":"        super(VerifyChecksumTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F%2Bf4%3D","line":822,"updated":"2013-07-08 08:27:03.000000000","message":"Does this really need to be separated into a standalone class?","commit_id":"ac2cb7263ae2198eb3c097c75028d9385518387d"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c36b0e8292482a418c7423f5288b840d8e5a388f","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                (base_file3, False, True)])"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @contextlib.contextmanager"},{"line_number":347,"context_line":"    def _intercept_log_messages(self):"},{"line_number":348,"context_line":"        try:"},{"line_number":349,"context_line":"            mylog \u003d logging.getLogger(\u0027nova\u0027)"},{"line_number":350,"context_line":"            stream \u003d cStringIO.StringIO()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FyqU%3D","line":347,"updated":"2013-07-23 06:41:46.000000000","message":"Dup","commit_id":"754b553655cb26893153b45f292c82bf5dae2236"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c36b0e8292482a418c7423f5288b840d8e5a388f","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        super(VerifyChecksumTestCase, self).setUp()"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    @contextlib.contextmanager"},{"line_number":828,"context_line":"    def _intercept_log_messages(self):"},{"line_number":829,"context_line":"        try:"},{"line_number":830,"context_line":"            mylog \u003d logging.getLogger(\u0027nova\u0027)"},{"line_number":831,"context_line":"            stream \u003d cStringIO.StringIO()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fyqg%3D","line":828,"updated":"2013-07-23 06:41:46.000000000","message":"Isn\u0027t this code now duplicated?","commit_id":"754b553655cb26893153b45f292c82bf5dae2236"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"f66adb8bc90b2ccd3a42a9723717288b3a078fe3","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        super(VerifyChecksumTestCase, self).setUp()"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    @contextlib.contextmanager"},{"line_number":828,"context_line":"    def _intercept_log_messages(self):"},{"line_number":829,"context_line":"        try:"},{"line_number":830,"context_line":"            mylog \u003d logging.getLogger(\u0027nova\u0027)"},{"line_number":831,"context_line":"            stream \u003d cStringIO.StringIO()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FyDI%3D","line":828,"in_reply_to":"AAAAQn%2F%2Fyic%3D","updated":"2013-07-23 10:50:28.000000000","message":"I have chosen the second variant. But I\u0027ve put this change into the following commit: https://review.openstack.org/#/c/36031/ as it deals with code dedup.","commit_id":"754b553655cb26893153b45f292c82bf5dae2236"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"ca0013c0c0ed86988fd2690e596f60a31da862ed","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        super(VerifyChecksumTestCase, self).setUp()"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    @contextlib.contextmanager"},{"line_number":828,"context_line":"    def _intercept_log_messages(self):"},{"line_number":829,"context_line":"        try:"},{"line_number":830,"context_line":"            mylog \u003d logging.getLogger(\u0027nova\u0027)"},{"line_number":831,"context_line":"            stream \u003d cStringIO.StringIO()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fyic%3D","line":828,"in_reply_to":"AAAAQn%2F%2Fym0%3D","updated":"2013-07-23 07:45:35.000000000","message":"Well, it may be possible to create a superclass which will be the base to ImageCacheManagerTestCase and VerifyChecksumTestCase and move _intercept_log_messages() there or just remove it from classes and use as a module method.","commit_id":"754b553655cb26893153b45f292c82bf5dae2236"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"19b0715ee69878f29a9b9a6120f8a84014b97edd","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        super(VerifyChecksumTestCase, self).setUp()"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    @contextlib.contextmanager"},{"line_number":828,"context_line":"    def _intercept_log_messages(self):"},{"line_number":829,"context_line":"        try:"},{"line_number":830,"context_line":"            mylog \u003d logging.getLogger(\u0027nova\u0027)"},{"line_number":831,"context_line":"            stream \u003d cStringIO.StringIO()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fym0%3D","line":828,"in_reply_to":"AAAAQn%2F%2Fync%3D","updated":"2013-07-23 07:05:13.000000000","message":"I\u0027m on the fence.  splitting the classes seems reasonable but is there a way to not duplicate this?","commit_id":"754b553655cb26893153b45f292c82bf5dae2236"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"9737bad6c8b5b2cc512c14d16aeba5e620f96659","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        super(VerifyChecksumTestCase, self).setUp()"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    @contextlib.contextmanager"},{"line_number":828,"context_line":"    def _intercept_log_messages(self):"},{"line_number":829,"context_line":"        try:"},{"line_number":830,"context_line":"            mylog \u003d logging.getLogger(\u0027nova\u0027)"},{"line_number":831,"context_line":"            stream \u003d cStringIO.StringIO()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fync%3D","line":828,"in_reply_to":"AAAAQn%2F%2Fyqg%3D","updated":"2013-07-23 06:58:49.000000000","message":"It does, but I thought it would be better to move these tests to separate class anyway because they stand out.\n\nIf you think otherwise, please let me know.","commit_id":"754b553655cb26893153b45f292c82bf5dae2236"}]}