)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"572d465bfe766338438b0302ba5c69d3d76aec8d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Assume neutron port_binding extensions enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"No recent neutron deployment should ever have the port_binding extension"},{"line_number":10,"context_line":"missing in its list. This is causing confusion around when an"},{"line_number":11,"context_line":"admin_client should be used, among other things, so lets remove this"},{"line_number":12,"context_line":"needless complexity."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa7ab95a_d77cbbb7","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":20},"updated":"2016-08-31 22:48:39.000000000","message":"Is the port-binding extension required in neutron now and if so, when did that go into effect? Otherwise I\u0027m not sure about this assumption.","commit_id":"c86a3711a20d05b5244ee94acf1ce4d9fe3ac734"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2423ae3f1b14d6f1efb39790351648ebff8fe5d4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Assume neutron port_binding extensions enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"No recent neutron deployment should ever have the port_binding extension"},{"line_number":10,"context_line":"missing in its list. This is causing confusion around when an"},{"line_number":11,"context_line":"admin_client should be used, among other things, so lets remove this"},{"line_number":12,"context_line":"needless complexity."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a89bdaa_5087f611","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":20},"in_reply_to":"fa7ab95a_d77cbbb7","updated":"2016-09-09 12:23:38.000000000","message":"So the neutron folks seemed to say neutron wouldn\u0027t work without port binding.\n\nBut given the way neutron works, I am told if we send the binding details, and the extension is not present, it would just ignore those details.\n\nAnyways, we should double check with neutron folks.","commit_id":"c86a3711a20d05b5244ee94acf1ce4d9fe3ac734"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},"change_message_id":"5526b9a5aac2b3edee566967e8e8fe647ad80db6","unresolved":false,"context_lines":[{"line_number":2275,"context_line":"            if vnic_type in network_model.VNIC_TYPES_SRIOV:"},{"line_number":2276,"context_line":"                if not pci_mapping:"},{"line_number":2277,"context_line":"                    pci_mapping \u003d self._get_pci_mapping_for_migration(context,"},{"line_number":2278,"context_line":"                        instance, migration)"},{"line_number":2279,"context_line":""},{"line_number":2280,"context_line":"                binding_profile \u003d p.get(\u0027binding:profile\u0027, {})"},{"line_number":2281,"context_line":"                pci_slot \u003d binding_profile.get(\u0027pci_slot\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_b1c6f865","line":2278,"updated":"2016-08-30 02:07:28.000000000","message":"The \"migration\" param that was removed is used here, so this breaks. I can push a fix for it once I get the other tests working.","commit_id":"13c17c0700d4b8d0b70420580fe9e3c73b251df8"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9dc63782c48a0644482fa50ce68cdd5d3f1ccb42","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        nets \u003d self.nets[net_idx - 1]"},{"line_number":473,"context_line":"        ports \u003d {}"},{"line_number":474,"context_line":"        fixed_ips \u003d {}"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        macs \u003d kwargs.pop(\u0027macs\u0027, None)"},{"line_number":477,"context_line":"        if macs:"},{"line_number":478,"context_line":"            macs \u003d set(macs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_5bd8a879","line":475,"updated":"2017-07-27 11:48:42.000000000","message":"unrelated?","commit_id":"fbd200227cf8764458301ea788c6eadf41220835"}],"releasenotes/notes/require_port_binding_ext-e6d9bdd4f6eef4e3.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6e4c7fd3e76b9c56d02feffd856ea806e2a6dd70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Nova now has a hard requirement that the Portbinding extension is"},{"line_number":5,"context_line":"    enabled in the Neutron service. This simplifies the logic between"},{"line_number":6,"context_line":"    Nova and Neutron."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff346bd7_ec2c3d03","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":56},"updated":"2017-07-27 15:03:14.000000000","message":"Port Binding?\n\nPer the constants file.","commit_id":"fbd200227cf8764458301ea788c6eadf41220835"}]}