)]}'
{"nova/virt/libvirt/connection.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c49fe5935153412e382d48a7400c871ee3dea6e5","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self._host_state \u003d None"},{"line_number":190,"context_line":"        self._wrapped_conn \u003d None"},{"line_number":191,"context_line":"        self.container \u003d None"},{"line_number":192,"context_line":"        self.read_only \u003d read_only"},{"line_number":193,"context_line":"        if FLAGS.firewall_driver in firewall.drivers[\u0027libvirt\u0027]:"},{"line_number":194,"context_line":"            fw_class \u003d utils.import_class(FLAGS.firewall_driver)"},{"line_number":195,"context_line":"            self.firewall_driver \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F8Yo%3D","line":192,"updated":"2012-02-01 17:08:35.000000000","message":"I think we could add a:\nFLAGS[\u0027firewall_driver\u0027].SetDefault(\u0027nova.virt.libvirt.firewall.IptablesFirewallDriver\u0027)\nand a correspoonding one in xenapi. That would keep the default for libvirt while changing it for Xen.","commit_id":"9fb4b70de9ae4aba07563b6bf2c5535588ca35d8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ca19a2857e750a59a1b797a3fe3d58c00955dc27","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self._host_state \u003d None"},{"line_number":190,"context_line":"        self._wrapped_conn \u003d None"},{"line_number":191,"context_line":"        self.container \u003d None"},{"line_number":192,"context_line":"        self.read_only \u003d read_only"},{"line_number":193,"context_line":"        if FLAGS.firewall_driver in firewall.drivers[\u0027libvirt\u0027]:"},{"line_number":194,"context_line":"            fw_class \u003d utils.import_class(FLAGS.firewall_driver)"},{"line_number":195,"context_line":"            self.firewall_driver \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F8YY%3D","line":192,"in_reply_to":"AAAAEH%2F%2F8Yo%3D","updated":"2012-02-01 21:28:50.000000000","message":"I wanted to be more explicit, but that\u0027ll do just as well! I\u0027ll update the code accordingly.","commit_id":"9fb4b70de9ae4aba07563b6bf2c5535588ca35d8"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cbfeeefcbb6449734f6b74ca5fe6614aa16ea6ab","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                fw_class(get_connection\u003dself._get_connection)"},{"line_number":197,"context_line":"        else:"},{"line_number":198,"context_line":"            raise exception.\\"},{"line_number":199,"context_line":"                    NotSupported(config\u003d\u0027firewall_driver\u003d%s\u0027 %"},{"line_number":200,"context_line":"                                        FLAGS.firewall_driver,"},{"line_number":201,"context_line":"                                 driver\u003d\u0027libvirt\u0027,"},{"line_number":202,"context_line":"                                 reason\u003d\u0027invalid firewall driver. Default \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F8bg%3D","line":199,"updated":"2012-02-01 16:43:54.000000000","message":"For future reference—I like to avoid backslash continuation whenever possible.  My usual idiom for this situation is:\n\n    raise exception.NotSupported(\n        config\u003d…,\n        driver\u003d…,\n        reason\u003d…)","commit_id":"9fb4b70de9ae4aba07563b6bf2c5535588ca35d8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ca19a2857e750a59a1b797a3fe3d58c00955dc27","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                fw_class(get_connection\u003dself._get_connection)"},{"line_number":197,"context_line":"        else:"},{"line_number":198,"context_line":"            raise exception.\\"},{"line_number":199,"context_line":"                    NotSupported(config\u003d\u0027firewall_driver\u003d%s\u0027 %"},{"line_number":200,"context_line":"                                        FLAGS.firewall_driver,"},{"line_number":201,"context_line":"                                 driver\u003d\u0027libvirt\u0027,"},{"line_number":202,"context_line":"                                 reason\u003d\u0027invalid firewall driver. Default \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F8Z0%3D","line":199,"in_reply_to":"AAAAEH%2F%2F8bg%3D","updated":"2012-02-01 21:28:50.000000000","message":"gotcha, I\u0027ll address it in the next round of review.","commit_id":"9fb4b70de9ae4aba07563b6bf2c5535588ca35d8"}]}