)]}'
{"nova/scheduler/filters/affinity_filter.py":[{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"872a8788684fdf5b80c954c0dc39954c430c05ff","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":110,"context_line":"        group_hosts \u003d filter_properties.get(\u0027group_hosts\u0027) or []"},{"line_number":111,"context_line":"        LOG.debug(_(\"Group affinity: check if %(host)s in \""},{"line_number":112,"context_line":"                    \"%(configured)s\"), {\u0027host\u0027: host_state.host,"},{"line_number":113,"context_line":"                                        \u0027configured\u0027: group_hosts})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2F%2Fms%3D","line":110,"updated":"2013-07-07 01:11:18.000000000","message":"I prefer using filter_properties.get(\u0027group_hosts\u0027, [])","commit_id":"332e9ec26b49bf054ce0151602512e7e8b2c3215"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"c28e91537c499b12eed5bb85ff1a3085ee4e8076","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":110,"context_line":"        group_hosts \u003d filter_properties.get(\u0027group_hosts\u0027) or []"},{"line_number":111,"context_line":"        LOG.debug(_(\"Group affinity: check if %(host)s in \""},{"line_number":112,"context_line":"                    \"%(configured)s\"), {\u0027host\u0027: host_state.host,"},{"line_number":113,"context_line":"                                        \u0027configured\u0027: group_hosts})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2F%2FhE%3D","line":110,"in_reply_to":"AAAAP3%2F%2F%2FlA%3D","updated":"2013-07-07 04:32:23.000000000","message":"Done","commit_id":"332e9ec26b49bf054ce0151602512e7e8b2c3215"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"1a472ab19c1d8dacd076caa638e33e8462c5f619","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":110,"context_line":"        group_hosts \u003d filter_properties.get(\u0027group_hosts\u0027) or []"},{"line_number":111,"context_line":"        LOG.debug(_(\"Group affinity: check if %(host)s in \""},{"line_number":112,"context_line":"                    \"%(configured)s\"), {\u0027host\u0027: host_state.host,"},{"line_number":113,"context_line":"                                        \u0027configured\u0027: group_hosts})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2F%2FlA%3D","line":110,"in_reply_to":"AAAAP3%2F%2F%2FmM%3D","updated":"2013-07-07 02:14:34.000000000","message":"Well, it\u0027s just a coding style nitpick. :)\n\nSInce get(key,[default]) already provides a way to specify the default, why bother another \"or []\"?","commit_id":"332e9ec26b49bf054ce0151602512e7e8b2c3215"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"c31ed5e7e3a53b8cb064277adb15c10c83aac6fa","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":110,"context_line":"        group_hosts \u003d filter_properties.get(\u0027group_hosts\u0027) or []"},{"line_number":111,"context_line":"        LOG.debug(_(\"Group affinity: check if %(host)s in \""},{"line_number":112,"context_line":"                    \"%(configured)s\"), {\u0027host\u0027: host_state.host,"},{"line_number":113,"context_line":"                                        \u0027configured\u0027: group_hosts})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2F%2FmM%3D","line":110,"in_reply_to":"AAAAP3%2F%2F%2Fms%3D","updated":"2013-07-07 01:15:23.000000000","message":"Thanks Qin Yu, I\u0027m getting some code from GroupAntiAffinityFilter ;-)\n\nJust curious what is the reason for your proposal? Thanks!","commit_id":"332e9ec26b49bf054ce0151602512e7e8b2c3215"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"54e367922888fba62547b8d9b5f2f6d43449b6bf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":94,"context_line":"        group_hosts \u003d filter_properties.get(\u0027group_hosts\u0027) or []"},{"line_number":95,"context_line":"        LOG.debug(_(\"Group affinity: %(host)s in %(configured)s\"),"},{"line_number":96,"context_line":"                    {\u0027host\u0027: host_state.host,"},{"line_number":97,"context_line":"                     \u0027configured\u0027: group_hosts})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F%2FTY%3D","line":94,"updated":"2013-07-07 14:49:05.000000000","message":"You may want to change this too if you like.","commit_id":"09c96dad75c33550cc0711f6c0037895e72195a1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2af2d7cbe0892d77977ffaf333d5565717af812e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":94,"context_line":"        group_hosts \u003d filter_properties.get(\u0027group_hosts\u0027) or []"},{"line_number":95,"context_line":"        LOG.debug(_(\"Group affinity: %(host)s in %(configured)s\"),"},{"line_number":96,"context_line":"                    {\u0027host\u0027: host_state.host,"},{"line_number":97,"context_line":"                     \u0027configured\u0027: group_hosts})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F%2BqA%3D","line":94,"in_reply_to":"AAAAP3%2F%2F%2FTE%3D","updated":"2013-07-08 07:20:40.000000000","message":"ok. thanks","commit_id":"09c96dad75c33550cc0711f6c0037895e72195a1"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"74eb3d268152a674ea2d4e73ba7029823c058656","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":94,"context_line":"        group_hosts \u003d filter_properties.get(\u0027group_hosts\u0027) or []"},{"line_number":95,"context_line":"        LOG.debug(_(\"Group affinity: %(host)s in %(configured)s\"),"},{"line_number":96,"context_line":"                    {\u0027host\u0027: host_state.host,"},{"line_number":97,"context_line":"                     \u0027configured\u0027: group_hosts})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F%2FTE%3D","line":94,"in_reply_to":"AAAAP3%2F%2F%2FTY%3D","updated":"2013-07-07 14:53:53.000000000","message":"Thanks Gary, all of the filters in affinity_filter.py has such problem, it is better that we handle it in another patch. Thanks.","commit_id":"09c96dad75c33550cc0711f6c0037895e72195a1"}]}