)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"eac82626887a38a296eee0c676a3d467c4839a54","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexander Gorodnev \u003cagorodnev@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-05 09:18:21 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make ServerXMLSerializationTest DRYer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Blueprint: nova-tests-code-duplication"},{"line_number":10,"context_line":"Change-Id: Iffaec9555476cb8006130ec97f455d7810815970"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FnMA%3D","line":7,"updated":"2013-07-15 20:51:54.000000000","message":"Please add a paragraph describing what the change does and why it does it.  This simple statement is rather vague.","commit_id":"4a8b28a72c7c5fa450b8b70131b9ee251b5cad89"}],"nova/tests/api/openstack/compute/test_servers.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"eac82626887a38a296eee0c676a3d467c4839a54","unresolved":false,"context_lines":[{"line_number":4864,"context_line":"            }"},{"line_number":4865,"context_line":"        }"},{"line_number":4866,"context_line":""},{"line_number":4867,"context_line":"    def _validate_xml(self, root, server_dict):"},{"line_number":4868,"context_line":""},{"line_number":4869,"context_line":"        link_nodes \u003d root.findall(\u0027{0}link\u0027.format(ATOMNS))"},{"line_number":4870,"context_line":"        self.assertEqual(len(link_nodes), 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FnLc%3D","line":4867,"updated":"2013-07-15 20:51:54.000000000","message":"I would suggest looking at XMLMatches and perhaps using that in preference to a validator like this…","commit_id":"4a8b28a72c7c5fa450b8b70131b9ee251b5cad89"},{"author":{"_account_id":7794,"name":"Alexander Gorodnev","email":"agorodnev@griddynamics.com","username":"agorodnev"},"change_message_id":"d6ca872421d2befd0440d345a72684306115fc7b","unresolved":false,"context_lines":[{"line_number":4864,"context_line":"            }"},{"line_number":4865,"context_line":"        }"},{"line_number":4866,"context_line":""},{"line_number":4867,"context_line":"    def _validate_xml(self, root, server_dict):"},{"line_number":4868,"context_line":""},{"line_number":4869,"context_line":"        link_nodes \u003d root.findall(\u0027{0}link\u0027.format(ATOMNS))"},{"line_number":4870,"context_line":"        self.assertEqual(len(link_nodes), 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FyN0%3D","line":4867,"in_reply_to":"AAAAP3%2F%2FnLc%3D","updated":"2013-07-23 09:25:12.000000000","message":"I\u0027ve examined XMLMatches examples, in test_libvirt_config.py particularly, and every test has an embedded XML as reference value. Do you suggest that I add an appropriate reference XML to every test and then match it against the method\u0027s result?","commit_id":"4a8b28a72c7c5fa450b8b70131b9ee251b5cad89"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"06bacc6ece443353966b43f05213a0556f6ffaca","unresolved":false,"context_lines":[{"line_number":4864,"context_line":"            }"},{"line_number":4865,"context_line":"        }"},{"line_number":4866,"context_line":""},{"line_number":4867,"context_line":"    def _validate_xml(self, root, server_dict):"},{"line_number":4868,"context_line":""},{"line_number":4869,"context_line":"        link_nodes \u003d root.findall(\u0027{0}link\u0027.format(ATOMNS))"},{"line_number":4870,"context_line":"        self.assertEqual(len(link_nodes), 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Ft1s%3D","line":4867,"in_reply_to":"AAAAQn%2F%2Fup8%3D","updated":"2013-07-24 15:08:43.000000000","message":"That is perfectly acceptable to me.","commit_id":"4a8b28a72c7c5fa450b8b70131b9ee251b5cad89"},{"author":{"_account_id":7794,"name":"Alexander Gorodnev","email":"agorodnev@griddynamics.com","username":"agorodnev"},"change_message_id":"6e1b142d601d5612c9ac35ea225f5a69e734a4fa","unresolved":false,"context_lines":[{"line_number":4864,"context_line":"            }"},{"line_number":4865,"context_line":"        }"},{"line_number":4866,"context_line":""},{"line_number":4867,"context_line":"    def _validate_xml(self, root, server_dict):"},{"line_number":4868,"context_line":""},{"line_number":4869,"context_line":"        link_nodes \u003d root.findall(\u0027{0}link\u0027.format(ATOMNS))"},{"line_number":4870,"context_line":"        self.assertEqual(len(link_nodes), 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fup8%3D","line":4867,"in_reply_to":"AAAAQn%2F%2Fw1Y%3D","updated":"2013-07-24 09:57:08.000000000","message":"Your suggestion has advantages and disadvantages:\n+\n1) We can get rid of test_xml_declaration() test because all its work is just checking whether result is XML or not;\n2) Tests *may* have better accuracy;\n\n-\n1) Tests will bloat because of every reference XML contains ~ 80 lines;\n\n-----\nAs for me I would expand commit message by adding information what changes do and leave this function for a while. What do you think about it?","commit_id":"4a8b28a72c7c5fa450b8b70131b9ee251b5cad89"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6f1a8f4d7ffffc17c6b5039a7264204654faca2d","unresolved":false,"context_lines":[{"line_number":4864,"context_line":"            }"},{"line_number":4865,"context_line":"        }"},{"line_number":4866,"context_line":""},{"line_number":4867,"context_line":"    def _validate_xml(self, root, server_dict):"},{"line_number":4868,"context_line":""},{"line_number":4869,"context_line":"        link_nodes \u003d root.findall(\u0027{0}link\u0027.format(ATOMNS))"},{"line_number":4870,"context_line":"        self.assertEqual(len(link_nodes), 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fw1Y%3D","line":4867,"in_reply_to":"AAAAQn%2F%2FyN0%3D","updated":"2013-07-23 17:26:09.000000000","message":"That is the idea I had in mind, if it makes sense.  If it doesn\u0027t, *shrug* it was just a suggestion.","commit_id":"4a8b28a72c7c5fa450b8b70131b9ee251b5cad89"}]}