)]}'
{"nova/virt/hyperv.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"8e8cb30a41171f985ffbee3f62a37e3c54925be4","unresolved":false,"context_lines":[{"line_number":482,"context_line":"            \u0027ip\u0027: FLAGS.my_ip,"},{"line_number":483,"context_line":"            \u0027initiator\u0027: None"},{"line_number":484,"context_line":"        }"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def attach_volume(self, connection_info, instance_name, mountpoint):"},{"line_number":487,"context_line":"        vm \u003d self._lookup(instance_name)"},{"line_number":488,"context_line":"        if vm is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F%2F8w%3D","line":485,"updated":"2012-02-02 08:27:03.000000000","message":"Patch needs rebasing for this","commit_id":"6f9df7bd52caa0160db81c8b5828ab654ef9be1d"}],"nova/virt/libvirt/connection.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"8e8cb30a41171f985ffbee3f62a37e3c54925be4","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            except exception.ProcessExecutionError:"},{"line_number":434,"context_line":"                LOG.warn(_(\u0027Could not determine iscsi initiator name\u0027))"},{"line_number":435,"context_line":"                return None"},{"line_number":436,"context_line":"            _key, _sep, value \u003d out.strip().partition(\"\u003d\")"},{"line_number":437,"context_line":"            if not value:"},{"line_number":438,"context_line":"                LOG.warn(_(\u0027Could not determine iscsi initiator name\u0027))"},{"line_number":439,"context_line":"                return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F%2F8s%3D","line":436,"updated":"2012-02-02 08:27:03.000000000","message":"I was about to say that using grep is a bit gratuitous vs e.g.\n\n  def read_initiatorname():\n      with open(\u0027/etc/iscsi/initiatorname.iscsi\u0027, \u0027r\u0027) as f:\n          for l in f.readlines():\n              if l.startswith(\u0027InitiatorName\u003d\u0027):\n                  return l[l.index(\u0027\u003d\u0027) + 1:].strip()\n      return None\n\nand then I noticed you\u0027re running it as root\n\nWell, firstly, it\u0027s 0644 on Fedora ...\n\nIf it is 0600 elsewhere, I think we\u0027d be better have a read_file_as_root() utility and have a rootwrap filter based on the filename i.e.\n\n  def read_initiatorname():\n      contents \u003d utils.read_file_as_root(\u0027/etc/iscsi/initiatorname.iscsi\u0027)\n       for l in contents.split(\u0027\\n\u0027):\n          if l.startswith(\u0027InitiatorName\u003d\u0027):\n               return l[l.index(\u0027\u003d\u0027) + 1:].strip()\n      return None","commit_id":"6f9df7bd52caa0160db81c8b5828ab654ef9be1d"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"8e8cb30a41171f985ffbee3f62a37e3c54925be4","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        if virsh_output.startswith(\u0027/dev/\u0027):"},{"line_number":746,"context_line":"            LOG.info(_(\"cool, it\u0027s a device\"))"},{"line_number":747,"context_line":"            out, err \u003d libvirt_utils.execute(\u0027dd\u0027,"},{"line_number":748,"context_line":"                                             \u0027if\u003d%s\u0027 % virsh_output,"},{"line_number":749,"context_line":"                                             \u0027iflag\u003dnonblock\u0027,"},{"line_number":750,"context_line":"                                             run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F%2F8o%3D","line":747,"updated":"2012-02-02 08:27:03.000000000","message":"This change does nothing right? utils.execute() and libvirt_utils.execute() is the same thing. Seems pointlessly confusing?\n\nOh, it\u0027s for the tests? Why not just do:\n\n  self.mox.StubOutWithMock(utils, \"execute\")","commit_id":"6f9df7bd52caa0160db81c8b5828ab654ef9be1d"}]}