)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2bcb650198a86d5a97ac5f1ba01c834732cbcdb9","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.19\u0027):"},{"line_number":532,"context_line":"            description \u003d (server_dict[\u0027description\u0027]"},{"line_number":533,"context_line":"                           if \u0027description\u0027 in server_dict else None)"},{"line_number":534,"context_line":"        else:"},{"line_number":535,"context_line":"            description \u003d name"},{"line_number":536,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_35342e49","line":533,"updated":"2016-08-24 15:32:30.000000000","message":"Equivalent code:\n\n    description \u003d server_dict.get(\u0027description\u0027)","commit_id":"3699d63038e0f0baaf636f2952f54a83aa7b5552"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"2c3f9d82feb49d4e4f8a6ae0db3d14e5de2c7249","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.19\u0027):"},{"line_number":532,"context_line":"            description \u003d (server_dict[\u0027description\u0027]"},{"line_number":533,"context_line":"                           if \u0027description\u0027 in server_dict else None)"},{"line_number":534,"context_line":"        else:"},{"line_number":535,"context_line":"            description \u003d name"},{"line_number":536,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_525733ca","line":533,"in_reply_to":"1ac06dbe_35342e49","updated":"2016-08-24 18:38:14.000000000","message":"Done","commit_id":"3699d63038e0f0baaf636f2952f54a83aa7b5552"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2bcb650198a86d5a97ac5f1ba01c834732cbcdb9","unresolved":false,"context_lines":[{"line_number":603,"context_line":"                utils.is_neutron()) and ("},{"line_number":604,"context_line":"                    server_dict.get(\u0027networks\u0027) is not None):"},{"line_number":605,"context_line":"            requested_networks \u003d self._get_requested_networks("},{"line_number":606,"context_line":"                server_dict.get(\u0027networks\u0027), supports_device_tagging)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        if requested_networks and len(requested_networks):"},{"line_number":609,"context_line":"            context.can(server_policies.SERVERS % \u0027create:attach_network\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_b5e49eac","line":606,"updated":"2016-08-24 15:32:30.000000000","message":"We\u0027ve just established, on line 604, that the \u0027networks\u0027 key exists in server_dict, so this can now become:\n\n    server_dict[\u0027networks\u0027]","commit_id":"3699d63038e0f0baaf636f2952f54a83aa7b5552"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"2c3f9d82feb49d4e4f8a6ae0db3d14e5de2c7249","unresolved":false,"context_lines":[{"line_number":603,"context_line":"                utils.is_neutron()) and ("},{"line_number":604,"context_line":"                    server_dict.get(\u0027networks\u0027) is not None):"},{"line_number":605,"context_line":"            requested_networks \u003d self._get_requested_networks("},{"line_number":606,"context_line":"                server_dict.get(\u0027networks\u0027), supports_device_tagging)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        if requested_networks and len(requested_networks):"},{"line_number":609,"context_line":"            context.can(server_policies.SERVERS % \u0027create:attach_network\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_325c37ed","line":606,"in_reply_to":"1ac06dbe_b5e49eac","updated":"2016-08-24 18:38:14.000000000","message":"Done","commit_id":"3699d63038e0f0baaf636f2952f54a83aa7b5552"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a62289fd5acf3a648903bc184b7bd56a33029c67","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derr.format_message())"},{"line_number":210,"context_line":"        return servers"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def _get_servers_filters(self, context, req, search_opts):"},{"line_number":213,"context_line":"        if \u0027changes-since\u0027 in search_opts:"},{"line_number":214,"context_line":"            try:"},{"line_number":215,"context_line":"                parsed \u003d timeutils.parse_isotime(search_opts[\u0027changes-since\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_b61fb559","line":212,"range":{"start_line":212,"start_character":8,"end_line":212,"end_character":28},"updated":"2016-08-30 10:46:14.000000000","message":"clean or validate seems better than just calling this \"get\" given it raises exceptions.","commit_id":"f24d120ba2945e21657480a7ea4373563d050ba9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9a92fb9a1d15481b1de18838e85a04fc893c21f9","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derr.format_message())"},{"line_number":217,"context_line":"        return servers"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def _get_servers_filters(self, context, req, search_opts):"},{"line_number":220,"context_line":"        if \u0027changes-since\u0027 in search_opts:"},{"line_number":221,"context_line":"            search_opts[\u0027changes-since\u0027] \u003d timeutils.parse_isotime("},{"line_number":222,"context_line":"                search_opts[\u0027changes-since\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_4457cd25","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":28},"updated":"2017-02-23 11:47:17.000000000","message":"_get is not a great name here, because this is intended to be used to reformat and completely replace and existing structure.\n\n_normalize_servers_filters might be better.\n\nAlso, this is complicated enough, doc string on the method please to explain what it does, and what appropriate transformations should go in this method in future.","commit_id":"fae73d5dcbfe41d1513547c0972ee84c9052f3d1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9a92fb9a1d15481b1de18838e85a04fc893c21f9","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        remove_invalid_options(context, search_opts,"},{"line_number":262,"context_line":"                               self._get_server_search_options(req))"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        for search_opt in search_opts:"},{"line_number":265,"context_line":"            if (search_opt in"},{"line_number":266,"context_line":"                    schema_servers.JOINED_TABLE_QUERY_PARAMS_SERVERS.keys() or"},{"line_number":267,"context_line":"                    search_opt.startswith(\u0027_\u0027)):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_642bf194","line":264,"updated":"2017-02-23 11:47:17.000000000","message":"I\u0027m not sure I understand why these parts of search_opts aren\u0027t in the extracted method.","commit_id":"fae73d5dcbfe41d1513547c0972ee84c9052f3d1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9a92fb9a1d15481b1de18838e85a04fc893c21f9","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        name \u003d common.normalize_name(server_dict[\u0027name\u0027])"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.19\u0027):"},{"line_number":543,"context_line":"            description \u003d server_dict.get(\u0027description\u0027)"},{"line_number":544,"context_line":"        else:"},{"line_number":545,"context_line":"            description \u003d name"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_648f71cc","line":543,"updated":"2017-02-23 11:47:17.000000000","message":"nice","commit_id":"fae73d5dcbfe41d1513547c0972ee84c9052f3d1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8022acea28a2df88e10655a6fad50c821088de54","unresolved":false,"context_lines":[{"line_number":609,"context_line":"                                                  False)"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        requested_networks \u003d None"},{"line_number":612,"context_line":"        if (\u0027os-networks\u0027 in self.extension_info.get_extensions() or"},{"line_number":613,"context_line":"                utils.is_neutron()) and ("},{"line_number":614,"context_line":"                    server_dict.get(\u0027networks\u0027) is not None):"},{"line_number":615,"context_line":"            requested_networks \u003d self._get_requested_networks("},{"line_number":616,"context_line":"                server_dict[\u0027networks\u0027], supports_device_tagging)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_2489f9c9","line":613,"range":{"start_line":612,"start_character":12,"end_line":613,"end_character":35},"updated":"2017-02-23 11:41:25.000000000","message":"is it even feasable that this is ever false in any real deployment?","commit_id":"fae73d5dcbfe41d1513547c0972ee84c9052f3d1"}]}